Commit c1f11770 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

Pointless to check for non-NULL pointers that already have been dereferenced 

and they have to be non-NULL long before this check.
CID 22 in the coverity.com scan
parent 7ea90c46

lib/ssluse.c

+2 −2
Original line number Diff line number Diff line
@@ -431,7 +431,7 @@ int cert_stuff(struct connectdata *conn, 
#ifdef HAVE_OPENSSL_ENGINE_H

      {                         /* XXXX still needs some work */

        EVP_PKEY *priv_key = NULL;

        if(conn && conn->data && conn->data->state.engine) {

        if(data->state.engine) {

#ifdef HAVE_ENGINE_LOAD_FOUR_ARGS

          UI_METHOD *ui_method = UI_OpenSSL();

#endif
@@ -441,7 +441,7 @@ int cert_stuff(struct connectdata *conn, 
          }

          /* the typecast below was added to please mingw32 */

          priv_key = (EVP_PKEY *)

            ENGINE_load_private_key(conn->data->state.engine,key_file,

            ENGINE_load_private_key(data->state.engine,key_file,

#ifdef HAVE_ENGINE_LOAD_FOUR_ARGS

                                    ui_method,

#endif