Commit b85c625d authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

detect_proxy: fix possible single-byte memory leak 

Coverity CID 1202836. If the proxy environment variable returned an empty
string, it would be leaked. While an empty string is not really a proxy, other
logic in this function already allows a blank string to be returned so allow
that here to avoid the leak.
parent 0d357155

lib/url.c

+1 −2
Original line number Diff line number Diff line
@@ -4339,9 +4339,8 @@ static char *detect_proxy(struct connectdata *conn) 
      prox=curl_getenv(proxy_env);

    }



    if(prox && *prox) { /* don't count "" strings */

    if(prox)

      proxy = prox; /* use this */

    }

    else {

      proxy = curl_getenv("all_proxy"); /* default proxy to use */

      if(!proxy)