Commit b55e85d4 authored Oct 07, 2018 by Daniel Gustafsson

gskit: make sure to terminate version string



In case a very small buffer was passed to the version function, it could
result in the buffer not being NULL-terminated since strncpy() doesn't
guarantee a terminator on an overflowed buffer. Rather than adding code
to terminate (and handle zero-sized buffers), move to using snprintf()
instead like all the other vtls backends.

Closes #3105
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Reviewed-by: Viktor Szakats <commit@vszakats.net>

parent c1af9b76

lib/vtls/gskit.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1314,8 +1314,7 @@ static int Curl_gskit_shutdown(struct connectdata *conn, int sockindex)

		static size_t Curl_gskit_version(char *buffer, size_t size)
		{
		strncpy(buffer, "GSKit", size);
		return strlen(buffer);
		return snprintf(buffer, size, "GSKit");
		}