Commit a9e46749 authored by Da-Yoon Chung's avatar Da-Yoon Chung Committed by Daniel Stenberg
Browse files

lib/transfer.c: Remove factor of 8 from sleep time calculation 

The factor of 8 is a bytes-to-bits conversion factor, but pkt_size and
rate_bps are both in bytes. When using the rate limiting option, curl
waits 8 times too long, and then transfers very quickly until the
average rate reaches the limit. The average rate follows the limit over
time, but the actual traffic is bursty.

Thanks-to: Benjamin Gilbert
parent c3101ae2

lib/transfer.c

+1 −1
Original line number Diff line number Diff line
@@ -1270,7 +1270,7 @@ long Curl_sleep_time(curl_off_t rate_bps, curl_off_t cur_rate_bps, 
   * the next packet at the adjusted rate.  We should wait

   * longer when using larger packets, for instance.

   */

  rv = ((curl_off_t)((pkt_size * 8) * 1000) / rate_bps);

  rv = ((curl_off_t)(pkt_size * 1000) / rate_bps);



  /* Catch rounding errors and always slow down at least 1ms if

   * we are running too fast.