Commit a6618b52 authored by Jay Satiro's avatar Jay Satiro
Browse files

tool_urlglob: Improve sanity check in glob_range 

Prior to this change we depended on errno if strtol could not perform a
conversion. POSIX says EINVAL *may* be set. Some implementations like
Microsoft's will not set it if there's no conversion.

Ref: https://github.com/curl/curl/commit/ee4f7660#commitcomment-19658189
parent 4bda3e04

src/tool_urlglob.c

+1 −1
Original line number Diff line number Diff line
@@ -201,7 +201,7 @@ static CURLcode glob_range(URLGlob *glob, char **patternp, 
        unsigned long lstep;

        errno = 0;

        lstep = strtoul(&pattern[4], &endp, 10);

        if(errno || (*endp != ']'))

        if(errno || &pattern[4] == endp || *endp != ']')

          step = -1;

        else {

          pattern = endp+1;