Commit 980f2b70 authored by Steve Holme's avatar Steve Holme
Browse files

ntlm: Return all errors from Curl_ntlm_core_mk_nt_hash() 

For consistency with other areas of the NTLM code propagate all errors
from Curl_ntlm_core_mk_nt_hash() up the call stack rather than just
CURLE_OUT_OF_MEMORY.
parent 3b738a16

lib/curl_ntlm_msgs.c

+7 −6
Original line number Diff line number Diff line
@@ -805,9 +805,9 @@ CURLcode Curl_ntlm_create_type3_message(struct SessionHandle *data, 


    /* We shall only use the first 8 bytes of md5sum, but the des

       code in Curl_ntlm_core_lm_resp only encrypt the first 8 bytes */

    if(CURLE_OUT_OF_MEMORY ==

       Curl_ntlm_core_mk_nt_hash(data, passwdp, ntbuffer))

      return CURLE_OUT_OF_MEMORY;

    result = Curl_ntlm_core_mk_nt_hash(data, passwdp, ntbuffer);

    if(result)

      return result;



    Curl_ntlm_core_lm_resp(ntbuffer, md5sum, ntresp);
@@ -824,9 +824,10 @@ CURLcode Curl_ntlm_create_type3_message(struct SessionHandle *data, 
    unsigned char lmbuffer[0x18];



#if USE_NTRESPONSES

    if(CURLE_OUT_OF_MEMORY ==

       Curl_ntlm_core_mk_nt_hash(data, passwdp, ntbuffer))

      return CURLE_OUT_OF_MEMORY;

    result = Curl_ntlm_core_mk_nt_hash(data, passwdp, ntbuffer);

    if(result)

      return result;



    Curl_ntlm_core_lm_resp(ntbuffer, &ntlm->nonce[0], ntresp);

#endif