Commit 84bd19ff authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

timers: fix timer regression involving redirects / reconnects 

In commit 0b3750b5 (released in 7.36.0) we fixed a timeout issue
but instead broke the timings.

To fix this, I introduce a new timestamp to use for the timeouts and
restored the previous timestamp and timestamp position so that the old
timer functionality is restored.

In addition to that, that change also broke connection timeouts for when
more than one connect was used (as it would then count the total time
from the first connect and not for the most recent one). Now
Curl_timeleft() has been modified so that it checks against different
start times depending on which timeout it checks.

Test 1303 is updated accordingly.

Bug: http://curl.haxx.se/mail/lib-2014-05/0147.html
Reported-by: Ryan Braud
parent 678239df

lib/connect.c

+6 −1
Original line number Diff line number Diff line
@@ -224,7 +224,12 @@ long Curl_timeleft(struct SessionHandle *data, 
  }



  /* subtract elapsed time */

  if(duringconnect)

    /* since this most recent connect started */

    timeout_ms -= Curl_tvdiff(*nowp, data->progress.t_startsingle);

  else

    /* since the entire operation started */

    timeout_ms -= Curl_tvdiff(*nowp, data->progress.t_startop);

  if(!timeout_ms)

    /* avoid returning 0 as that means no timeout! */

    return -1;

lib/multi.c

+2 −1
Original line number Diff line number Diff line
@@ -1026,7 +1026,7 @@ static CURLMcode multi_runsingle(struct Curl_multi *multi, 
      if(CURLE_OK == data->result) {

        /* after init, go CONNECT */

        multistate(data, CURLM_STATE_CONNECT);

        Curl_pgrsTime(data, TIMER_STARTSINGLE);

        Curl_pgrsTime(data, TIMER_STARTOP);

        result = CURLM_CALL_MULTI_PERFORM;

      }

      break;
@@ -1038,6 +1038,7 @@ static CURLMcode multi_runsingle(struct Curl_multi *multi, 


    case CURLM_STATE_CONNECT:

      /* Connect. We want to get a connection identifier filled in. */

      Curl_pgrsTime(data, TIMER_STARTSINGLE);

      data->result = Curl_connect(data, &data->easy_conn,

                                  &async, &protocol_connect);

      if(CURLE_NO_CONNECTION_AVAILABLE == data->result) {

lib/progress.c

+6 −2
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 
 *                            | (__| |_| |  _ <| |___

 *                             \___|\___/|_| \_\_____|

 *

 * Copyright (C) 1998 - 2013, Daniel Stenberg, <daniel@haxx.se>, et al.

 * Copyright (C) 1998 - 2014, Daniel Stenberg, <daniel@haxx.se>, et al.

 *

 * This software is licensed as described in the file COPYING, which

 * you should have received as part of this distribution. The terms
@@ -172,8 +172,12 @@ void Curl_pgrsTime(struct SessionHandle *data, timerid timer) 
  case TIMER_NONE:

    /* mistake filter */

    break;

  case TIMER_STARTOP:

    /* This is set at the start of a transfer */

    data->progress.t_startop = now;

    break;

  case TIMER_STARTSINGLE:

    /* This is set at the start of a single fetch */

    /* This is set at the start of each single fetch */

    data->progress.t_startsingle = now;

    break;

lib/progress.h

+3 −2
Original line number Diff line number Diff line
@@ -7,7 +7,7 @@ 
 *                            | (__| |_| |  _ <| |___

 *                             \___|\___/|_| \_\_____|

 *

 * Copyright (C) 1998 - 2012, Daniel Stenberg, <daniel@haxx.se>, et al.

 * Copyright (C) 1998 - 2014, Daniel Stenberg, <daniel@haxx.se>, et al.

 *

 * This software is licensed as described in the file COPYING, which

 * you should have received as part of this distribution. The terms
@@ -27,13 +27,14 @@ 


typedef enum {

  TIMER_NONE,

  TIMER_STARTOP,

  TIMER_STARTSINGLE,

  TIMER_NAMELOOKUP,

  TIMER_CONNECT,

  TIMER_APPCONNECT,

  TIMER_PRETRANSFER,

  TIMER_STARTTRANSFER,

  TIMER_POSTRANSFER,

  TIMER_STARTSINGLE,

  TIMER_STARTACCEPT,

  TIMER_REDIRECT,

  TIMER_LAST /* must be last */

lib/urldata.h

+1 −0
Original line number Diff line number Diff line
@@ -1135,6 +1135,7 @@ struct Progress { 


  struct timeval start;

  struct timeval t_startsingle;

  struct timeval t_startop;

  struct timeval t_acceptdata;

#define CURR_TIME (5+1) /* 6 entries for 5 seconds */