Commit 67920e15 authored by Tatsuhiro Tsujikawa's avatar Tatsuhiro Tsujikawa Committed by Daniel Stenberg
Browse files

HTTP/2: Fix infinite loop in readwrite_data() 

To prevent infinite loop in readwrite_data() function when stream is
reset before any response body comes, reset closed flag to false once
it is evaluated to true.
parent 4d4dd7ae

lib/http2.c

+6 −0
Original line number Diff line number Diff line
@@ -668,6 +668,9 @@ static ssize_t http2_recv(struct connectdata *conn, int sockindex, 
  (void)sockindex; /* we always do HTTP2 on sockindex 0 */



  if(httpc->closed) {

    /* Reset to FALSE to prevent infinite loop in readwrite_data

       function. */

    httpc->closed = FALSE;

    return 0;

  }
@@ -747,6 +750,9 @@ static ssize_t http2_recv(struct connectdata *conn, int sockindex, 
  /* If stream is closed, return 0 to signal the http routine to close

     the connection */

  if(httpc->closed) {

    /* Reset to FALSE to prevent infinite loop in readwrite_data

       function. */

    httpc->closed = FALSE;

    return 0;

  }

  *err = CURLE_AGAIN;