Commit 5f3824a5 authored by Brad King's avatar Brad King Committed by Daniel Stenberg
Browse files

CMake: Restore order-dependent library checks 



Revert commit 2257deb5 (Cmake: Avoid cycle directory dependencies,
2014-08-22) and add a comment explaining the purpose of the original
code.

The check_library_exists_concat macro is intended to be called multiple
times on a sequence of possibly dependent libraries.  Later libraries
may depend on earlier libraries when they are static.  They cannot be
safely linked in reverse order on some platforms.

Signed-off-by: default avatarBrad King <brad.king@kitware.com>
parent 1ae06e00

CMake/Macros.cmake

+6 −3
Original line number Diff line number Diff line 
#File defines convenience macros for available feature testing



# This macro checks if the symbol exists in the library and if it

# does, it appends library to the list.

# does, it prepends library to the list.  It is intended to be called

# multiple times with a sequence of possibly dependent libraries in

# order of least-to-most-dependent.  Some libraries depend on others

# to link correctly.

macro(CHECK_LIBRARY_EXISTS_CONCAT LIBRARY SYMBOL VARIABLE)

  check_library_exists("${CURL_LIBS};${LIBRARY}" ${SYMBOL} "${CMAKE_LIBRARY_PATH}"

  check_library_exists("${LIBRARY};${CURL_LIBS}" ${SYMBOL} "${CMAKE_LIBRARY_PATH}"

    ${VARIABLE})

  if(${VARIABLE})

    list(APPEND CURL_LIBS ${LIBRARY})

    set(CURL_LIBS ${LIBRARY} ${CURL_LIBS})

  endif(${VARIABLE})

endmacro(CHECK_LIBRARY_EXISTS_CONCAT)