Commit 4d28a59f authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

-# progress meter: avoid superfluous updates and duplicate lines 

By comparing if a different "progress point" is reached or not since the
previous update, the progress function callback for this now avoids many
superfluous screen updates. This has the nice side-effect that it fixes
a problem that causes a second progress meter line.

The second line output happened because when we use the -# progress
meter, we force a newline output after the transfer in the main loop in
curl, but when libcurl calls the progress callback from
curl_easy_cleanup() it would then output the progress display
again. Possibly the naive newline output is wrong but this optimization
was suitable anyway...

Reported by: Daniel Theron
Bug: http://curl.haxx.se/bug/view.cgi?id=3517418
parent a498daa0

src/tool_cb_prg.c

+1 −1
Original line number Diff line number Diff line
@@ -76,7 +76,7 @@ int tool_progress_cb(void *clientp, 
      prevblock++;

    }

  }

  else {

  else if(point != bar->prev) {

    frac = (double)point / (double)total;

    percent = frac * 100.0f;

    barwidth = bar->width - 7;