Skip to content
Snippets Groups Projects
Commit 4af08a19 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

passing in a very long interface name could make a buffer overflow

parent c14650ca
No related branches found
No related tags found
No related merge requests found
......@@ -94,8 +94,11 @@ char *Curl_if2ip(const char *interface, char *buf, int buf_size)
}
else {
struct ifreq req;
size_t len = strlen(interface);
memset(&req, 0, sizeof(req));
strcpy(req.ifr_name, interface);
if(len >= sizeof(req.ifr_name))
return NULL; /* this can't be a fine interface name */
memcpy(req.ifr_name, interface, len+1);
req.ifr_addr.sa_family = AF_INET;
#ifdef IOCTL_3_ARGS
if (SYS_ERROR == ioctl(dummy, SIOCGIFADDR, &req)) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment