Commit 462f3cac authored by Jay Satiro's avatar Jay Satiro
Browse files

url: remove arg value check from CURLOPT_SSH_AUTH_TYPES 

Since CURLSSH_AUTH_ANY (aka CURLSSH_AUTH_DEFAULT) is ~0 an arg value
check on this option is incorrect; we have to accept any value.

Prior to this change since f121575c (7.56.1+) CURLOPT_SSH_AUTH_TYPES
erroneously rejected CURLSSH_AUTH_ANY with CURLE_BAD_FUNCTION_ARGUMENT.

Bug: https://github.com/curl/curl/commit/f121575#commitcomment-25347120
parent 685ef130

lib/url.c

+1 −4
Changes for lib/url.c: 1 added line, 4 removed lines.
Original line number Diff line number Diff line
@@ -2710,10 +2710,7 @@ CURLcode Curl_setopt(struct Curl_easy *data, CURLoption option, 
#ifdef USE_LIBSSH2

    /* we only include SSH options if explicitly built to support SSH */

  case CURLOPT_SSH_AUTH_TYPES:

    arg = va_arg(param, long);

    if(arg < CURLSSH_AUTH_NONE)

      return CURLE_BAD_FUNCTION_ARGUMENT;

    data->set.ssh_auth_types = arg;

    data->set.ssh_auth_types = va_arg(param, long);

    break;



  case CURLOPT_SSH_PUBLIC_KEYFILE: