Skip to content
Snippets Groups Projects
Commit 4120b7b0 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

check the arguments to the socks5 function, as the name and password might

be NULL pointers, and if non-NULL if now support zero-length names/passwords
parent fac1c138
No related branches found
No related tags found
No related merge requests found
......@@ -1590,7 +1590,7 @@ static int handleSock5Proxy(const char *proxy_name,
Curl_nonblock(sock, FALSE);
socksreq[0] = 5; /* version */
socksreq[1] = (char)(proxy_name[0] ? 2 : 1); /* number of methods (below) */
socksreq[1] = (char)(proxy_name ? 2 : 1); /* number of methods (below) */
socksreq[2] = 0; /* no authentication */
socksreq[3] = 2; /* username/password */
......@@ -1620,7 +1620,7 @@ static int handleSock5Proxy(const char *proxy_name,
int userlen, pwlen, len;
userlen = strlen(proxy_name);
pwlen = strlen(proxy_password);
pwlen = proxy_password?strlen(proxy_password):0;
/* username/password request looks like
* +----+------+----------+------+----------+
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment