Commit 40e8b4e5 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

- I removed the default use of "Pragma: no-cache" from libcurl when a proxy is 

  used. It has been used since forever but it was never a good idea to use
  unless explicitly asked for.
parent 4741e64c

CHANGES

+8 −0
Original line number Diff line number Diff line
@@ -7,6 +7,14 @@ 
                                  Changelog



Daniel Stenberg (19 Nov 2008)

- I removed the default use of "Pragma: no-cache" from libcurl when a proxy is

  used. It has been used since forever but it was never a good idea to use

  unless explicitly asked for.



- Josef Wolf's extension that allows a $TESTDIR/gdbinit$testnum file that when

  you use runtests.pl -g, will be sourced by gdb to allow additional fancy or

  whatever you see fit



- Christian Krause reported and fixed a memory leak that would occur with HTTP

  GSS/kerberos authentication (http://curl.haxx.se/bug/view.cgi?id=2284386)

RELEASE-NOTES

+2 −1
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ This release includes the following bugfixes: 
 o re-use of connections with the multi interface when multiple handles used

   the same server

 o memory leak with HTTP GSS/kerberos authentication

 o removed the default use of "Pragma: no-cache"



This release includes the following known bugs:
@@ -33,6 +34,6 @@ This release would not have looked like this without help, code, reports and 
advice from friends like these:



 Yang Tse, Daniel Fandrich, Jim Meyering, Christian Krause, Andreas Wurf,

 Markus Koetter

 Markus Koetter, Josef Wolf



        Thanks! (and sorry if I forgot to mention someone)

lib/http.c

+0 −7
Original line number Diff line number Diff line
@@ -2290,11 +2290,6 @@ CURLcode Curl_http(struct connectdata *conn, bool *done) 
  }





  http->p_pragma =

    (!checkheaders(data, "Pragma:") &&

     (conn->bits.httpproxy && !conn->bits.tunnel_proxy) )?

    "Pragma: no-cache\r\n":NULL;



  http->p_accept = checkheaders(data, "Accept:")?NULL:"Accept: */*\r\n";



  if(( (HTTPREQ_POST == httpreq) ||
@@ -2440,7 +2435,6 @@ CURLcode Curl_http(struct connectdata *conn, bool *done) 
                "%s" /* range */

                "%s" /* user agent */

                "%s" /* host */

                "%s" /* pragma */

                "%s" /* accept */

                "%s" /* accept-encoding */

                "%s" /* referer */
@@ -2460,7 +2454,6 @@ CURLcode Curl_http(struct connectdata *conn, bool *done) 
                 *data->set.str[STRING_USERAGENT] && conn->allocptr.uagent)?

                conn->allocptr.uagent:"",

                (conn->allocptr.host?conn->allocptr.host:""), /* Host: host */

                http->p_pragma?http->p_pragma:"",

                http->p_accept?http->p_accept:"",

                (data->set.str[STRING_ENCODING] &&

                 *data->set.str[STRING_ENCODING] &&

tests/data/test1001

+0 −2
Original line number Diff line number Diff line
@@ -84,7 +84,6 @@ GET http://%HOSTIP:%HTTPPORT/1001 HTTP/1.1 
Content-Range: bytes 2-4/5

User-Agent: curl/7.12.1-CVS (i686-pc-linux-gnu) libcurl/7.12.1-CVS OpenSSL/0.9.6b ipv6 zlib/1.1.4 GSS libidn/0.4.6

Host: %HOSTIP:%HTTPPORT

Pragma: no-cache

Accept: */*

Proxy-Connection: Keep-Alive

Content-Length: 0
@@ -94,7 +93,6 @@ GET http://%HOSTIP:%HTTPPORT/1001 HTTP/1.1 
Authorization: Digest username="auser", realm="testrealm", nonce="1053604144", uri="/1001", response="6af4d89c952f4dd4cc215a6878dc499d"

Content-Range: bytes 2-4/5

Host: %HOSTIP:%HTTPPORT

Pragma: no-cache

Accept: */*

Proxy-Connection: Keep-Alive

Content-Length: 3

tests/data/test1002

+0 −3
Original line number Diff line number Diff line
@@ -83,7 +83,6 @@ GET http://%HOSTIP:%HTTPPORT/1002.upload1 HTTP/1.1 
Content-Range: bytes 2-4/5

User-Agent: curl/7.12.1-CVS (i686-pc-linux-gnu) libcurl/7.12.1-CVS OpenSSL/0.9.6b ipv6 zlib/1.1.4 GSS libidn/0.4.6

Host: %HOSTIP:%HTTPPORT

Pragma: no-cache

Accept: */*

Proxy-Connection: Keep-Alive

Content-Length: 0
@@ -93,7 +92,6 @@ GET http://%HOSTIP:%HTTPPORT/1002.upload1 HTTP/1.1 
Authorization: Digest username="auser", realm="testrealm", nonce="1053604144", uri="/1002.upload1", response="198aa9b6acb4b0c71d02a197a5e41f54"

Content-Range: bytes 2-4/5

Host: %HOSTIP:%HTTPPORT

Pragma: no-cache

Accept: */*

Proxy-Connection: Keep-Alive

Content-Length: 3
@@ -105,7 +103,6 @@ Authorization: Digest username="auser", realm="testrealm", nonce="1053604144", u 
Content-Range: bytes 2-4/5

User-Agent: curl/7.16.1

Host: %HOSTIP:%HTTPPORT

Pragma: no-cache

Accept: */*

Proxy-Connection: Keep-Alive

Content-Length: 3