- I removed the default use of "Pragma: no-cache" from libcurl when a proxy is

  used. It has been used since forever but it was never a good idea to use
  unless explicitly asked for.

CHANGES

@@ -7,6 +7,14 @@
                                   Changelog
 
 Daniel Stenberg (19 Nov 2008)
+- I removed the default use of "Pragma: no-cache" from libcurl when a proxy is
+  used. It has been used since forever but it was never a good idea to use
+  unless explicitly asked for.
+
+- Josef Wolf's extension that allows a $TESTDIR/gdbinit$testnum file that when
+  you use runtests.pl -g, will be sourced by gdb to allow additional fancy or
+  whatever you see fit
+
 - Christian Krause reported and fixed a memory leak that would occur with HTTP
   GSS/kerberos authentication (http://curl.haxx.se/bug/view.cgi?id=2284386)
 

RELEASE-NOTES

@@ -20,6 +20,7 @@ This release includes the following bugfixes:
  o re-use of connections with the multi interface when multiple handles used
    the same server
  o memory leak with HTTP GSS/kerberos authentication
+ o removed the default use of "Pragma: no-cache"
 
 This release includes the following known bugs:
 
@@ -33,6 +34,6 @@ This release would not have looked like this without help, code, reports and
 advice from friends like these:
 
  Yang Tse, Daniel Fandrich, Jim Meyering, Christian Krause, Andreas Wurf,
- Markus Koetter
+ Markus Koetter, Josef Wolf
 
         Thanks! (and sorry if I forgot to mention someone)

lib/http.c

@@ -2290,11 +2290,6 @@ CURLcode Curl_http(struct connectdata *conn, bool *done)
   }
 
 
-  http->p_pragma =
-    (!checkheaders(data, "Pragma:") &&
-     (conn->bits.httpproxy && !conn->bits.tunnel_proxy) )?
-    "Pragma: no-cache\r\n":NULL;
-
   http->p_accept = checkheaders(data, "Accept:")?NULL:"Accept: */*\r\n";
 
   if(( (HTTPREQ_POST == httpreq) ||
@@ -2440,7 +2435,6 @@ CURLcode Curl_http(struct connectdata *conn, bool *done)
                 "%s" /* range */
                 "%s" /* user agent */
                 "%s" /* host */
-                "%s" /* pragma */
                 "%s" /* accept */
                 "%s" /* accept-encoding */
                 "%s" /* referer */
@@ -2460,7 +2454,6 @@ CURLcode Curl_http(struct connectdata *conn, bool *done)
                  *data->set.str[STRING_USERAGENT] && conn->allocptr.uagent)?
                 conn->allocptr.uagent:"",
                 (conn->allocptr.host?conn->allocptr.host:""), /* Host: host */
-                http->p_pragma?http->p_pragma:"",
                 http->p_accept?http->p_accept:"",
                 (data->set.str[STRING_ENCODING] &&
                  *data->set.str[STRING_ENCODING] &&

tests/data/test1001

@@ -84,7 +84,6 @@ GET http://%HOSTIP:%HTTPPORT/1001 HTTP/1.1
 Content-Range: bytes 2-4/5
 User-Agent: curl/7.12.1-CVS (i686-pc-linux-gnu) libcurl/7.12.1-CVS OpenSSL/0.9.6b ipv6 zlib/1.1.4 GSS libidn/0.4.6
 Host: %HOSTIP:%HTTPPORT
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 Content-Length: 0
@@ -94,7 +93,6 @@ GET http://%HOSTIP:%HTTPPORT/1001 HTTP/1.1
 Authorization: Digest username="auser", realm="testrealm", nonce="1053604144", uri="/1001", response="6af4d89c952f4dd4cc215a6878dc499d"
 Content-Range: bytes 2-4/5
 Host: %HOSTIP:%HTTPPORT
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 Content-Length: 3

tests/data/test1002

@@ -83,7 +83,6 @@ GET http://%HOSTIP:%HTTPPORT/1002.upload1 HTTP/1.1
 Content-Range: bytes 2-4/5
 User-Agent: curl/7.12.1-CVS (i686-pc-linux-gnu) libcurl/7.12.1-CVS OpenSSL/0.9.6b ipv6 zlib/1.1.4 GSS libidn/0.4.6
 Host: %HOSTIP:%HTTPPORT
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 Content-Length: 0
@@ -93,7 +92,6 @@ GET http://%HOSTIP:%HTTPPORT/1002.upload1 HTTP/1.1
 Authorization: Digest username="auser", realm="testrealm", nonce="1053604144", uri="/1002.upload1", response="198aa9b6acb4b0c71d02a197a5e41f54"
 Content-Range: bytes 2-4/5
 Host: %HOSTIP:%HTTPPORT
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 Content-Length: 3
@@ -105,7 +103,6 @@ Authorization: Digest username="auser", realm="testrealm", nonce="1053604144", u
 Content-Range: bytes 2-4/5
 User-Agent: curl/7.16.1
 Host: %HOSTIP:%HTTPPORT
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 Content-Length: 3

tests/data/test1034

@@ -54,7 +54,6 @@ http://invalid-utf8-
 <protocol>
 GET http://invalid-utf8-.local/page/1034 HTTP/1.1
 Host: invalid-utf8-.local
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test1035

@@ -51,7 +51,6 @@ http://too-long-IDN-name-c
 <protocol>
 GET http://too-long-IDN-name-crl-rles-la-la-la-dee-da-flooby-nooby.local/page/1035 HTTP/1.1
 Host: too-long-IDN-name-crl-rles-la-la-la-dee-da-flooby-nooby.local
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test1077

@@ -62,13 +62,11 @@ FTP over HTTP proxy with downgrade to HTTP 1.0
 <protocol>
 GET ftp://%HOSTIP:%HTTPPORT/we/want/that/page/1077 HTTP/1.1
 Host: %HOSTIP:%HTTPPORT
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 
 GET ftp://%HOSTIP:%HTTPPORT/we/want/that/page/10770002 HTTP/1.0
 Host: %HOSTIP:%HTTPPORT
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test16

@@ -44,7 +44,6 @@ HTTP with proxy authorization
 GET http://we.want.that.site.com/16 HTTP/1.1
 Proxy-Authorization: Basic ZmFrZUB1c2VyOqenp2xvb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29vb29uZw==
 Host: we.want.that.site.com
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test162

@@ -49,7 +49,6 @@ GET http://%HOSTIP:%HTTPPORT/162 HTTP/1.1
 Proxy-Authorization: NTLM TlRMTVNTUAABAAAABoIIAAAAAAAAAAAAAAAAAAAAAAA=
 User-Agent: curl/7.8.1-pre3 (sparc-sun-solaris2.7) libcurl 7.8.1-pre3 (OpenSSL 0.9.6a) (krb4 enabled)
 Host: %HOSTIP:%HTTPPORT
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test165

@@ -50,7 +50,6 @@ http://www.
 <protocol>
 GET http://www.xn--4cab6c.se/page/165 HTTP/1.1
 Host: www.xn--4cab6c.se
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test167

@@ -63,7 +63,6 @@ GET http://data.from.server.requiring.digest.hohoho.com/167 HTTP/1.1
 Proxy-Authorization: Basic Zm9vOmJhcg==
 User-Agent: curl/7.12.0-CVS (i686-pc-linux-gnu) libcurl/7.12.0-CVS OpenSSL/0.9.6b zlib/1.1.4 c-ares/1.2.0 libidn/0.4.3
 Host: data.from.server.requiring.digest.hohoho.com
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 
@@ -72,7 +71,6 @@ Proxy-Authorization: Basic Zm9vOmJhcg==
 Authorization: Digest username="digest", realm="weirdorealm", nonce="12345", uri="/167", response="13c7c02a252cbe1c46d8669898a3be26"
 User-Agent: curl/7.12.0-CVS (i686-pc-linux-gnu) libcurl/7.12.0-CVS OpenSSL/0.9.6b zlib/1.1.4 c-ares/1.2.0 libidn/0.4.3
 Host: data.from.server.requiring.digest.hohoho.com
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test168

@@ -76,7 +76,6 @@ http://data.from.server.requiring.digest.hohoho.com/168 --proxy http://%HOSTIP:%
 GET http://data.from.server.requiring.digest.hohoho.com/168 HTTP/1.1
 User-Agent: curl/7.12.0-CVS (i686-pc-linux-gnu) libcurl/7.12.0-CVS OpenSSL/0.9.6b zlib/1.1.4 c-ares/1.2.0 libidn/0.4.3
 Host: data.from.server.requiring.digest.hohoho.com
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 
@@ -84,7 +83,6 @@ GET http://data.from.server.requiring.digest.hohoho.com/168 HTTP/1.1
 Proxy-Authorization: Digest username="foo", realm="weirdorealm", nonce="12345", uri="/168", response="fb8608e00ad9239a3dedb14bc8575976"
 User-Agent: curl/7.12.0-CVS (i686-pc-linux-gnu) libcurl/7.12.0-CVS OpenSSL/0.9.6b zlib/1.1.4 c-ares/1.2.0 libidn/0.4.3
 Host: data.from.server.requiring.digest.hohoho.com
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 
@@ -93,7 +91,6 @@ Proxy-Authorization: Digest username="foo", realm="weirdorealm", nonce="12345",
 Authorization: Digest username="digest", realm="realmweirdo", nonce="123456", uri="/168", response="ca87f2d768a231e2d637a55698d5c416"
 User-Agent: curl/7.12.0-CVS (i686-pc-linux-gnu) libcurl/7.12.0-CVS OpenSSL/0.9.6b ipv6 zlib/1.1.4 GSS libidn/0.4.3
 Host: data.from.server.requiring.digest.hohoho.com
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test169

@@ -101,7 +101,6 @@ GET http://data.from.server.requiring.digest.hohoho.com/169 HTTP/1.1
 Proxy-Authorization: NTLM TlRMTVNTUAABAAAABoIIAAAAAAAAAAAAAAAAAAAAAAA=
 User-Agent: curl/7.12.0-CVS (i686-pc-linux-gnu) libcurl/7.12.0-CVS OpenSSL/0.9.6b ipv6 zlib/1.1.4 GSS libidn/0.4.3
 Host: data.from.server.requiring.digest.hohoho.com
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 
@@ -109,7 +108,6 @@ GET http://data.from.server.requiring.digest.hohoho.com/169 HTTP/1.1
 Proxy-Authorization: NTLM TlRMTVNTUAADAAAAGAAYAEAAAAAYABgAWAAAAAAAAABwAAAAAwADAHAAAAA
 User-Agent: curl/7.12.0-CVS (i686-pc-linux-gnu) libcurl/7.12.0-CVS OpenSSL/0.9.6b ipv6 zlib/1.1.4 GSS libidn/0.4.3
 Host: data.from.server.requiring.digest.hohoho.com
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 
@@ -117,7 +115,6 @@ GET http://data.from.server.requiring.digest.hohoho.com/169 HTTP/1.1
 Authorization: Digest username="digest", realm="r e a l m", nonce="abcdef", uri="/169", response="95d48591985a03c4b49cb962aa7bd3e6"
 User-Agent: curl/7.12.0-CVS (i686-pc-linux-gnu) libcurl/7.12.0-CVS OpenSSL/0.9.6b ipv6 zlib/1.1.4 GSS libidn/0.4.3
 Host: data.from.server.requiring.digest.hohoho.com
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test170

@@ -38,7 +38,6 @@ POST http://a.galaxy.far.far.away/170 HTTP/1.1
 Proxy-Authorization: NTLM TlRMTVNTUAABAAAABoIIAAAAAAAAAAAAAAAAAAAAAAA=
 User-Agent: curl/7.12.0-CVS (i686-pc-linux-gnu) libcurl/7.12.0-CVS OpenSSL/0.9.6b ipv6 zlib/1.1.4 libidn/0.4.3
 Host: a.galaxy.far.far.away
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 Content-Length: 0

tests/data/test171

@@ -43,7 +43,6 @@ HTTP, get cookie with dot prefixed full domain
 <protocol>
 GET http://z.x.com/171 HTTP/1.1
 Host: z.x.com
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test179

@@ -48,7 +48,6 @@ supertrooper.fake	FALSE	/c	FALSE	2139150993	moo2	indeed
 <protocol>
 GET http://supertrooper.fake/c/179 HTTP/1.1
 Host: supertrooper.fake
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 Cookie: moo2=indeed

tests/data/test183

@@ -41,14 +41,12 @@ http://deathstar.another.galaxy/183 http://a.galaxy.far.far.away/183 --proxy htt
 GET http://deathstar.another.galaxy/183 HTTP/1.1
 User-Agent: curl/7.12.2-CVS (i686-pc-linux-gnu) libcurl/7.12.2-CVS OpenSSL/0.9.6b zlib/1.1.4 libidn/0.4.6
 Host: deathstar.another.galaxy
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 
 GET http://a.galaxy.far.far.away/183 HTTP/1.1
 User-Agent: curl/7.12.2-CVS (i686-pc-linux-gnu) libcurl/7.12.2-CVS OpenSSL/0.9.6b zlib/1.1.4 libidn/0.4.6
 Host: a.galaxy.far.far.away
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test184

@@ -60,14 +60,12 @@ http://deathstar.another.galaxy/184 -L -H "Host: another.visitor.stay.a.while.st
 <protocol>
 GET http://deathstar.another.galaxy/184 HTTP/1.1
 User-Agent: curl/7.12.2-CVS (i686-pc-linux-gnu) libcurl/7.12.2-CVS OpenSSL/0.9.6b zlib/1.1.4 libidn/0.4.6
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 Host: another.visitor.stay.a.while.stay.foreeeeeever
 
 GET http://yet.another.host/184 HTTP/1.1
 Host: yet.another.host
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 

tests/data/test185

@@ -60,13 +60,11 @@ http://deathstar.another.galaxy/185 -L -H "Host: another.visitor.stay.a.while.st
 <protocol>
 GET http://deathstar.another.galaxy/185 HTTP/1.1
 User-Agent: curl/7.12.2-CVS (i686-pc-linux-gnu) libcurl/7.12.2-CVS OpenSSL/0.9.6b zlib/1.1.4 libidn/0.4.6
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 Host: another.visitor.stay.a.while.stay.foreeeeeever
 
 GET http://deathstar.another.galaxy/go/west/185 HTTP/1.1
-Pragma: no-cache
 Accept: */*
 Proxy-Connection: Keep-Alive
 Host: another.visitor.stay.a.while.stay.foreeeeeever