Commit 35217709 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

- Fabian Keil ran clang on the (lib)curl code, found a bunch of warnings and 

  contributed a range of patches to fix them.
parent 9d18c0b1

CHANGES

+4 −0
Original line number Diff line number Diff line
@@ -6,6 +6,10 @@ 


                                  Changelog



Daniel Stenberg (10 Jun 2009)

- Fabian Keil ran clang on the (lib)curl code, found a bunch of warnings and

  contributed a range of patches to fix them.



Yang Tse (9 Jun 2009)

- Daniel Steinberg pointed out that Curl_FormInit() in formdata.c was not

  initializing the fread callback pointer and this triggered a compiler

RELEASE-NOTES

+1 −0
Original line number Diff line number Diff line
@@ -37,5 +37,6 @@ advice from friends like these: 
 Yang Tse, Daniel Fandrich, Kamil Dudka, Caolan McNamara, Frank McGeough,

 Andre Guibert de Bruet, Mike Crowe, Claes Jakobsson, John E. Malmberg,

 Aaron Oneal, Igor Novoseltsev, Eric Wong, Bill Hoffman, Daniel Steinberg,

 Fabian Keil



        Thanks! (and sorry if I forgot to mention someone)

lib/cookie.c

+1 −1
Original line number Diff line number Diff line
@@ -405,7 +405,7 @@ Curl_cookie_add(struct SessionHandle *data, 
      }



      ptr=semiptr+1;

      while(ptr && *ptr && ISBLANK(*ptr))

      while(*ptr && ISBLANK(*ptr))

        ptr++;

      semiptr=strchr(ptr, ';'); /* now, find the next semicolon */

lib/dict.c

+2 −2
Original line number Diff line number Diff line
@@ -182,7 +182,7 @@ static CURLcode dict_do(struct connectdata *conn, bool *done) 
          *strategy++ = (char)0;

          nthdef = strchr(strategy, ':');

          if(nthdef) {

            *nthdef++ = (char)0;

            *nthdef = (char)0;

          }

        }

      }
@@ -238,7 +238,7 @@ static CURLcode dict_do(struct connectdata *conn, bool *done) 
        *database++ = (char)0;

        nthdef = strchr(database, ':');

        if(nthdef) {

          *nthdef++ = (char)0;

          *nthdef = (char)0;

        }

      }

    }

lib/http.c

+2 −3
Original line number Diff line number Diff line
@@ -1419,8 +1419,7 @@ CURLcode Curl_proxyCONNECT(struct connectdata *conn, 
      Curl_tvdiff(Curl_tvnow(), conn->now); /* spent time */

    if(check <= 0) {

      failf(data, "Proxy CONNECT aborted due to timeout");

      error = SELECT_TIMEOUT; /* already too little time */

      break;

      return CURLE_RECV_ERROR;

    }



    /* if we're in multi-mode and we would block, return instead for a retry */