Commit 33a0a926 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

cookie: remove redundant check 

... as it was already checked previously within the function.

Reported-by: Dmitry-Me
Closes #695
parent 3c2ef2a6

lib/cookie.c

+15 −18
Original line number Original line Diff line number Diff line
@@ -1277,6 +1277,7 @@ static int cookie_output(struct CookieInfo *c, const char *dumphere) 
  struct Cookie *co;

  struct Cookie *co;

  FILE *out;

  FILE *out;

  bool use_stdout=FALSE;

  bool use_stdout=FALSE;

  char *format_ptr;





  if((NULL == c) || (0 == c->numcookies))

  if((NULL == c) || (0 == c->numcookies))

    /* If there are no known cookies, we don't write or even create any

    /* If there are no known cookies, we don't write or even create any
@@ -1297,9 +1298,6 @@ static int cookie_output(struct CookieInfo *c, const char *dumphere) 
      return 1; /* failure */

      return 1; /* failure */

  }

  }





  if(c) {

    char *format_ptr;



  fputs("# Netscape HTTP Cookie File\n"

  fputs("# Netscape HTTP Cookie File\n"

        "# https://curl.haxx.se/docs/http-cookies.html\n"

        "# https://curl.haxx.se/docs/http-cookies.html\n"

        "# This file was generated by libcurl! Edit at your own risk.\n\n",

        "# This file was generated by libcurl! Edit at your own risk.\n\n",
@@ -1318,7 +1316,6 @@ static int cookie_output(struct CookieInfo *c, const char *dumphere) 
    fprintf(out, "%s\n", format_ptr);

    fprintf(out, "%s\n", format_ptr);

    free(format_ptr);

    free(format_ptr);

  }

  }

  }





  if(!use_stdout)

  if(!use_stdout)

    fclose(out);

    fclose(out);