Commits · e903ef6e20fb9bc80408dec3793cde95c5ba81b6 · CYBER - Cyber Security / TS 103 523 MSP / TLMSP / TLMSP Apache Httpd

Oct 16, 2001

Cautiously avoiding the scoping issue that was discussed on the list, · e903ef6e

Aaron Bannert authored Oct 16, 2001

I thought these other changes needed to go in; Namely that we don't
need to check if the brigade is empty twice in the loop, just once.
Added a comment for good measure.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91478 13f79535-47bb-0310-9956-ffa450edef68

e903ef6e

Oct 15, 2001

disabling mod_example ap_hook_{http_method,default_port} · f1e23e59

Doug MacEachern authored Oct 15, 2001

breaks things such as httpd-test when http_method is "foo"
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91475 13f79535-47bb-0310-9956-ffa450edef68

f1e23e59

Removed outdated apache.exports references · ba61ee62

Victor J. Orlikowski authored Oct 15, 2001

Submitted by: Aaron Bannert <aaron@clove.org>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91472 13f79535-47bb-0310-9956-ffa450edef68

ba61ee62

Fix a typo in the configure script. This get AIX building cleanly. · 716d1d8e

Ryan Bloom authored Oct 15, 2001

Submitted by: Jens-Uwe Mager <jum@helios.de>
Reviewed by: Aaron Bannert <aaron@clove.org> and Ryan Bloom

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91471 13f79535-47bb-0310-9956-ffa450edef68

716d1d8e

insure that a '*' in <VirtualHost *> or NameVirtualHost * matches all ports. · 9993247d

Greg Ames authored Oct 15, 2001

The recent change to eliminate the Port directive exposed this problem.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91470 13f79535-47bb-0310-9956-ffa450edef68

9993247d

· 1fc9761c

William A. Rowe Jr authored Oct 15, 2001

My badness (well, I tried)

Mladen Turk's <mturk@mappingsoft.com> corrections for recent cleanups

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91469 13f79535-47bb-0310-9956-ffa450edef68

1fc9761c

· 02143449

William A. Rowe Jr authored Oct 15, 2001

  rotatelogs will be apr-ized at some point, make this simple.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91467 13f79535-47bb-0310-9956-ffa450edef68

02143449

· 9245c97d

William A. Rowe Jr authored Oct 15, 2001

  Forgot the directive's note change for "Any"


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91466 13f79535-47bb-0310-9956-ffa450edef68

9245c97d

· d141fdfa

William A. Rowe Jr authored Oct 15, 2001

  That's Any, not All


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91465 13f79535-47bb-0310-9956-ffa450edef68

d141fdfa

· eaf6993d

William A. Rowe Jr authored Oct 15, 2001

Clarify the new MultiviewsMatch directive. I wanted this down on 'paper',
even if it isn't proofread - please feel free to touch up.

BTW - the new 'cleaned' formatting really stinks for hand-editing,
the indentation really needs works. Our per-directive meta-info is
the ugliest aspect. Would be good if the cleanup code could be customized
to make the html not only clean, but legible ;)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91464 13f79535-47bb-0310-9956-ffa450edef68

eaf6993d

Oct 14, 2001

Fix the first bucket not getting chunked properly. The reason was that · b9785968

Justin Erenkrantz authored Oct 14, 2001

we left the TE header in the output headers, so ap_set_keepalive didn't
set r->chunked to 1.  So, ap_http_header_filter wouldn't insert CHUNK
filter appropriately.  I have no clue how it chunked anything at all
before this patch, but hey, it looks right now.

Tested with Yahoo, Apple, apache.org, and /.
/. is interesting in that it sends both Conn: Close and TE: chunked.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91463 13f79535-47bb-0310-9956-ffa450edef68

b9785968

Ensure that ap_http_filter can not be coersced into reading more than we · e1e2c633

Justin Erenkrantz authored Oct 14, 2001

think is currently available.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91462 13f79535-47bb-0310-9956-ffa450edef68

e1e2c633

Fix broken links · 11bbbb4c

Martin Kraemer authored Oct 14, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91461 13f79535-47bb-0310-9956-ffa450edef68

11bbbb4c

Oct 13, 2001
- htmltidy made a little mess of the <pre> environment. · b4416768
  Joshua Slive authored Oct 13, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91457 13f79535-47bb-0310-9956-ffa450edef68
```
  b4416768
- x_handler() was not checking r->handler, leaving it to handle every request · 75dcc28b
  Doug MacEachern authored Oct 13, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91454 13f79535-47bb-0310-9956-ffa450edef68
```
  75dcc28b
Oct 12, 2001

Remove unused hard-coded definition of a SHELL_PATH. · b9db42c5

Cliff Woolley authored Oct 12, 2001

Submitted by:	Hiten Pandya <hpandya@lycos.co.uk>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91453 13f79535-47bb-0310-9956-ffa450edef68

b9db42c5

Make sure we install apxs. · e25a8345

Ryan Bloom authored Oct 12, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91449 13f79535-47bb-0310-9956-ffa450edef68

e25a8345

Well, now I know what the bio_is_renegotiating call was for. · 1cbf4beb

Justin Erenkrantz authored Oct 12, 2001

Place a big-ass comment there so that whomever comes next isn't stuck
at a cryptic call that they don't understand with a dinky comment.
Hopefully, this makes sense.  Someone more familiar with OpenSSL should
verify the comment.

This fix also requires the normalize call to be performed before
churn_input so that we don't enter churn_input with a 0-length ctx->b
brigade.

All httpd-test tests (except for the module/negotiation test) pass now.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91442 13f79535-47bb-0310-9956-ffa450edef68

1cbf4beb

If we passed the bucket to ap_pass_brigade (because it was EOS or FLUSH), · b82abcc0

Justin Erenkrantz authored Oct 12, 2001

we shouldn't delete it.

Thanks to Doug for pointing out that something broke.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91441 13f79535-47bb-0310-9956-ffa450edef68

b82abcc0

Lose the magic number and use the central #define AP_IOBUFSIZE. · 86346aae

Justin Erenkrantz authored Oct 12, 2001

Hey, I've never seen it in actual use anywhere, so I didn't know.

Thanks to Roy for pointing it out.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91440 13f79535-47bb-0310-9956-ffa450edef68

86346aae

Oct 11, 2001

Another one bites the dust. · 55711c09

Justin Erenkrantz authored Oct 11, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91437 13f79535-47bb-0310-9956-ffa450edef68

55711c09

Teach mod_proxy to live with the new filtering scheme. · 6ce89a09

Justin Erenkrantz authored Oct 11, 2001

Tested with www.yahoo.com (Conn: Close), www.apache.org (CL), and
www.apple.com (TE: Chunked).

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91436 13f79535-47bb-0310-9956-ffa450edef68

6ce89a09

fix a *printf() format · a577f946

Jeff Trawick authored Oct 11, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91435 13f79535-47bb-0310-9956-ffa450edef68

a577f946

Remove deprecated ap_dechunk_filter from header. · d2b3b007

Justin Erenkrantz authored Oct 11, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91434 13f79535-47bb-0310-9956-ffa450edef68

d2b3b007

fix another seg fault. · 7dc4e424

Greg Ames authored Oct 11, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91431 13f79535-47bb-0310-9956-ffa450edef68

7dc4e424

Eventually I'll get this right. · 7a7ec7a3

Joshua Slive authored Oct 11, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91430 13f79535-47bb-0310-9956-ffa450edef68

7a7ec7a3

Squeeze the example down to fit on one line. · a2ce021d

Joshua Slive authored Oct 11, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91425 13f79535-47bb-0310-9956-ffa450edef68

a2ce021d

· 159058ec

William A. Rowe Jr authored Oct 11, 2001

Aye, it's bogus. Something very odd about short terniary results on
this C[++] compiler here, wants to promote to the conditition's type :-/

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91424 13f79535-47bb-0310-9956-ffa450edef68

159058ec

· 2f3cb2b5

William A. Rowe Jr authored Oct 11, 2001

  Outch... fixed warning


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91423 13f79535-47bb-0310-9956-ffa450edef68

2f3cb2b5

Convert to html. · c0dfdfac

Joshua Slive authored Oct 11, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91422 13f79535-47bb-0310-9956-ffa450edef68

c0dfdfac

TransferLog is (sort of) deprecated, and people never seem to realize · 742934fe

Joshua Slive authored Oct 11, 2001

that you can use this with CustomLog.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91421 13f79535-47bb-0310-9956-ffa450edef68

742934fe

· 0592d4e7

William A. Rowe Jr authored Oct 11, 2001

Ok, this formats a whole lot cleaner, and (I believe) makes a bit more
sense. Also provides a rundown of C89 common date format strings, for
those users who don't have man strftime [It still points out that add'l
format options may b available, see strftime.]

Also, I believe _most_ installations require the TransferLog "|bin/
path to rotatelogs, no? Other question - how to reformat to html?
Which utility does so?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91420 13f79535-47bb-0310-9956-ffa450edef68

0592d4e7

· 5417be45

William A. Rowe Jr authored Oct 11, 2001

Close the mod_mime file extension matching issue by (as Ken Coar suggests)
allowing users to continue to rely on the old 1.3 behavior of matching Any
extensions, the strict behavior of matching NegotiatedOnly arguments, or
including Handlers and Filters with the MultiviewsMatch directive for
mod_negotiation control. Unfortunately, the component matching occurs
in mod_mime, so that's where this option must reside.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91419 13f79535-47bb-0310-9956-ffa450edef68

5417be45

Fix a typo in the configure script. The argument is --enable-mods-shared, · ec8ba30f

Ryan Bloom authored Oct 11, 2001

but we documented it as --enable-mod-shared.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91418 13f79535-47bb-0310-9956-ffa450edef68

ec8ba30f

Remove some warnings from the code. The buckets take a different · 5691be45

Ryan Bloom authored Oct 11, 2001

type for the length than the brigade functions do. This moves the
len_read variable into the correct scope for the two times that it
is used, and defines it correctly for each scope.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91417 13f79535-47bb-0310-9956-ffa450edef68

5691be45

Fixed the configure script to add a LoadModule directive to · 3f41d52d

Ryan Bloom authored Oct 11, 2001

the default httpd.conf for any module that was compiled
as a DSO.

Submitted by:	Aaron Bannert <aaron@clove.org>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91415 13f79535-47bb-0310-9956-ffa450edef68

3f41d52d

This is the mod_ssl input filtering rewrite. Lots of stuff here. I also · 3fdafd25

Justin Erenkrantz authored Oct 11, 2001

changed some of the style issues within the filtering code to conform to
the rest of the server.

Various incarnations of this patch have been posted to dev@httpd without
feedback.  Now that it passes all of the httpd-test cases (with the
exception of module/negotiation test which fails without mod_ssl anyway),
it is time to check it in.

Please review and test.  We are under C-T-R rules, so I'm going to take
advantage of that and commit it now.  I have tested this about as much
as I can and it seems to work from everything I can give to it.
Considering that mod_ssl was broken before this commit, this is an
improvement.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91414 13f79535-47bb-0310-9956-ffa450edef68

3fdafd25

We can't pass in &r->remaining because we change that value on output to · d6990f80

Justin Erenkrantz authored Oct 11, 2001

be how many bytes we read.  This trounces on the r->remaining value, so
we must use a local variable and subtract that from r->remaining after we
read.
Reviewed by:	Aaron Bannert


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91413 13f79535-47bb-0310-9956-ffa450edef68

d6990f80

The problem here is that we are getting some zero-length buckets at the head · 0f74698b

Justin Erenkrantz authored Oct 11, 2001

of our brigade - which are in isolation okay. In this situation, they
must be removed by the call to APR_BRIGADE_NORMALIZE.

The way we partition the buckets means that we will never remove the
zero-length bucket from the head - causing an infinite loop. We read only
a single bucket now - previously partition with the blocking reads would
read multiple buckets - but it forced having a defined length which we
agreed was bogus.

Therefore, if we have a zero-length bucket at the head, we would then try
to partition and split at the zero-point of the brigade. That combination
doesn't actually remove the zero-length bucket - it is still there - causing
an infinite loop because we'll never go past the zero-length bucket.

This call was originally present in core_input_filter. I think it might
be better to fix partition/split/etc to eliminate a zero-length bucket
and skip it. But, I'm not 100% sure that needs to happen.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91412 13f79535-47bb-0310-9956-ffa450edef68

0f74698b

Oct 10, 2001
- We also need to increment *readbytes when we find a match in the middle of · 8b139e3d
  Justin Erenkrantz authored Oct 10, 2001
```
a bucket.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@91411 13f79535-47bb-0310-9956-ffa450edef68
```
  8b139e3d