so that only one stat() is needed.

If we get APR_FINFO_MIN bits, lookup_dirent won't do a repeated stat()
call.  So, let's do it here.  Also, if we see a symlink, expand it.
(Technically, we don't *have* to expand the symlinks - the resolve_symlink
fix handles that, but we can't really assume that.)  Since we know that
dirent will be rr->finfo anyway, go back to relying on dirent only for
APR_DIR checks.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93329 13f79535-47bb-0310-9956-ffa450edef68

We would previously receive APR_INCOMPLETE on symlinks if wanted has
FINFO_NAME set because it isn't supported via apr_stat().  Furthermore, we
don't care what the real name is anyway (even if it apr_stat returned
.name) - we want to call it by the name the symlink says it is.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93328 13f79535-47bb-0310-9956-ffa450edef68

  Eliminate tons o cruft - we are in another thread - and these can all
  be longlived malloced regions, or sit upon the stack.  No need to mess
  with pool conflicts.

  The remaining pool accesses are still a problem to resolve.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93327 13f79535-47bb-0310-9956-ffa450edef68

  Upon advice of the FirstBill, I began looking for exceptions that occur
  only in the service-mode.  SetServiceDescription was borked, now fixed.
  Since we don't use the posix/libc style stderr, I've also pitched that
  code, which was causing an exception.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93326 13f79535-47bb-0310-9956-ffa450edef68

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93324 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93323 13f79535-47bb-0310-9956-ffa450edef68

lots of changes were being made to worker to fix bugs, and it seemed
premature.  Haven't seen much of that as of late.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93322 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93321 13f79535-47bb-0310-9956-ffa450edef68

  AP_DEBUG_ASSERT fix isn't helpful.
- The vote for perchild being required for GA is unanimous against.  No
  matter what interpretation you take, it isn't going to be a showstopper.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93320 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93319 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93318 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93317 13f79535-47bb-0310-9956-ffa450edef68

a little.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93316 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93315 13f79535-47bb-0310-9956-ffa450edef68

be called.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93314 13f79535-47bb-0310-9956-ffa450edef68

  If we only need to toggle the event, don't ask for the whole ball 'o wax.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93313 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93312 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93311 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93310 13f79535-47bb-0310-9956-ffa450edef68

	Separate showstoppers into next-beta and final-release sections.
	Change a couple of my votes.  Some minor formatting changes
	(it's not code, so just deal with it ;-).


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93309 13f79535-47bb-0310-9956-ffa450edef68

  Occifer Will from the Redundacy Dept of Redundancy reporting for duty...
  Cleaning up a few more variables and fix a logged err status.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93308 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93307 13f79535-47bb-0310-9956-ffa450edef68

  Move around a bit of code so I can follow it better.  -> EOF should always
  take us to the module struct, and working backwards, the register hooks
  and then top-level init stuff.  At least that's how any other Apache
  module is authored.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93306 13f79535-47bb-0310-9956-ffa450edef68

I'm no perl expert, so additional reviewing eyes may be needed.

PR: 9686
Submitted by:	rodrigo campos <camposr@uol.com.br>, Patrik Grip-Jansson <patrikj@gnulix.org>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93305 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93302 13f79535-47bb-0310-9956-ffa450edef68

(only conflict from HEAD is in core.c where rbb/FirstBill snuck in some
hook changes...)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93301 13f79535-47bb-0310-9956-ffa450edef68

  Give the child GENERIC_WRITE only to the stderr log channel,
  GENERIC_READ|GENERIC_WRITE to the scoreboard mapping,
  EVENT_MODIFY_STATE|SYNCHRONIZE to it's exit event,
  and fix a _major_ bug in the NullACL code that set the length
  by the size of the pointer-to-acl, rather than the size of an acl.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93300 13f79535-47bb-0310-9956-ffa450edef68

Consensus has overruled the hook ordering showstopper and is now demoted
accordingly.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93298 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93297 13f79535-47bb-0310-9956-ffa450edef68

specified they want to use the CanonicalName, but they have not
configured a port with the ServerName, then use the same port that
the original request used.

Submitted by:   Ryan Bloom and Ken Coar


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93296 13f79535-47bb-0310-9956-ffa450edef68

that.  Yuck.  Make these error message DEBUG level then.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93295 13f79535-47bb-0310-9956-ffa450edef68

returned something like APR_EOF, since len is not set in this
case and we can go off the end of storage

make sure we set r->status to something when we bail out due
to an error; otherwise, the request goes forward with meaningless
headers


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93294 13f79535-47bb-0310-9956-ffa450edef68

  since APR_BRIGADE_EMPTY() assumes a non-empty brigade, we have to check
  before invoking that macro

  since APR_BRIGADE_EMPTY() can make a brigade empty, we have to check
  after invoking that macro

An obvious variation of this fix would be to change APR_BRIGADE_NORMALIZE()
to deal with empty brigades.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93293 13f79535-47bb-0310-9956-ffa450edef68

but it seems more general.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93291 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93283 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93282 13f79535-47bb-0310-9956-ffa450edef68

  A cleanup from the redundancy dept. of redundancy


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93281 13f79535-47bb-0310-9956-ffa450edef68

  Leaky as a sieve.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93280 13f79535-47bb-0310-9956-ffa450edef68

  Didn't mean to leave that in there.  MPM works, how well I haven't yet
  determined.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93279 13f79535-47bb-0310-9956-ffa450edef68

  Clean up more bogosity and leaky pipes [and fix a recent bug].

  1. The only good assert is a deleted assert.

  2. The child exit event is a very private item, can't pollute into
     other processes we create, shouldn't be named, and should never
     be accessable to anyone but the parent.

  3. We now pass 'handles', not just a single scoreboard.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93278 13f79535-47bb-0310-9956-ffa450edef68