Commits · be6cc2c5a0f5fd59176d63ac1392be1de652fd0a · CYBER - Cyber Security / TS 103 523 MSP / TLMSP / TLMSP Apache Httpd

Jan 27, 2001

· be6cc2c5

William A. Rowe Jr authored Jan 27, 2001

  Sunny and warm (if 30`F meets your definition of warm :-)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87871 13f79535-47bb-0310-9956-ffa450edef68

be6cc2c5

Fix a seg fault. The problem is easy to explain. On a HEAD request, Good · cab9a191

Ryan Bloom authored Jan 27, 2001

handlers will send their data down the filter stack, but 1.3 handlers will
just return, giving us a Content-Length of 0. Since we can't send a C-L
of 0 just because it is a HEAD request, we search the headers_out table
for a 0 C-L if it is a HEAD request. The problem is that some filters
will not allow (includes_filter) a C-L to be computed, so we end up without
a C-L header in headers_out. Thus, when we do a strcmp against the header
value and "0", we seg fault, because the header value is NULL.

To fix this, we grab the element from the header table, and make sure it
isn't NULL before doing the strcmp.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87870 13f79535-47bb-0310-9956-ffa450edef68

cab9a191

Forgot this header file when I cleaned the error_bucket code. · ad3749bf
Ryan Bloom authored Jan 27, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87869 13f79535-47bb-0310-9956-ffa450edef68
```
ad3749bf

Add support for type-safe optional functions. · 3658b767

Ben Laurie authored Jan 27, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87868 13f79535-47bb-0310-9956-ffa450edef68

3658b767

Cleanup the error bucket code a bit. This uses the error bucket directly · 80b6c944

Ryan Bloom authored Jan 27, 2001

instead of using ap_bucket_read.  It also lets ap_die handle the fact that
the filter returned the error.
Submitted by:	Greg Stein


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87867 13f79535-47bb-0310-9956-ffa450edef68

80b6c944

Reapply patch for chartables.c, only this time in both places (not having it · 022cf1b1

Ben Laurie authored Jan 27, 2001

breaks FreeBSD 3.2).


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87866 13f79535-47bb-0310-9956-ffa450edef68

022cf1b1

Greg Stein and Dale Ghent both reminded me I forgot to add this. · 2670e689
Ryan Bloom authored Jan 27, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87865 13f79535-47bb-0310-9956-ffa450edef68
```
2670e689

· bd0fdead

William A. Rowe Jr authored Jan 27, 2001

Was there a file that wasn't updated with the error buckets patch?
Here's the export symbol for http_protocol's error bucket type, but
I can't find the actual instance (which needs AP_DECLARE_DATA as well.)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87864 13f79535-47bb-0310-9956-ffa450edef68

bd0fdead

filters can now report an HTTP error to the server. This is done · 28e92fac

Ryan Bloom authored Jan 27, 2001

by sending a brigade where the first bucket is an error_bucket.
This bucket is a simple bucket that stores an HTTP error and
a string. Currently the string is not used, but it may be needed
to output an error log. The http_header_filter will find this
bucket, and output the error text, and then return
AP_FILTER_ERROR, which informs the server that the error web page
has already been sent.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87863 13f79535-47bb-0310-9956-ffa450edef68

28e92fac

· d19e995e

William A. Rowe Jr authored Jan 27, 2001

  Much better for win32 checkouts


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87862 13f79535-47bb-0310-9956-ffa450edef68

d19e995e

· 7e23f2a9

William A. Rowe Jr authored Jan 27, 2001

Discovered these were horribly broken as 'text' files...
Coming back tagged binary.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87861 13f79535-47bb-0310-9956-ffa450edef68

7e23f2a9

Jan 26, 2001

· f6ae4e1b

Greg Ames authored Jan 26, 2001

fix mangled headers due to underallocated buffer


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87856 13f79535-47bb-0310-9956-ffa450edef68

f6ae4e1b

Teach me to change just one more thing before committing. This fixes my · 0d2582c4

Ryan Bloom authored Jan 26, 2001

last commit.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87855 13f79535-47bb-0310-9956-ffa450edef68

0d2582c4

Stop using the request filters to filter an error response. This fixes a · 8cd3a68b

Ryan Bloom authored Jan 26, 2001

bug where we were using the byterange filter to filter an error, which
caused us to close the connection before we had sent any data. Currently,
we only keep the three most important filters, but we may need to add more
in the future. I am mostly thinking of the charset translation filter.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87854 13f79535-47bb-0310-9956-ffa450edef68

8cd3a68b

Provide a way to allow get_resource and get_parent_resource to return errors · 60131d5f

Greg Stein authored Jan 26, 2001

that might occur during the parsing of the URI and/or the lookup of the
resource in the repository.

Specifically: return a dav_error* and move the returned dav_resource* to an
"out" parameter of the hook function.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87852 13f79535-47bb-0310-9956-ffa450edef68

60131d5f

apr_put_os_file() expected the caller to have an existing file or init to · aea0cfec

Greg Stein authored Jan 26, 2001

NULL. using an existing file doesn't normally work: where would you get a
blank file to shove an FD into? expecting the user to assign to NULL is
error-prone (mod_isapi didn't).

*) always create and return a new file from apr_put_os_file()
*) reimplement apr_open_stderr() in terms of apr_put_os_file()
   [ except for win32... some issues there ]
*) remove some (obsolete) inits to NULL


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87851 13f79535-47bb-0310-9956-ffa450edef68

aea0cfec

Fix uninitialized variable 'written' in ap_rvputs, noticed by gcc. · 8d7abd28
Brian Havard authored Jan 26, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87849 13f79535-47bb-0310-9956-ffa450edef68
```
8d7abd28

my mom said not to talk to strangers. whoever is reading this is probably a · 0b8ae924

Greg Stein authored Jan 26, 2001

stranger. I'm not going to talk to you about what I did. nyeah.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87848 13f79535-47bb-0310-9956-ffa450edef68

0b8ae924

we only need to worry about infinite-depth PROPFINDs if they are targeting a · fb226cdb

Greg Stein authored Jan 26, 2001

collection. allow them on plain resources.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87847 13f79535-47bb-0310-9956-ffa450edef68

fb226cdb

Jan 25, 2001

Store the original content_type before we replace it with the byterange · 7f2970ff

Ryan Bloom authored Jan 25, 2001

C-T.  This allows us to report a correct content type in the boundary
header.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87845 13f79535-47bb-0310-9956-ffa450edef68

7f2970ff

· 08a654ed

Greg Ames authored Jan 25, 2001

get mod_unique_id building again...XtOffset was undefined


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87843 13f79535-47bb-0310-9956-ffa450edef68

08a654ed

clarify the comments about FollowSymLinks (and .htaccess) · c44e914a

Greg Stein authored Jan 25, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87840 13f79535-47bb-0310-9956-ffa450edef68

c44e914a

Updates to upgrading/new_features for some recent changes. I would · e7b935d0

Joshua Slive authored Jan 25, 2001

guess that there are still tons of things missing from these files.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87839 13f79535-47bb-0310-9956-ffa450edef68

e7b935d0

Add fragment target · f2ee627e

Martin Kraemer authored Jan 25, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87833 13f79535-47bb-0310-9956-ffa450edef68

f2ee627e

· 8582668e

Greg Ames authored Jan 25, 2001

the issue is resolved.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87831 13f79535-47bb-0310-9956-ffa450edef68

8582668e

· e31e7f30

Greg Ames authored Jan 25, 2001

removed docs/conf/highperformance.conf (re-named to highperformance-std.conf)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87830 13f79535-47bb-0310-9956-ffa450edef68

e31e7f30

· 7b90e9f0

Greg Ames authored Jan 25, 2001

add highperformance-std.conf . The -std name allows make install to work
its magic.

Slightly changed from highperformance.conf : I added "User" and "Group" so
it works right out of the box on Linux.  Group will no doubt need editing on
other platforms.

I'll remove docs/conf/highperformance.conf from CVS once I find out the
right way to do it.  (Hints appreciated)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87829 13f79535-47bb-0310-9956-ffa450edef68

7b90e9f0

close the post file after reading it · 0f3aa41c

Jeff Trawick authored Jan 25, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87827 13f79535-47bb-0310-9956-ffa450edef68

0f3aa41c

Add the coalesce filter back in. It is NOT being installed anywhere right now. · 136a5029
Bill Stoddard authored Jan 25, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87825 13f79535-47bb-0310-9956-ffa450edef68
```
136a5029

Jan 24, 2001

As Greg noted, set_keepalive has to happen before we check r->chunked, but · 0bb70dc4

Ryan Bloom authored Jan 24, 2001

it also has to happen after ap_basic_http_header. Otherwise, we don't
set r->connection->keepalive correctly, and it can be -1 for requests that
don't support keepalive. This moves ap_basic_http_header to above the
call to set_keepalive (after reversing the previous patch), which should
be perfectly safe, while still fixing the original bug.
Submitted by: Greg Stein

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87824 13f79535-47bb-0310-9956-ffa450edef68

0bb70dc4

The ap_set_keepalive call needs to be after the call to · 01645c70

Ryan Bloom authored Jan 24, 2001

ap_basic_http_header. Without this, there are times that HTTP 1.0
requests will do keepalive connections.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87823 13f79535-47bb-0310-9956-ffa450edef68

01645c70

The current hooking module is _not_ a debugging aid. · f2274ccc

Ben Laurie authored Jan 24, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87822 13f79535-47bb-0310-9956-ffa450edef68

f2274ccc

Remove the COALESCE_FILTER. It is no longer needed since Greg committed his ap_r* · 2971d56b
Bill Stoddard authored Jan 24, 2001
```
buffering patch.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87821 13f79535-47bb-0310-9956-ffa450edef68
```
2971d56b

Fix typo in module identifier. · 3ba168f4

Joshua Slive authored Jan 24, 2001

PR: 7117
Submitted by:	Brent Kearney


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87819 13f79535-47bb-0310-9956-ffa450edef68

3ba168f4

Attributes should be quoted. · 5d1c4494

Joshua Slive authored Jan 24, 2001

PR: 7122
Submitted by:   Kohei Watanabe


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87818 13f79535-47bb-0310-9956-ffa450edef68

5d1c4494

get http_core to compile on systems without apr_sendfile() support · 878d5aea
Jeff Trawick authored Jan 24, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87815 13f79535-47bb-0310-9956-ffa450edef68
```
878d5aea

- change the prototype for apr_dbm_geterror() [and update dav/fs/dbm.c] · d085d2d2

Greg Stein authored Jan 24, 2001

- fix up some error handling in apr_dbm.c
- use "dbm" consistently for the apr_dbm_t parameter


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87814 13f79535-47bb-0310-9956-ffa450edef68

d085d2d2

Add apr_dbm_get_usednames() so that apr_dbm users can figure out what · e49e41c6

Greg Stein authored Jan 24, 2001

filenames are actually used by the apr_dbm implementation for a given
pathname.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87813 13f79535-47bb-0310-9956-ffa450edef68

e49e41c6

Use a typesafe function for access objects' pools. · 45c92261

Greg Stein authored Jan 24, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87812 13f79535-47bb-0310-9956-ffa450edef68

45c92261

A single outermost loop is all that is needed. Simplify and add comments · 1f1392f4

Greg Stein authored Jan 24, 2001

about what is going on in there. Shift some declarations to scope their
usage and (re)initialize them on each pass over the brigade.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@87811 13f79535-47bb-0310-9956-ffa450edef68

1f1392f4