Skip to content
GitLab
  1. 07 Dec, 1997 2 commits
    • Ben Laurie's avatar
      Cure filehandle leak in Win32 CGI. · b5e436db
      Ben Laurie authored 
      PR: 1523
Submitted by:	Peter Tillemans <pti@net4all.be>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79674 13f79535-47bb-0310-9956-ffa450edef68
      b5e436db
    • pcs's avatar
      The current aplog_error() function cannot report on errors returned by · 91eb1fde
      pcs authored 
      Win32 functions. These functions do not bother setting errno - instead,
you have to make a call to GetLastError() to get the error code, then call
FormatMessage() to get the corresponding string. I already added code to
do this in os/win32/service.c, but this was specific to reporting errors
to standard error during apache -i or -u calls.

The patch below updates aplog_error() to enable generic logging of
Win32 errors to the same place as other errors. It adds a new flag,
APLOG_WIN32ERROR which if given in the _second_ argument to aplog_error()
causes the Win32 error code and error string to be logged. Here is an
example call (this is from worker_main()):

        if (SetEvent(ev[i]) == 0)
            aplog_error(APLOG_MARK,APLOG_WIN32ERROR, server_conf,
                "SetEvent for child process in slot #%d", i);

Reviewed by:	Ben Laurie, Martin Kraemer


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79673 13f79535-47bb-0310-9956-ffa450edef68
      91eb1fde
  3. 04 Dec, 1997 2 commits
  5. 02 Dec, 1997 1 commit
  7. 01 Dec, 1997 3 commits
  9. 30 Nov, 1997 2 commits
  11. 29 Nov, 1997 2 commits
  13. 27 Nov, 1997 5 commits
  15. 26 Nov, 1997 1 commit
  17. 25 Nov, 1997 7 commits
  19. 23 Nov, 1997 1 commit
  21. 22 Nov, 1997 3 commits
  23. 21 Nov, 1997 3 commits
  25. 20 Nov, 1997 6 commits
  27. 19 Nov, 1997 1 commit
  29. 17 Nov, 1997 1 commit