Commits · b5ab4dc72289d79347fd95c0962600d2a80c5667 · CYBER - Cyber Security / TS 103 523 MSP / TLMSP / TLMSP Apache Httpd

Aug 13, 2001

Close a major resource leak. Everytime we had issued a · b5ab4dc7

Ryan Bloom authored Aug 13, 2001

graceful restart, we leaked a socket descriptor.

The listening sockets should not be set inheritable, at least
not at this point.  We only want some of the httpd children to
inherit the socket.  Namely, those that will be actually serving
requests.  Any other child process (piped logs), should not be
inheriting the sockets.

PR:	7891


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90131 13f79535-47bb-0310-9956-ffa450edef68

b5ab4dc7

Remove a warning from mod_echo. · ff513c64

Ryan Bloom authored Aug 13, 2001

Submitted by:	Ian Holsman <ianh@cnet.com>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90128 13f79535-47bb-0310-9956-ffa450edef68

ff513c64

Aug 12, 2001

Make the body read in proxy http handler nonblocking. There's no sense · 672c7f8e

Chuck Murcko authored Aug 12, 2001

in serializing 4-8 client connections into a single origin server
connection, as is the blocking behavior.

Added instrumentation that we don't want compiled in normally to assist in
debugging chunking problems. apr_get_brigade is apparently blocking during
chunked body fetch, or proxy_http_handler is getting deadlocked with
the dechunk filter. Show PID for prefork debugging. We'll figure out
getting TIDs later.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90127 13f79535-47bb-0310-9956-ffa450edef68

672c7f8e

Change the MaxSpareThreads to 150 for threaded MPM. This mirrors the new · c1e30aad

Justin Erenkrantz authored Aug 12, 2001

prefork setting and removes the default case where we would spawn three
children, but kill two of them immediately because MaxSpareThreads was
set to 10 (only one children can be supported with the old value).

Please note that I don't have email access as eBuilt's servers are AWOL
this weekend (none of us have the desire to go in a fix the servers for
semi-obvious reasons). I'm trying to keep up on posts via apachelabs.org.
So, if you want to change this, just go ahead and commit the changes...

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90118 13f79535-47bb-0310-9956-ffa450edef68

c1e30aad

Put the MaxClients setting for prefork back to its 1.3 level. · e127e5cd
Joshua Slive authored Aug 12, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90116 13f79535-47bb-0310-9956-ffa450edef68
```
e127e5cd

Aug 11, 2001

Fix the macro expansion problem in the hook declaration. · 7b7f1d98

Ryan Bloom authored Aug 11, 2001

Submitted by:	Ian Holsman <ianh@cnet.com>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90098 13f79535-47bb-0310-9956-ffa450edef68

7b7f1d98

Fix the proxy when the origin server sends back a 100 · a2e4cdef

Ryan Bloom authored Aug 11, 2001

Continue response.  [John Barbee <barbee@veribox.net>]


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90092 13f79535-47bb-0310-9956-ffa450edef68

a2e4cdef

Forgot the CHANGES comment with my last commit. · 9b8932f9

Ryan Bloom authored Aug 11, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90091 13f79535-47bb-0310-9956-ffa450edef68

9b8932f9

Fix the new method code. We need to cast 1 to an apr_int64_t or it will · 836811b7

Ryan Bloom authored Aug 11, 2001

be treated as a 32-bit integer, and it will wrap after being shifted
32 times.
Submitted by:	Cody Sherr <csherr@covalent.net> and
		Ryan Morgan <rmorgan@covalent.net>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90090 13f79535-47bb-0310-9956-ffa450edef68

836811b7

Aug 10, 2001

hot and muggy in Raleigh (i.e., it's August) · ef1a66a0

Greg Ames authored Aug 10, 2001

De-emphasize some daedalus problems that don't seem so important any more.
I haven't tried the mod_cgid/suexec thing in ages.

<knocks on wood> We haven't seen a core dump on daedalus since the 2.0.22
tarball went live over a week ago.  It's got an APR circumvention for
an apparent FreeBSD sendfile bug.  Once I'm 100% confident we've nailed
the problem, I'll post this patch to the APR list.

The 0x30303030 seg fault after restart problem is just gone.  OtherBill may
have fixed this one with the inherit stuff...dunno.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90075 13f79535-47bb-0310-9956-ffa450edef68

ef1a66a0

Wipe out a couple suspended bugs. · c724d54e

Joshua Slive authored Aug 10, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90074 13f79535-47bb-0310-9956-ffa450edef68

c724d54e

Move things to the docs/STATUS file and reference the various · 014d66ca

Joshua Slive authored Aug 10, 2001

STATUS files sprinkled throughout the tree.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90073 13f79535-47bb-0310-9956-ffa450edef68

014d66ca

Hot and sunny again in Montreal. · 469af35d

Joshua Slive authored Aug 10, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90072 13f79535-47bb-0310-9956-ffa450edef68

469af35d

Clarify what %U will log. · 1276aba5

Joshua Slive authored Aug 10, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90071 13f79535-47bb-0310-9956-ffa450edef68

1276aba5

This should fix the remaining problems with POST. Basically, we · 1a16222d

Ryan Bloom authored Aug 10, 2001

add a new macro, called APR_BRIGADE_NORMALIZE. This macro searches
all the buckets, and removes any zero length bucket. They we can
just use APR_BRIGADE_EMPTY to determine if our brigade has any data,
and we can quickly call ap_get_brigade if it doesn't.

Doug, please throw your battery of tests at this to make sure it works.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90070 13f79535-47bb-0310-9956-ffa450edef68

1a16222d

Eliminate duplicate info and add references to logs.html. · acde8540

Joshua Slive authored Aug 10, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90068 13f79535-47bb-0310-9956-ffa450edef68

acde8540

Bring forward new logs.html doc from 1.3. · 50d0d2d7

Joshua Slive authored Aug 10, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90067 13f79535-47bb-0310-9956-ffa450edef68

50d0d2d7

Fix a bug in mod_expires. Previous to this patch, if you · 3c87fb85

Ryan Bloom authored Aug 10, 2001

told mod_expires to add 604800 seconds to the last-modified
time, it actually added 604800 usec's to the last-modified time,
so that when looking at the response it looked like nothing
had been done.  The root of the problem was that we always compute
time in usec's, but we ask users to input sec's.  This means we
need to convert to usec's before using those values.
CS: Obtained from:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90066 13f79535-47bb-0310-9956-ffa450edef68

3c87fb85

The worker MPM now handles shutdown and restart requests. It · a6e9dac6

Ryan Bloom authored Aug 10, 2001

definately isn't perfect, but we do stop the servers correctly.
The biggest problem right now is that SIGHUP causes the server to
just die.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90065 13f79535-47bb-0310-9956-ffa450edef68

a6e9dac6

record something in the error log if the parent process seg faults · 6a7fa3c3

Greg Ames authored Aug 10, 2001

Submitted by: Jeff Trawick


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90064 13f79535-47bb-0310-9956-ffa450edef68

6a7fa3c3

Aug 09, 2001

We want to use mod_cgid with the worker MPM as well. · c59f6f28

Ryan Bloom authored Aug 09, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90058 13f79535-47bb-0310-9956-ffa450edef68

c59f6f28

This change was moved into 2.0.23. The problem therefore both began and · 6a9eb21c

Cliff Woolley authored Aug 09, 2001

was fixed in 2.0.23, so no CHANGES entry is necessary.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90052 13f79535-47bb-0310-9956-ffa450edef68

6a9eb21c

Fix a restart problem when cgid is used. Code in the parent · 2445d7b9

Jeff Trawick authored Aug 09, 2001

httpd process was trying to clear a pool which is now only
initialized in the child.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90048 13f79535-47bb-0310-9956-ffa450edef68

2445d7b9

If we are going to get the length of a brigade, it helps if that · f5c38d42

Ryan Bloom authored Aug 09, 2001

brigade has data.  To that end, if we have just expanded ctx->b, we need
to concat ctx->b to the end of b, so that b has something to pass
back to the previous filter.

This fixes the problem with the proxy not proxying non-keepalive
connections.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90046 13f79535-47bb-0310-9956-ffa450edef68

f5c38d42

Add a comment so that the next poor fool who re-writes this section · 6fd4a49e

Ryan Bloom authored Aug 09, 2001

of code will know about this case.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90045 13f79535-47bb-0310-9956-ffa450edef68

6fd4a49e

Handle the -1 case in ap_http_filter. -1 means that we have to read · 9475baf5

Ryan Bloom authored Aug 09, 2001

all data from the socket until the socket is closed. This has been
used to proxy www.google.com successfully, but it doesn't return anything
when used with www.yahoo.com. Still debugging that problem.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90044 13f79535-47bb-0310-9956-ffa450edef68

9475baf5

Aug 08, 2001

Remove the block argument from apr_brigade_partition. This looked good · 38baf0b0

Ryan Bloom authored Aug 08, 2001

in theory, but in reality, we should just rely on the timeouts to handle
this.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90043 13f79535-47bb-0310-9956-ffa450edef68

38baf0b0

from madhu: no longer need to force eReadType and eMode · 615cb410

Doug MacEachern authored Aug 08, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90030 13f79535-47bb-0310-9956-ffa450edef68

615cb410

Re-apply the patch from yesterday that makes ap_http_filter use · bacc1518

Ryan Bloom authored Aug 08, 2001

apr_brigade_partition. In order to do this cleanly, I had to make
some changes to the apr_brigade_partition API, so this also adds fixes
all of the calls to that function throughout the server.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90029 13f79535-47bb-0310-9956-ffa450edef68

bacc1518

Update httpd to reflect change with free() pointer in buckets code · 63733e5b
Cliff Woolley authored Aug 08, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90028 13f79535-47bb-0310-9956-ffa450edef68
```
63733e5b

get POST requests working with mod_ssl · 9e0407be

Doug MacEachern authored Aug 08, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90027 13f79535-47bb-0310-9956-ffa450edef68

9e0407be

Apache Monitor's tray code does not notify Windows to remove it from the · 658b9f46

Roy T. Fielding authored Aug 08, 2001

tray when the process is destroyed. Just needed to add a call to remove
the tray icon before PostQuitMessage(0).

Also show "MS Windows XP" instead of "Whistler".

Submitted by: Jerry Baker <jerrybaker@weirdness.com>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90024 13f79535-47bb-0310-9956-ffa450edef68

658b9f46

drop a brace inside #if 0 so emacs can indent properly · d554ed31

Doug MacEachern authored Aug 08, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90023 13f79535-47bb-0310-9956-ffa450edef68

d554ed31

s/apr_size_t/apr_off_t/ for input filter · c67fb543

Doug MacEachern authored Aug 08, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90022 13f79535-47bb-0310-9956-ffa450edef68

c67fb543

Bump to 2.0.24-dev after tag · de41da9c

Cliff Woolley authored Aug 08, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90020 13f79535-47bb-0310-9956-ffa450edef68

de41da9c

Bump for 2.0.23 tag · caeca44e

Cliff Woolley authored Aug 08, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90018 13f79535-47bb-0310-9956-ffa450edef68

caeca44e

Aug 07, 2001

clean up the scoreboard properly after threaded processes die gracefully. · 53cc3e81

Greg Ames authored Aug 07, 2001

find_child_by_pid() failed to do its job, because ap_max_daemons_used was
too low.  There was some recent breakage in threaded that contributes to
the problem.

However, find_child_by_pid() should not be using the current number of
daemons.  It could have been recently reduced, which makes it fail to
find the exiting process.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90015 13f79535-47bb-0310-9956-ffa450edef68

53cc3e81

Hopefully it's marked as binary this time around... · c26dcb8a

Cliff Woolley authored Aug 07, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90014 13f79535-47bb-0310-9956-ffa450edef68

c26dcb8a

This file should have been marked -kb ... it's getting CRLF translated · c7671a37

Cliff Woolley authored Aug 07, 2001

by CVS on Windows.  I'll re-add it as -kb in the next commit.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90013 13f79535-47bb-0310-9956-ffa450edef68

c7671a37

change readbytes from a apr_size_t to a apr_off_t to match the parameter · 6f7820dd

Ian Holsman authored Aug 07, 2001

required in ap_get_brigade
Submitted by:	 barbee@veribox.net
Reviewed by:	 ianh@apache.org


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90012 13f79535-47bb-0310-9956-ffa450edef68

6f7820dd