Skip to content
  1. Feb 11, 2019
    • ylavic's avatar
      mod_proxy_http: rework the flushing strategy when forwarding the request body. · abe53b11
      ylavic authored 
      Since the forwarding of 100-continue (end to end) in r1836588, we depended on
reading all of the requested HUGE_STRING_LEN bytes to avoid the flushes, but
this is a bit fragile.

This commit introduces the new stream_reqbody_read() function which will try a
nonblocking read first and, if it fails with EAGAIN, will flush on the backend
side before blocking for the next client side read.

We can then use it in stream_reqbody_{chunked,cl}() to flush client forwarded
data only when necessary. This both allows "optimal" flushing and simplifies
code (note that spool_reqbody_cl() also makes use of the new function but not
its nonblocking/flush functionality, thus only for consistency with the two
others, simplification and common error handling).

Also, since proxy_http_req_t::flushall/subprocess_env::proxy-flushall are now
meaningless (and unused) on the backend side, they are renamed respectively to
prefetch_nonblocking/proxy-prefetch-nonblocking, and solely determine whether
to prefetch in nonblocking mode or not. These flags were trunk only and may
not be really useful if we decided to prefetch in nonblocking mode in any case,
but for 2.4.x the opt-in looks wise.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1853407 13f79535-47bb-0310-9956-ffa450edef68
      abe53b11
  3. Feb 10, 2019
  5. Feb 09, 2019
  7. Feb 08, 2019
  9. Feb 07, 2019
  11. Feb 05, 2019
  13. Feb 03, 2019
  15. Feb 02, 2019
  17. Jan 30, 2019
  19. Jan 29, 2019
  21. Jan 28, 2019
  23. Jan 27, 2019
  25. Jan 26, 2019
  27. Jan 25, 2019
  29. Jan 24, 2019
  31. Jan 23, 2019
  33. Jan 22, 2019
  35. Jan 20, 2019
  37. Jan 19, 2019
  39. Jan 18, 2019
  41. Jan 17, 2019
  43. Jan 15, 2019