Skip to content
  1. Nov 04, 2015
  3. Nov 03, 2015
  5. Nov 02, 2015
  7. Nov 01, 2015
  9. Oct 31, 2015
  11. Oct 30, 2015
  13. Oct 29, 2015
  15. Oct 28, 2015
  17. Oct 27, 2015
  19. Oct 26, 2015
  21. Oct 25, 2015
  23. Oct 24, 2015
  25. Oct 23, 2015
  27. Oct 22, 2015
    • Yann Ylavic's avatar
      core: follow up to r1710095. · c1894f6d
      Yann Ylavic authored 
      Simplify logic in check_pipeline(), and log unexpected errors.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1710105 13f79535-47bb-0310-9956-ffa450edef68
      c1894f6d
    • Yann Ylavic's avatar
      core: Limit to ten the number of tolerated empty lines between request, · f00bacf3
      Yann Ylavic authored 
      and consume them before the pipelining check to avoid possible response
delay when reading the next request without flushing.

Before this commit, the maximum number of empty lines was the same as
configured LimitRequestFields, defaulting to 100, which was way too much.
We now use a fixed/hard limit of 10 (DEFAULT_LIMIT_BLANK_LINES).

check_pipeline() is changed to check for (up to the limit) and comsume the
trailing [CR]LFs so that they won't be interpreted as pipelined requests,
otherwise we would block on the next read without flushing data, and hence
possibly delay pending response(s) until the next/real request comes in or
the keepalive timeout expires.
 
Finally, when the maximum number of empty line is reached in
read_request_line(), or that request line does not contains at least a method
and an (valid) URI, we can fail early and avoid some failure detected in
further processing.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1710095 13f79535-47bb-0310-9956-ffa450edef68
      f00bacf3