Skip to content
  1. Aug 31, 2001
    • Cliff Woolley's avatar
      As I understand it, this test is supposed to read like so: · 9ae13998
      Cliff Woolley authored
      ----------------------------------------------------
      if the base paths are the same
          if (strncmp(rnew->filename, fdir, fdirlen) == 0
      
      and there's more stuff in the new filename than just the base path
              && rnew->filename[fdirlen]
      
      and that stuff contains no slashes
              && ap_strchr_c(rnew->filename + fdirlen, '/') == NULL)
      ----------------------------------------------------
      
      Assuming that's a correct translation, which I believe to be the case
      (and which also seems to jive with the previous version of the test),
      then that first part darned well better check == 0, as opposed to != 0.
      strncmp returns 0 when they match.  =-)
      
      And voila,
      "All tests successful, 1 test skipped."
      is the result from httpd-test
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90842 13f79535-47bb-0310-9956-ffa450edef68
      9ae13998
    • Cliff Woolley's avatar
      Ryan apparently bumped this back DOWN from 2.0.25 to 2.0.25-dev after the · 3a018495
      Cliff Woolley authored
      last tag, rather than UP to 2.0.26-dev.  =-)
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90839 13f79535-47bb-0310-9956-ffa450edef68
      3a018495
    • William A. Rowe Jr's avatar
      · b26a654f
      William A. Rowe Jr authored
        Now that stinks, sorry.  In moving code - I didn't notice my code
        now served out (r) info instead of the (rnew) info.  Made for nasty
        cyclic loops in mod_dir :(
      
        It looks like this works once again.  I'll post completed deltas to
        the list ASAP.
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90838 13f79535-47bb-0310-9956-ffa450edef68
      b26a654f
    • William A. Rowe Jr's avatar
      · 673ad619
      William A. Rowe Jr authored
        Much better - sorry - I missed one case of forcing pipeline flush when
        the handler returned a non-OK result.  ergo, 304's weren't sent.
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90837 13f79535-47bb-0310-9956-ffa450edef68
      673ad619
    • William A. Rowe Jr's avatar
      · 1105edd7
      William A. Rowe Jr authored
        Invoking the handler must occur at the caller's discression, in order
        for the sub_req mechanism to share this code.
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90836 13f79535-47bb-0310-9956-ffa450edef68
      1105edd7
    • William A. Rowe Jr's avatar
      · cf45c2ef
      William A. Rowe Jr authored
        After calling ap_process_request_internal(), the caller must invoke
        the handler themselves.
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90835 13f79535-47bb-0310-9956-ffa450edef68
      cf45c2ef
    • William A. Rowe Jr's avatar
      · 6b388bef
      William A. Rowe Jr authored
        Move the ap_run_insert_filters to consistently occur in
        ap_process_request_internal.  This allows the sub_req handler
        to alter the filters before the subreq is actually run.
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90834 13f79535-47bb-0310-9956-ffa450edef68
      6b388bef
    • William A. Rowe Jr's avatar
      · 08227c21
      William A. Rowe Jr authored
          Normalize all paths to run the same, common code for pre-request setup
          from the primary request, redirects and sub-requests.
      
          This will significantly reduce opporunities for inconsistancy (such
          as Ian observed, and as I repaired only a month ago.)
      
          This promotes process_request_internal to an ap_ namespace protected
          entity in server/request.c (from it's old home in http/http_request.c)
          since this fn has no http specifics.
      
      Reviewed (in concept): Cliff Woolley, Ian Holsman
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90833 13f79535-47bb-0310-9956-ffa450edef68
      08227c21
    • William A. Rowe Jr's avatar
      · 2bc0acf5
      William A. Rowe Jr authored
        Normalize all paths to run the same, common code for pre-request setup
        from the primary request, redirects and sub-requests.
      
        This will significantly reduce opporunities for inconsistancy (such
        as Ian observed, and as I repaired only a month ago.)
      
        This promotes process_request_internal to an ap_ namespace protected
        entity in server/request.c (from it's old home in http/http_request.c)
        since this fn has no http specifics.
      
      Reviewed (in concept): Cliff Woolley, Ian Holsman
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90832 13f79535-47bb-0310-9956-ffa450edef68
      2bc0acf5
  2. Aug 30, 2001
  3. Aug 29, 2001