static in optional fn pointer variable declaration.

* modules/ssl/ssl_engine_vars.c (ssl_var_log_config_register):
  Likewise.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822931 13f79535-47bb-0310-9956-ffa450edef68

Fix my maths, thanks Stefan and Rüdiger!



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822883 13f79535-47bb-0310-9956-ffa450edef68

Does r1822878's "static" APR_RETRIEVE_OPTIONAL_FN work if, say, mod_proxy is
builtin but mod_http2 isn't?

Not worth taking the risk here since it's not a fast path...

Note: if this is an issue, I'm afraid it applies elsewhere too.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822879 13f79535-47bb-0310-9956-ffa450edef68

Get the help(er) of mod_http2 to determine how much connections should
be handled in the reslist by default (i.e. max_threads).



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822878 13f79535-47bb-0310-9956-ffa450edef68

adding AP_DECLARE for ap_parse_vhost_addrs() and minor bumb mmn. Resolves
     building mod_ssl on Windows. 



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822872 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822858 13f79535-47bb-0310-9956-ffa450edef68

  has changed.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822857 13f79535-47bb-0310-9956-ffa450edef68

  be useful as mod_http2 has an additional thread pool on top of
  ThreadsPerChild.
  But leave the default with ThreadsPerChild.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822849 13f79535-47bb-0310-9956-ffa450edef68

All was already there, I just misread name vs sname :/



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822806 13f79535-47bb-0310-9956-ffa450edef68

Actually we already have an (per vhost) unique id for the balancer, so use it.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822804 13f79535-47bb-0310-9956-ffa450edef68

Use a unique balancer id per vhost for workers' slotmem too.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822800 13f79535-47bb-0310-9956-ffa450edef68

We can't dereference 'f' after EOR is destroyed either.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822666 13f79535-47bb-0310-9956-ffa450edef68

mod_http2: removed obsolete stream detach code, no longer generating events
     in beam shutdown on pool destroy. 


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822624 13f79535-47bb-0310-9956-ffa450edef68

The core request filter is the only one which should take care of it.
In theory the other request filters should have bailed out on EOS already,
but that's not always the case (and even less the case on error).
So be safe by not sending them a bucket which may destroy the request (and
their brigade) underneath them.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822600 13f79535-47bb-0310-9956-ffa450edef68

The filter should pass everything up to and including EOR, then bail out.
For EOR it can't use a brigade created on r->pool, so retain one created
on c->pool in c->notes (this avoids leaking a brigades for each request
on the same connection).



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822596 13f79535-47bb-0310-9956-ffa450edef68

We can destroy ap_pglobal in the MPMs because clean_child_exit() runs in
a DSO which would be unloaded under us.

So we defer an ap_terminate() with atexit() in ap_unixd_mpm_set_signals(),
all this is static/builtin code in "os/unix/unixd.c".



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822537 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822535 13f79535-47bb-0310-9956-ffa450edef68

When connection_destructor() is called when pconf is gone, we can't dereference
worker->cp anymore. This happens is one_process mode exit if we apr_terminate()
or destroy the process pool directly (APR_POOL_DEBUG is needed too).

Fix this by NULL-ing worker->cp in conn_pool_cleanup(), and by registering it
as a pre_cleanup.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822531 13f79535-47bb-0310-9956-ffa450edef68

Please buildbot (and incidentally users of older APR) by using
apr_shm_remove() instead of the new(er) apr_shm_delete().



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822511 13f79535-47bb-0310-9956-ffa450edef68

To fix races with graceful restarts (PR 62044).

This commit does:
1/ use a constant file name for all systems (no generation suffix which
   makes a new SHM to be created for each restart, losing previous data)
2/ maintain the list of the created SHMs accross restarts (ap_pglobal list)
3/ not unlink the files on restart anymore (otherwise we can't reuse them)
4/ not attach existing SHMs in slotmem_create() anymore (not suitable since
   those are necessarily crash remainders)
5/ add type/sizes consistency check for persisted slots on restoration
6/ unlink the files only on stop/exit or before creating them (crash recovery)

We could possibly avoid 6/ (since we don't need to re-open files now) if we
remove the file just after the SHM is created.  This would at least work for
systems with "unlink semantic" (i.e. unlink succeeds even if some descriptors
are opened, the "real" thing happening when the last one desciptor closed), but
this wouldn't work for other sys...

Will follow up with an alternate fix.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822505 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822503 13f79535-47bb-0310-9956-ffa450edef68

mod_http2: discourage gzip/brotli content encoding on http2-status responses as
     they are inserted into the reponse when filters are already done.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822502 13f79535-47bb-0310-9956-ffa450edef68

core: adding defines to allow interworking with honggfuzz without
     further patches.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822500 13f79535-47bb-0310-9956-ffa450edef68

80 colums.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822367 13f79535-47bb-0310-9956-ffa450edef68

Export ap_queue_*() fonctions, so that they are accessible from MPMs, but
don't provide "mpm_fdqueue.h" in the API (include/).



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822366 13f79535-47bb-0310-9956-ffa450edef68

all platforms. Keep persisted filename as-was.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822341 13f79535-47bb-0310-9956-ffa450edef68

  since mk_password_hash() can use crypt().


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822305 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1822108 13f79535-47bb-0310-9956-ffa450edef68

but require user interaction until apu changes HAVE_CRYPTO default.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1821768 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1821767 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1821766 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1821727 13f79535-47bb-0310-9956-ffa450edef68

Make the allocation and zero-ing in ap_queue_init() => ap_queue_create().



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1821660 13f79535-47bb-0310-9956-ffa450edef68

Either error matters, simplify code.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1821659 13f79535-47bb-0310-9956-ffa450edef68

Be explicit in the naming about what's push/pop-ed.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1821651 13f79535-47bb-0310-9956-ffa450edef68

Free idle pools while stopping.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1821650 13f79535-47bb-0310-9956-ffa450edef68

Cosmetics, 80 cols, no functional change.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1821649 13f79535-47bb-0310-9956-ffa450edef68

Fix typo in comment.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1821648 13f79535-47bb-0310-9956-ffa450edef68

The code is not part of the API.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1821647 13f79535-47bb-0310-9956-ffa450edef68