Skip to content
  1. Oct 26, 2018
  3. Oct 24, 2018
  5. Oct 22, 2018
  7. Oct 21, 2018
  9. Oct 20, 2018
  11. Oct 19, 2018
  13. Oct 17, 2018
  15. Oct 16, 2018
  17. Oct 15, 2018
    • Rainer Jung's avatar
      SSL_read() doesn't distinguish between return value 0 and <0, · 524608b6
      Rainer Jung authored 
      at least not for OpenSSL 1.1.1. This is documented in the man
page for SSL_read and let to h2 failures when using OpenSSL 1.1.1.

When no data could be read, our code returned EAGAIN up until
OpenSSL 1.1.0, but APR_EOF for OpenSSL 1.1.1.

Now instead check SSL_get_error() also when SSL_read() returns 0.

To keep changes small, this change should not influence behavior,
when (rc=SSL_read()):
- rc < 0
- rc == 0 && *len > 0
- rc == 0 &&
  (APR_STATUS_IS_EAGAIN(inctx->rc) || APR_STATUS_IS_EINTR(inctx->rc) &&
  inctx->block == APR_NONBLOCK_READ

Behavior changes if
- rc == 0 &&
  !(APR_STATUS_IS_EAGAIN(inctx->rc) || APR_STATUS_IS_EINTR(inctx->rc) &&
  !*len > 0
  Instead of APR_EOF:
  - same behavior as rc < 0 for SSL_ERROR_WANT_READ
  - same behavior as rc < 0 for SSL_ERROR_SYSCALL && APR_STATUS_IS_EAGAIN(inctx->rc)

Another change is that rc == 0 && ssl_err == SSL_ERROR_ZERO_RETURN
also results in APR_EOF.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1843954 13f79535-47bb-0310-9956-ffa450edef68
      524608b6
    • Ruediger Pluem's avatar
      * Ensure that aborted connections are logged as such. · 6b286aaa
      Ruediger Pluem authored 
        Set c->aborted before apr_brigade_cleanup to have the correct status
  when logging the request as apr_brigade_cleanup triggers the logging
  of the request if it contains an EOR bucket.

PR: 62823
Submitted by: Arnaud Grandville <contact@grandville.net>
Reviewed by:rpluem


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1843939 13f79535-47bb-0310-9956-ffa450edef68
      6b286aaa
  19. Oct 13, 2018
  21. Oct 12, 2018
  23. Oct 11, 2018
  25. Oct 10, 2018
  27. Oct 09, 2018
  29. Oct 08, 2018
  31. Oct 05, 2018