- Dec 22, 2016
-
-
William A. Rowe Jr authored
Backports: r1710095, r1727544 Submitted by: ylavic, rpluem core: Limit to ten the number of tolerated empty lines between request, and consume them before the pipelining check to avoid possible response delay when reading the next request without flushing. Before this commit, the maximum number of empty lines was the same as configured LimitRequestFields, defaulting to 100, which was way too much. We now use a fixed/hard limit of 10 (DEFAULT_LIMIT_BLANK_LINES). check_pipeline() is changed to check for (up to the limit) and comsume the trailing [CR]LFs so that they won't be interpreted as pipelined requests, otherwise we would block on the next read without flushing data, and hence possibly delay pending response(s) until the next/real request comes in or the keepalive timeout expires. Finally, when the maximum number of empty line is reached in read_request_line(), or that request line does not contains at least a method and an (valid) URI, we can fail early and avoid some failure detected in further processing. Ensure that proto_num and protocol is set in another "error out early" edge case. This can happen with invalid CONNECT requests as described in the PR. PR: 58929 Borrow Yann's effort at cross-porting this to 2.2.x git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775758 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775756 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775752 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
to allow us to apply the 2.4.x already-reviewed HttpProtocolOptions and parser changes. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775749 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: trawick Another comment-only backport syncing to 2.4.x git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775735 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: trawick s/ensure/insure/ git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775733 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: trawick zap an unhelpful, out of date comment from httpd 1.2 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775732 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: niq Reject requests containing (invalid) NULL characters in request line or request headers. PR 43039 Backports: r892808 Submitted by: rpluem Fix up r892678 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775731 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
trunk patch: http://svn.apache.org/r1483005 Submitted by: jailletc36 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775730 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
No effective code change git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775728 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
navigated 2.4.x-merge-http-strict backport git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775727 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted By: Edward Lu <Chaosed0 gmail.com> Support custom ErrorDocuments for HTTP 501 and 414 status codes. PR 57167 [Edward Lu <Chaosed0 gmail.com>] git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775718 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: jailletc36 Fix sscanf format spotted by cppcheck (changes version major/minor types from signed to unsigned) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775717 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: jailletc36 Improve error message PR 54384 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775715 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: sf remove obsolete comment from 1.3 days git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775714 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: sf remove some more old unused code git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775713 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: sf Remove unused code. "Next week" hasn't happened in the last 10 years or so. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775712 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: trawick core: ErrorDocument now works for requests without a Host header. PR: 48357 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775711 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: sf Make sure that a triggering LimitRequestFieldSize is always logged, even if the first read already exeeds the limit and ap_rgetline does not return a header name. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775710 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: trawick s/ensure/insure/ git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775708 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: trawick zap an unhelpful, out of date comment from httpd 1.2 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775707 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: rpluem Correctly return a 400 (Bad request) in case of a HTTP/0.9 request like GET @example.org/foo git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775706 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: sf Downgrade some more log messages indicating client errors from level error to info. Add log messages for various reasons to return HTTP_BAD_REQUEST. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775705 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: sf Enforce LimitRequestFieldSize after multiple headers with the same name have been merged. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775699 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: sf Use APR_STATUS_IS_... in some more cases. While this is not strictly necessary everywhere, it makes it much easier to find the problematic cases. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775697 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: covener use APR_STATUS_IS_TIMEUP() instead of direct comparison with APR_TIMEUP. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775696 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: trawick comment on where multiple headers with same name get merged (some strict Cookie parsers can't handle what happens later, but that is not our fault) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775695 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: rpluem Fix up r892678 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775692 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
Submitted by: niq Reject requests containing (invalid) NULL characters in request line or request headers. PR 43039 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775691 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775685 13f79535-47bb-0310-9956-ffa450edef68
-
- Jul 15, 2015
-
-
William A. Rowe Jr authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@1691247 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@1691243 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@1691242 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
warning in 2.2 codebase?) Backports: r1514215 Submitted by: trawick git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@1691240 13f79535-47bb-0310-9956-ffa450edef68
-
William A. Rowe Jr authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@1691239 13f79535-47bb-0310-9956-ffa450edef68
-
Jeff Trawick authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@1691169 13f79535-47bb-0310-9956-ffa450edef68
-
Yann Ylavic authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@1691162 13f79535-47bb-0310-9956-ffa450edef68
-
- Jul 14, 2015
-
-
Gregg L. Smith authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@1691074 13f79535-47bb-0310-9956-ffa450edef68
-
- Jul 13, 2015
-
-
Yann Ylavic authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@1690841 13f79535-47bb-0310-9956-ffa450edef68
-
Jeff Trawick authored
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@1690840 13f79535-47bb-0310-9956-ffa450edef68
-