Record a vote


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79852 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79851 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79850 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79849 13f79535-47bb-0310-9956-ffa450edef68

safe_copy() which does strncpy the way it should be.

- switch many MAX_STRING_LENs with sizeof(foo) for the right foo, just in
case

- add const liberally to assist diagnosis

- fix two off-by-1 errors in get_tag() (it could be convinced to hammer
one byte past end of buffer)

- fix buffer overrun in get_directive()

- fix PR#1203 in a way that's fine for 1.2.x, but needs WIN32 support in
1.3

- test a few more error conditions and report them rather than doing
something lame

- buffer overrun and infinite loop in parse_string() eliminated

- removed unneeded test of palloc() and make_sub_pool() results against
NULL

- fix use of strncat which didn't \0 terminate the destination

- handle_else/handle_endif/handle_set/handle_printenv error messages
didn't include the filename

Reviewed by:	Jim Jagielski, Martin Kraemer


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79848 13f79535-47bb-0310-9956-ffa450edef68

to do the crap that we've been wanting done to mod_imap.

- liberal use of const to help find stack assignments

- remove all constant sized char arrays except input[]; replaced by pool
    string functions or by pointers into tokens inside the input[]
    array

- in particular, the use of read_quoted() had a stack overrun potential.
    Eliminated.

- These changes can chew memory when generating a menu.  I don't care,
    I'd rather have them do that than have them overrun the stack.  It
    shouldn't chew more than approx the size of the map file though.

- better error handling

Reviewed by:	Jim Jagielski, Martin Kraemer


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79847 13f79535-47bb-0310-9956-ffa450edef68

of low overhead processes to map IP numbers into hostnames concurrently
instead of one by one at a snails pace (logresolve.c).

Nobody said it was shite so here it is.

Submitted by: Rob Hartill


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79845 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79844 13f79535-47bb-0310-9956-ffa450edef68

	include 1998.

Reviewed by:	Jim Jagielski, Martin Kraemer


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79843 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79841 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79840 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79839 13f79535-47bb-0310-9956-ffa450edef68

use assembler :)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79837 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79835 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79834 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79832 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79831 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79830 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79829 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79828 13f79535-47bb-0310-9956-ffa450edef68

 - Replaced assert()'s with aplog_errors() in various places, so that
   we don't loose error checking in the release build. Also asserts()
   do an ungraceful exit - try to be kinder to the user.

 - Added some debug macros to send messages to the screen or error log
   (these are just for convenience - if you don't like them they can
   be removed) (APD1() thru APD5()).

 - Add model-independent functions to initiate a restart or shutdown.
   Currently this is initiated in functions which know they are being
   called as a signal handler. This is now abstracted to a separate
   functions, which can be called from a signal handler, or on Win32
   from the service controller callback. (start_shutdown(),
   start_restart())

 - Added lots of comments to the MT part of the code probably containing
   lots of tyops, er, typos.

 - In child_sub_main() (the "worker" thread code) used ptrans for
   the temporary pool, instead of pchild - now consistent with
   Unix child_main() [Incidently I'm not sure why ptrans is a global,
   since it (should) only be used within child_main()?]

 - made the parent thread (worker_main()) exit without going into the
   main parent loop if it is being signalled to die. Create the child
   pool (pchild) here (since this pool has a lifetime of a process,
   not a "child" (thread)). Cleanup this pool on exit, and run
   child_exit_modules().

 - worker_main() now will not exit until all the connections in its
   listen() queue are dealt with (previous it would "count_down" a
   few requests, then die, which would loose the connections in
   this process'es listen() queue). This now makes graceful restarts not
   loose connections. Once worker_main() has been told to exit it
   frees the mutex to allow another worker_main() to get into a listen()
   [however it seems Win32 directs incoming requests to the first process
   annoyingly]. To give the old worker_main() a chance to exit,
   only sleep for 1 second in the select. Also catch problems if the
   select() returns immediately with an error (previously this would
   cause a busy loop forever).

 - In the parent process (master_main()) abstract the creation/removal
   of processes (create_process(), cleanup_process()). Only bother to
   create one child process at once (more are unnecessary). Use an event
   to simulate a signal (with variables used to determine what action
   should be taken). Block forever waiting for a child to die or for
   the "signal" event (previously it would loop every 2 seconds). Handle
   shutdowns and restarts (both graceful). Allow multiple graceful
   restarts. Log error conditions like when child processes have to
   be forcibly terminated.

 - Update os/win32/service.c so that a "net stop apache" sends a
   graceful shutdown "signal" (using start_shutdown()). By changing
   this to call start_restart() you can also test graceful restarts.

 - Some unused code to do ungraceful shutdown/restart. Currently
   mutually exclusive with graceful restarts. Not compiled in by
   default. See the comments about UNGRACEFUL_RESTARTS in the patch.

On the downside, this patch

 - Makes the MT code more Win32 specific (this is necessary since
   it is useful to do WaitForMultipleObject() type things, for instance,
   and we don't have an abstraction for that). Also the Win32 stuff should
   use completion ports, and again we don't have an abstraction. However
   this does give us a good idea of stuff that does need abstracting.

 - I haven't checked for resource leaks, proper pool maintenence, or
   proper sequences of module init/child init/child exit API calls.

 - Makes http_main.c even bigger. I was going to split it out in
   core, multi-process and MT parts at the outset but that would
   have made comparing the patch pretty difficult. However I think it
   is a good idea to move the code in the #ifdef MULTITHREAD/#endif
   part to a separate http_main_mt.c (or maybe a http_main_win32 since
   it is quite specific at the moment).


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79827 13f79535-47bb-0310-9956-ffa450edef68

than setting the global service_stop variable. start_shutdown() will set
the appropriate variables and wakeup the parent process main thread


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79826 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79825 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79824 13f79535-47bb-0310-9956-ffa450edef68

ReportWin32Error().


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79823 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79822 13f79535-47bb-0310-9956-ffa450edef68

some time now)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79821 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79820 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79819 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79818 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79817 13f79535-47bb-0310-9956-ffa450edef68

Reviewed by:	Randy Terbush


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79816 13f79535-47bb-0310-9956-ffa450edef68

sure how that was.  There's a few other changes in here, nothing that affects
functionality, they're essentially documentation fixes.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79815 13f79535-47bb-0310-9956-ffa450edef68

never succeeds because mod_digest always looks at the Authorization header,
never at the Proxy-Authorization header.

Also, the scheme in the auth header is compared to "Digest" using a case-
sensitive comparison, instead of a case-insensitive comparison.

PR:		1599
Submitted by:	Ronald Tschalaer <Ronald.Tschalaer@psi.ch>
Reviewed by:	Dean Gaudet, Jim Jagielski


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79814 13f79535-47bb-0310-9956-ffa450edef68

- mark a constant structure as const, and make it static, it's a waste to
initialize it on every call

- initialize the status flags once rather than on every call

Reviewed by:	Jim Jagielski


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79813 13f79535-47bb-0310-9956-ffa450edef68

- fix minor buffer overrun in mod_info_html_cmd_string() (it would only
hammer a \0 up to 5 bytes past the end of the buffer... nothing big)

- mod_info_load_config() switched to use getword_conf() just like the real
config parsing routines

- replace a bunch of ap_snprintf()/rputs() pairs with rprintf() for more
efficiency

Reviewed by:	Brian Behlendorf


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79812 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79811 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79810 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79809 13f79535-47bb-0310-9956-ffa450edef68

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@79808 13f79535-47bb-0310-9956-ffa450edef68