Skip to content
  1. May 26, 2018
  2. May 25, 2018
  3. May 24, 2018
  4. May 23, 2018
    • Luca Toscano's avatar
      http_protocol.c: avoid duplicate headers when using · 21d05348
      Luca Toscano authored
                       ap_send_error_response
      
      While debugging PR 61860 I found a chain of events
      that leads to duplicate headers in the HTTP response
      if Header always set is used in the httpd's config.
      
      As far as can understand, mod_headers uses err_headers_out
      when dealing with the 'always' setting, since it is expected
      to be preserved even on error. The current code seems
      to correctly preserve the important headers like Location
      (happening before the bit of code that changed), but then
      it swaps headers_out with err_headers_out and clears
      err_headers_out. My understanding is that this will cause
      mod_headers, if called again, to re-insert the headers
      set via 'always' again in err_headers_out, leading to a
      duplication in the response. So far I managed to reproduce this
      only with the specific use case outlined by the PR, but
      there might be more.
      
      r1831585 was added to the test suite for PR 61860,
      (marked as TODO), and now it seems to pass as expected.
      
      Since this part of the codebase has been working fine
      for years I was reluctant to change it, but it seems
      the right change to me. I didn't run into any regression
      while testing this change (including running the test suite),
      but as always I'd be glad to get feedback from a more expert
      eye. If I missed a clear regression I'll make sure to
      add it to the test suite as part of the follow up.
      
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1832092 13f79535-47bb-0310-9956-ffa450edef68
      21d05348
    • Joe Orton's avatar
      * modules/ssl/ssl_engine_config.c: Fix typos, but isn't this first TODO · bade60cb
      Joe Orton authored
        actually done?
      
      
      git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1832078 13f79535-47bb-0310-9956-ffa450edef68
      bade60cb
  5. May 22, 2018
  6. May 20, 2018
  7. May 19, 2018
  8. May 18, 2018
  9. May 17, 2018
  10. May 14, 2018
  11. May 11, 2018
  12. May 09, 2018
  13. May 08, 2018
  14. May 06, 2018
  15. May 04, 2018