Commits · 7f1beeb55f4f692071376e28610c28ada33ac7b5 · CYBER - Cyber Security / TS 103 523 MSP / TLMSP / TLMSP Apache Httpd

Nov 01, 2002

· 7f1beeb5

William A. Rowe Jr authored Nov 01, 2002

Mr. Trawick was dead on, and this revealed a much bigger bug.
Factor out the opts/override merging (since we do it three times)
and eliminate all the nasty goto's. This bug likely caused all
sorts of dir_walk configuration issues including htaccess issues.
Also add a few more docs where things aren't so obvious.

PR: 14147

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97380 13f79535-47bb-0310-9956-ffa450edef68

7f1beeb5

· 52f470a1

William A. Rowe Jr authored Nov 01, 2002

Well that was a little borked, if you were having stack problems using
logio the missing pre_connection hook declartion could have something
to do with it.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97379 13f79535-47bb-0310-9956-ffa450edef68

52f470a1

Use APR_STATUS_IS_EOF rather than a check against APR_EOF · 3387b174
Justin Erenkrantz authored Nov 01, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97378 13f79535-47bb-0310-9956-ffa450edef68
```
3387b174

Style police were called back from their vacation · 16b7fe6a

Justin Erenkrantz authored Nov 01, 2002

*No functional changes*


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97377 13f79535-47bb-0310-9956-ffa450edef68

16b7fe6a

· 02f31b2c

William A. Rowe Jr authored Nov 01, 2002

  Inject logio into the win32 build


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97376 13f79535-47bb-0310-9956-ffa450edef68

02f31b2c

no such thing as AP_ASSERT() · 6a73dcbe

Jeff Trawick authored Nov 01, 2002

there is ap_assert() and AP_DEBUG_ASSERT()


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97375 13f79535-47bb-0310-9956-ffa450edef68

6a73dcbe

Add some waypoints to understanding this code · a9277683

Justin Erenkrantz authored Nov 01, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97374 13f79535-47bb-0310-9956-ffa450edef68

a9277683

Add some commentary on how we *think* the input filtering should be working · f35f13c9
Justin Erenkrantz authored Nov 01, 2002
```
in mod_ssl.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97373 13f79535-47bb-0310-9956-ffa450edef68
```
f35f13c9

I don't see how *len > wanted, but leave the check there. · a27bb7f8

Justin Erenkrantz authored Nov 01, 2002

Stick a comment in there as a 'Waldo was here' so that if I ever see this
again, I realize that I've actually thought about it and didn't think >
was necessary.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97372 13f79535-47bb-0310-9956-ffa450edef68

a27bb7f8

· 7df815a3

William A. Rowe Jr authored Nov 01, 2002

Clean up the read pattern for cases when some data already exists.
Also return APR_SUCCESS once we've gathered any decrypted bytes.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97371 13f79535-47bb-0310-9956-ffa450edef68

7df815a3

· dfa89455

William A. Rowe Jr authored Nov 01, 2002

  Distinguish inctx, outctx, frec [and b ??? looked like bucket to me!!!]


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97370 13f79535-47bb-0310-9956-ffa450edef68

dfa89455

· 093814a3

William A. Rowe Jr authored Nov 01, 2002

More nits spotted by Justin, and catch all the errors except SYSCALL
in the SSL logging section.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97369 13f79535-47bb-0310-9956-ffa450edef68

093814a3

· 494c39d0

William A. Rowe Jr authored Nov 01, 2002

Suggestions by Justin, implemention by Will. Rename away all bogisity,
especially eliminating all of 'our' capitalized identifiers that were
easily confused with library symbols; go with APR_STATUS_IS_EOF() just
in case there is a platform result; fix a bogus *len = 0; reassignment
and fold the two flavors of input context tracking into one.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97368 13f79535-47bb-0310-9956-ffa450edef68

494c39d0

· 6e18e939

William A. Rowe Jr authored Nov 01, 2002

Completely refactor the BIO-side client input handling for the SSL library.
Should eliminate many false spurious interrupt detected errors.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97367 13f79535-47bb-0310-9956-ffa450edef68

6e18e939

· c2ab307b

William A. Rowe Jr authored Nov 01, 2002

Fix a trailing slash/last filename truncation bug observed on Linux,
which affected DAV MOVE operations and even general file access.
PR 14147, 10687, 10236 [Dan Good <debug@gooddan.com>]

I'm accepting Jeff Trawick's suggestion of twisting the test into an
assert, since it seems very unlikely (after correctly resetting the flag)
that this will fault.

Reviewed by: Jeff Trawick, Will Rowe

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97366 13f79535-47bb-0310-9956-ffa450edef68

c2ab307b

Oct 31, 2002

Terminate CGI scripts when the client connection drops. This · 53204162

Jeff Trawick authored Oct 31, 2002

fix only applies to some normal paths in mod_cgi.  mod_cgid
is still busted.

A prereq for this fix is the change to content-length filter to
notice c->aborted:

http://cvs.apache.org/viewcvs.cgi/httpd-2.0/server/protoc
ol.c.diff?r1=1.119&r2=1.120&diff_format=h

PR:         8388


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97364 13f79535-47bb-0310-9956-ffa450edef68

53204162

when the connection drops, c->aborted is set but generally · 9d84c0a1

Jeff Trawick authored Oct 31, 2002

ap_pass_brigade returns APR_SUCCESS

content-length needs to be alert to c->aborted so that it
doesn't keep trying to pass brigades down (otherwise, you get
errors writing to the network over and over and over and ...)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97363 13f79535-47bb-0310-9956-ffa450edef68

9d84c0a1

add a comment lamenting the lack of a cleanup for the CGI child · e219cde8

Jeff Trawick authored Oct 31, 2002

process and mentioning some issues related to the problem


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97362 13f79535-47bb-0310-9956-ffa450edef68

e219cde8

note release date · 6fe8ccdb

Cliff Woolley authored Oct 31, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97360 13f79535-47bb-0310-9956-ffa450edef68

6fe8ccdb

Oct 30, 2002

document a byterange filter fix · 48890b7f

Greg Ames authored Oct 30, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97359 13f79535-47bb-0310-9956-ffa450edef68

48890b7f

· 567a7b7c

Paul J. Reder authored Oct 30, 2002

Added my two cents worth of votes and updated the cache entry in the
experimental status section.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97357 13f79535-47bb-0310-9956-ffa450edef68

567a7b7c

record a few votes. · 4dba8755

Greg Ames authored Oct 30, 2002

I need to catch up on emails regarding modules/experimental/ so I understand
what I'm voting on there. I would hate to see mod_cache & friends,
mod_ext_filter, and mod_charset_lite (esp. for EBCDIC) suddenly disappear.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97355 13f79535-47bb-0310-9956-ffa450edef68

4dba8755

Use r->request_time in lieu of apr_time_now() in cache object age calculations · 2227b497
Bill Stoddard authored Oct 30, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97351 13f79535-47bb-0310-9956-ffa450edef68
```
2227b497

New XML. · 631793bd

Yoshiki Hayashi authored Oct 30, 2002

Submitted by: Hiroaki KAWAI <hawk@bcl.t.u-tokyo.ac.jp>
Reviewed by: Yoshiki Hayashi

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97350 13f79535-47bb-0310-9956-ffa450edef68

631793bd

Update transformations. · 9173b97c

Yoshiki Hayashi authored Oct 30, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97349 13f79535-47bb-0310-9956-ffa450edef68

9173b97c

Typo. · 8a4f70ae

Yoshiki Hayashi authored Oct 30, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97348 13f79535-47bb-0310-9956-ffa450edef68

8a4f70ae

Update Japanese translations. · 7c34d04a

Yoshiki Hayashi authored Oct 30, 2002

Submitted by: Hiroaki KAWAI <hawk@bcl.t.u-tokyo.ac.jp>
Reviewed by: Yoshiki Hayashi

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97347 13f79535-47bb-0310-9956-ffa450edef68

7c34d04a

Oct 29, 2002

· b1375767

William A. Rowe Jr authored Oct 29, 2002

Fix memory leak in mod_ssl from internal SSL library allocations
within SSL_get_peer_certificate and X509_get_pubkey.

Submitted by: Zvi Har'El <rl@math.technion.ac.il>
Reviewed by: Madhusudan Mathihalli <madhusudan_mathihalli@hp.com>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97344 13f79535-47bb-0310-9956-ffa450edef68

b1375767

· c5590363

William A. Rowe Jr authored Oct 29, 2002

  Detabbify.  With extreme prejudice.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97342 13f79535-47bb-0310-9956-ffa450edef68

c5590363

· f081281d

William A. Rowe Jr authored Oct 29, 2002

  On an errno rampage... ap_log_error takes an apr_status_t


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97341 13f79535-47bb-0310-9956-ffa450edef68

f081281d

· 6d523753

William A. Rowe Jr authored Oct 29, 2002

Close several small leaks in SSL.

Submitted by: Zvi Har'El <rl@math.technion.ac.il>
Reviewed by: Madhusudan Mathihalli <madhusudan_mathihalli@hp.com>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97340 13f79535-47bb-0310-9956-ffa450edef68

6d523753

PR 8482 is resolved · 5bd803bf

Jeff Trawick authored Oct 29, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97339 13f79535-47bb-0310-9956-ffa450edef68

5bd803bf

Oct 28, 2002

· 56aecdf8

William A. Rowe Jr authored Oct 28, 2002

Commit rbowen's votes at his request, gotta get that access issue cleared
up for him in avail.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97336 13f79535-47bb-0310-9956-ffa450edef68

56aecdf8

it's a darned good thing these things are in the status file or I'd NEVER · f6a5006d

Cliff Woolley authored Oct 28, 2002

be able to keep up


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97334 13f79535-47bb-0310-9956-ffa450edef68

f6a5006d

Votes · 471ca8cd

Bill Stoddard authored Oct 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97333 13f79535-47bb-0310-9956-ffa450edef68

471ca8cd

add some votes · 420dfe6a

Jeff Trawick authored Oct 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97332 13f79535-47bb-0310-9956-ffa450edef68

420dfe6a

Clarified the wording on backward compatibility for 2.0, and added my vote · d32f263e
Brian Pane authored Oct 28, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97331 13f79535-47bb-0310-9956-ffa450edef68
```
d32f263e

Add in my 2c on the 2.1 and versioning schemes. · f0c1783d

Aaron Bannert authored Oct 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97330 13f79535-47bb-0310-9956-ffa450edef68

f0c1783d

Added comments on the async I/O part of the roadmap · 6cb1c0bd

Brian Pane authored Oct 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97329 13f79535-47bb-0310-9956-ffa450edef68

6cb1c0bd

Cast some votes (my 0s are true 0s in that I'll abstain for now) · 741493e2
Justin Erenkrantz authored Oct 28, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97323 13f79535-47bb-0310-9956-ffa450edef68
```
741493e2