Commits · 5924491a32e6478396e5baa607775df3ed505c4b · CYBER - Cyber Security / TS 103 523 MSP / TLMSP / TLMSP Apache Httpd

Jul 26, 2001

Fix a segfault in threaded.c caused by passing uninitialized · 5924491a

Jeff Trawick authored Jul 26, 2001

apr_thread_t * to apr_thread_join().  Now we clear the array
of apr_thread_t * initially so we can track which threads we
actually created.

Other changes:

don't clobber storage by passing bogus array entry as 1st
parameter to apr_thread_create() to create the start_threads()
thread

join up with the start_threads() thread at termination so that
it is cleaned up and so that no worker threads are still being
created


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89735 13f79535-47bb-0310-9956-ffa450edef68

5924491a

· dfd95911

William A. Rowe Jr authored Jul 26, 2001

  Update make file for win32


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89733 13f79535-47bb-0310-9956-ffa450edef68

dfd95911

· 119b2587

William A. Rowe Jr authored Jul 26, 2001

Something that needs looking at, all our long (unsigned long) body
lengths need to become apr_off_t.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89732 13f79535-47bb-0310-9956-ffa450edef68

119b2587

· aa1db802

William A. Rowe Jr authored Jul 26, 2001

That's it. There are no further emits for signedness or size conversion
in MSVC 5.x. Enough for 2.0.22, I'll revisit under -w4 (msvc's -wall)
and attack the other modules in 2.0.23-dev.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89731 13f79535-47bb-0310-9956-ffa450edef68

aa1db802

· 0de9633c

William A. Rowe Jr authored Jul 26, 2001

Terniaries are broken under MSVC, they never did resolve how to resolve
the type of an obvious conversion like this one. Even casting the const
to an apr_port_t doesn't solve it.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89730 13f79535-47bb-0310-9956-ffa450edef68

0de9633c

· 6544d91a

William A. Rowe Jr authored Jul 26, 2001

  Flush the off_t compiler emits from mod_isapi


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89729 13f79535-47bb-0310-9956-ffa450edef68

6544d91a

· 4da43cb0

William A. Rowe Jr authored Jul 26, 2001

This patch should address input buffering, requesting only as much from
the client as the ap_get_client_block() buffer is prepared to accept.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89728 13f79535-47bb-0310-9956-ffa450edef68

4da43cb0

· bbe607f5

William A. Rowe Jr authored Jul 26, 2001

Change the length of the content args to apr_off_t identifiers, and fix
mod_negotation to treat a size of -1 and indeterminate, instead of 0.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89727 13f79535-47bb-0310-9956-ffa450edef68

bbe607f5

Include the fingerprint for my public key in · db9e84ff

Cliff Woolley authored Jul 26, 2001

addition to the key itself as suggested by Dw


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89720 13f79535-47bb-0310-9956-ffa450edef68

db9e84ff

Jul 25, 2001

· 4c5c37eb

William A. Rowe Jr authored Jul 25, 2001

  Cliff's most sane advise :-)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89719 13f79535-47bb-0310-9956-ffa450edef68

4c5c37eb

· 11c5f3d9

William A. Rowe Jr authored Jul 25, 2001

  Reviewing my own commit logs ... dang did this look silly.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89718 13f79535-47bb-0310-9956-ffa450edef68

11c5f3d9

· b99345d0

William A. Rowe Jr authored Jul 25, 2001

Safe casts - we are assured that len_read is positive, but it must be
stored as an int to initially check the ap_get_client_block() result.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89717 13f79535-47bb-0310-9956-ffa450edef68

b99345d0

· e7f71178

William A. Rowe Jr authored Jul 25, 2001

  Same fix for largefile support as core.c


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89716 13f79535-47bb-0310-9956-ffa450edef68

e7f71178

· 32faa0dd

William A. Rowe Jr authored Jul 25, 2001

  More signedness fixes


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89715 13f79535-47bb-0310-9956-ffa450edef68

32faa0dd

· 777fc211

William A. Rowe Jr authored Jul 25, 2001

This same patch is needed in mod_asis and others, I'm testing the waters
for this solution. I'm easily convinced to choose AP_MAX_SENDFILE based
on any reasonable argument, provided it's smaller than 2^30 :-)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89714 13f79535-47bb-0310-9956-ffa450edef68

777fc211

· ebd177c4

William A. Rowe Jr authored Jul 25, 2001

  Change over to apr_strfsize() for apr_off_t file size formatting.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89713 13f79535-47bb-0310-9956-ffa450edef68

ebd177c4

· fdb9ff4a

William A. Rowe Jr authored Jul 25, 2001

  Some cast magic for intentional float/int transformations, but I have
  no idea what exactly this computation was trying to accomplish...

    req_time = (long)(((ws_record.stop_time - ws_record.start_time) * 1000)
		    + ((ws_record.stop_time - ws_record.start_time) / 1000));


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89712 13f79535-47bb-0310-9956-ffa450edef68

fdb9ff4a

· 675f5b72

William A. Rowe Jr authored Jul 25, 2001

  Some cast magic for intentional float/int transformations.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89711 13f79535-47bb-0310-9956-ffa450edef68

675f5b72

fix the "server seems busy" message so that it really logs · 45c6a448

Jeff Trawick authored Jul 25, 2001

the number of children we're about to spawn


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89710 13f79535-47bb-0310-9956-ffa450edef68

45c6a448

fix some typos, add a comment · 89f5ee15

Jeff Trawick authored Jul 25, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89709 13f79535-47bb-0310-9956-ffa450edef68

89f5ee15

PR: · f62b1259

Cliff Woolley authored Jul 25, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89708 13f79535-47bb-0310-9956-ffa450edef68

f62b1259

Avoid uninitialized variable due to still disabled code · 3c6eaf3f
Ralf S. Engelschall authored Jul 25, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89705 13f79535-47bb-0310-9956-ffa450edef68
```
3c6eaf3f

Sorting things out · 93cbbdfd

Chuck Murcko authored Jul 25, 2001

Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89704 13f79535-47bb-0310-9956-ffa450edef68

93cbbdfd

OS/2: get canonical filename functions exported from the core. · 40e6dbd8
Brian Havard authored Jul 25, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89698 13f79535-47bb-0310-9956-ffa450edef68
```
40e6dbd8

Another of the long term issues cleared up. BeOS can now run · 980fa7dd

David Reid authored Jul 25, 2001

perl and other CGI's that rely on .so's for their operation.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89697 13f79535-47bb-0310-9956-ffa450edef68

980fa7dd

Jul 24, 2001

Add my PGP key · 83d1cad8

Cliff Woolley authored Jul 24, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89687 13f79535-47bb-0310-9956-ffa450edef68

83d1cad8

Reduce CPU consumption in conv_10 function, used to format "%d" by apr_*printf · 9c114104

Greg Ames authored Jul 24, 2001

This includes two changes to APR:
  * new functions apr_itoa, apr_ltoa, and apr_off_t_toa
    that provide itoa-type functionality based on pools
  * Inline code in inet_ntop4 to replace sprintf for converting
    binary IP addresses into dotted-decimal format

and two changes to Apache:
  * use the apr_itoa functions in setting the content length,
    in place of apr_psprintf
  * use the apr_itoa functions to replace frequent uses of
    'sprintf("%d",...)' in mod_log_config.

Submitted by: Brian Pane
Reviewed by:  Dean Gaudet, Greg Ames


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89686 13f79535-47bb-0310-9956-ffa450edef68

9c114104

fix warning · 41aab6e0

Chuck Murcko authored Jul 24, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89685 13f79535-47bb-0310-9956-ffa450edef68

41aab6e0

A couple of optimizations to the content_length filter. · bc7b9c5e

Bill Stoddard authored Jul 24, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89684 13f79535-47bb-0310-9956-ffa450edef68

bc7b9c5e

· 8becb8a1

William A. Rowe Jr authored Jul 24, 2001

Changes to respect the new apr bucket and brigade length types (either
apr_size_t for bucket lengths, or apr_off_t for aggregate brigade lengths.)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89683 13f79535-47bb-0310-9956-ffa450edef68

8becb8a1

· b97b709e

William A. Rowe Jr authored Jul 24, 2001

  It's a nit, but since I'm searching for "win32" it ought to be there :)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89682 13f79535-47bb-0310-9956-ffa450edef68

b97b709e

bandaid for segv in ssl_io_filter_Output · f6b3a8ef

Doug MacEachern authored Jul 24, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89681 13f79535-47bb-0310-9956-ffa450edef68

f6b3a8ef

zero the SSLStateMachine in case of early error, else SSLStateMachine_free segvs · 691b3259
Doug MacEachern authored Jul 24, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89680 13f79535-47bb-0310-9956-ffa450edef68
```
691b3259

Fix problem with the previous patch to handle HEAD requests. Now, the · 116c1078

Bill Stoddard authored Jul 24, 2001

header_filter will stay installed in the filter chain when processing
HEAD requests to intercept and discard content bodys sent by poorly
written handlers. This work also points out the need for an optimization
in the content_length filter to not split the brigade if the next bucket
in the brigade is an EOS.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89679 13f79535-47bb-0310-9956-ffa450edef68

116c1078

Fix problem reported by Taketo Kabe <kabe@sra-tohoku.co.jp> · c444519a

Bill Stoddard authored Jul 24, 2001

where HEAD response headers were being repeated twice for
files greater than 32K bytes (4*AP_MIN_BYTES_TO_WRITE). This
problem in the http_header filter was exposed by the recent rewrite
of the content_length filter.
[Taketo Kabe, Bill Stoddard]

PR: 8037


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89676 13f79535-47bb-0310-9956-ffa450edef68

c444519a

· ff4ba634

William A. Rowe Jr authored Jul 24, 2001

  Change the worker_function implementations to accept both parameters,
  the apr private data (apr_thread_t*) and the application private data
  (void*), for the last update to APR.

Submitted by: Aaron Bannert <aaron@ebuilt.com>
Reviewed by: Will Rowe


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89672 13f79535-47bb-0310-9956-ffa450edef68

ff4ba634

Document and future-proof the dependency between apr_read_type_e and · 8ed89602

Cliff Woolley authored Jul 24, 2001

ap_input_mode_t.  It's now safe(r) to cast from ap_read_type_e to
ap_input_mode_t.

Submitted by:	Justin Erenkrantz, Sander Striker


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89671 13f79535-47bb-0310-9956-ffa450edef68

8ed89602

Jul 23, 2001

· 31de4eec

William A. Rowe Jr authored Jul 23, 2001

  The original answer was evil, return NULL if the file name has no path!


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89666 13f79535-47bb-0310-9956-ffa450edef68

31de4eec

· 1a7beeee

William A. Rowe Jr authored Jul 23, 2001

  Some odd XXX fixups that are closed (or unneeded)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89665 13f79535-47bb-0310-9956-ffa450edef68

1a7beeee

· 5b51c06f

William A. Rowe Jr authored Jul 23, 2001

  Downgrade non-stopper from XXX->###


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89664 13f79535-47bb-0310-9956-ffa450edef68

5b51c06f