AP_DEBUG is defined.

ap_get_client_block():
. avoid some cases where we leak a temporary bucket brigade
. clean up/fix the logic to copy a brigade into the caller's buffer;
  the wrong length was used in some cases
. add an AP_DEBUG-only assertion for some assumptions made regarding
  the brigade returned by the filters

Submitted by:	partly by Greg Stein, but of course anything bad is mine


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86583 13f79535-47bb-0310-9956-ffa450edef68

If ap_get_brigade() returns APR_SUCCESS but an empty brigade, bail out.
Previously, we kept going and sometimes segfaulted while operating on
what we thought was the first bucket.

Free the temporary brigade used by getline().


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86581 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86580 13f79535-47bb-0310-9956-ffa450edef68

  Completes the port of the <Directory /> handling for Win32... there is
  still a patch needed for OS2 ... Brian?


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86579 13f79535-47bb-0310-9956-ffa450edef68

pointers are replaced with a global table that allows modules to register
their bucket types.  Those bucket types are then allowed to be used in
the server processing.  This also required removing all direct calls to
those functions.  The ap_bucket type has an index into an array, so in
each ap_bucket_* function, we use that index to find the correct set of
functions.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86575 13f79535-47bb-0310-9956-ffa450edef68

once we finish writing the request body to the cgi child process;
otherwise, the client doesn't hit EOF on stdin.  Small request bodies
worked without this change (for reasons I don't understand), but large
ones didn't.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86574 13f79535-47bb-0310-9956-ffa450edef68

  http_filter() - this was referencing e->length even though e->length
    is sometimes -1 (if we have to read the socket bucket to get the
    next bit of the request body); now it does e->read() to force a
    socket need if required
  ap_get_client_block() - this was getting a brigade back with the
    desired amount of data (yeah, right) but only copying out the first
    bucket


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86573 13f79535-47bb-0310-9956-ffa450edef68

get_brigade code should also use apr_ssize_t.
Submitted by:	Greg Stein


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86572 13f79535-47bb-0310-9956-ffa450edef68

  Modify ap_make_dirstr_prefix, platforms with HAVE_DRIVE_LETTERS or NETWARE
  can request 0 elements, returning the '/' root.
  [William Rowe, Tim Costello]  from 1.3, with documentation


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86571 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86570 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86569 13f79535-47bb-0310-9956-ffa450edef68

specific value, and therefore it belongs in the ap_bucket_file type,
which was also created with this commit.  ap_bucket needs to be as generic
as possible to make it easily extensible, which means we have to keep
the generic ap_bucket type very separate from ap_bucket_foo.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86568 13f79535-47bb-0310-9956-ffa450edef68

values for the length, -1, 0, and a positive number.  -1 means that the
next filter should return all the data it has, the current filter will
take care to ensure that the protocol is followed.  Most filters will
never use this, because it implies they are implementing a conn_based
input filter.  0 means give me exactly one line of data.  A positive
number means give me a maximum of n bytes.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86567 13f79535-47bb-0310-9956-ffa450edef68

  Move more path parsing fixes forward from 1.3


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86564 13f79535-47bb-0310-9956-ffa450edef68

  I hope this clarifies.  Greg is absolutely correct, there is no need for
  any modules symbol other than AP_MODULE_DECLARE_DATA, since module .h
  files containing imports and exports imply something more sophisticated,
  as the early mod_dav.c example illustrated.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86562 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86561 13f79535-47bb-0310-9956-ffa450edef68

doesn't make much sense to check to see if there is something there.  This
removes the input_data brigade from the conn_rec altogether.  There is no
good reason for a filter to be accessing a bucket brigade from within the
conn_rec.  This shouldn't be here anymore, just like the output_filter
shouldn't be storing the data in the conn_rec.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86560 13f79535-47bb-0310-9956-ffa450edef68

with the bucket design, so they need to go away.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86559 13f79535-47bb-0310-9956-ffa450edef68

cgid module.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86558 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86556 13f79535-47bb-0310-9956-ffa450edef68

again.  Chunking input doesn't work with this change, but that is because
this is a stop-gap to get POSTs working again.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86555 13f79535-47bb-0310-9956-ffa450edef68

one or more rlimit controls.  (Solaris 2.8 hits both of these.)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86554 13f79535-47bb-0310-9956-ffa450edef68

anymore because getline() returns < 0 upon EOF.
There are also a few very minor tweaks to getline() -- remove an
unused variable, remove a couple of unnecessary comments, simplify
an error path.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86553 13f79535-47bb-0310-9956-ffa450edef68

works for me, but please beat it up and review.

Submitted by: Jeff Trawick, Greg Ames


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86552 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86551 13f79535-47bb-0310-9956-ffa450edef68

note any changes here that will affect end-user configuration.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86550 13f79535-47bb-0310-9956-ffa450edef68

to follow.  This code works for browser based requests and line-based
telnet requests.  It is untested with character-based telnet requests.
I will be testing that very soon.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86549 13f79535-47bb-0310-9956-ffa450edef68

variables to a general discussion of environment variables in Apache.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86548 13f79535-47bb-0310-9956-ffa450edef68

currently, but it is a step in the right direction.  Input filtering
should be slowly improving from here on out.
Submitted by:	Greg Ames, Ryan Bloom, Jeff Trawick


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86547 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86546 13f79535-47bb-0310-9956-ffa450edef68

  Reflect the ApacheModuleBleck -> mod_bleck rename for Win32.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86545 13f79535-47bb-0310-9956-ffa450edef68

instead of bucket->destroy().  bucket->destroy() wasn't being
called correctly and also we were leaking the storage for the
bucket itself since bucket->destroy() doesn't free the ap_bucket.
Submitted by:	Ryan Bloom, Jeff Trawick


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86544 13f79535-47bb-0310-9956-ffa450edef68

  A star is born ... adds mod_dav and mod_dav_fs to the Win32 build/install


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86543 13f79535-47bb-0310-9956-ffa450edef68

  Here it is, mod_dav should build quite nicely on Win32 (two last mild
  warnings to contend with.)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86542 13f79535-47bb-0310-9956-ffa450edef68

  Read the /D symbol declaration in this patch with the next patch to
  mod_dav.c sources, and things should make a world of sense.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86541 13f79535-47bb-0310-9956-ffa450edef68

  Regardless of reaction to a symbol rename -within- the sources, these
  external symbols change for clarity.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86540 13f79535-47bb-0310-9956-ffa450edef68

  Parallels the commit to apr.h.in/apr.hw for the apache core library.
  Only mod_dav/mod_dav_fs and ap_hooks.h (as best examples) will use these
  symbols until it is acceptable to all or the new symbols are backed out.

  This symbol rename will have the unique quality that
  strlen("API_EXPORT") == strlen("AP_DECLARE"), therefore the mass symbol
  rename will not throw off function continuation lines.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86539 13f79535-47bb-0310-9956-ffa450edef68

  Get rid of some darned ugly exception lists


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86538 13f79535-47bb-0310-9956-ffa450edef68

  Finish the ApacheModuleBleck -> mod_bleck cleanup


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86537 13f79535-47bb-0310-9956-ffa450edef68

  Second half of the ugly name to nice name change.  Clean your tree
  before you grab this set :-)

Reviewed by:	rbb, stoddard


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@86536 13f79535-47bb-0310-9956-ffa450edef68