Skip to content
  1. Nov 20, 2003
  3. Nov 13, 2003
  5. Nov 12, 2003
  7. Nov 07, 2003
  9. Nov 06, 2003
  11. Nov 03, 2003
  13. Nov 02, 2003
  15. Nov 01, 2003
  17. Oct 30, 2003
  19. Oct 29, 2003
  21. Oct 26, 2003
  23. Oct 24, 2003
  25. Oct 23, 2003
  27. Oct 22, 2003
  29. Oct 15, 2003
  31. Oct 14, 2003
  33. Oct 11, 2003
  35. Oct 10, 2003
  37. Oct 02, 2003
  39. Sep 30, 2003
  41. Sep 29, 2003
  43. Sep 27, 2003
  45. Sep 25, 2003
  47. Sep 23, 2003
    • Cliff Woolley's avatar
      The problem that this patch solves is one where cookie names are mis-identified · 86429387
      Cliff Woolley authored 
      by mod_usertrack. This is because of the use of strstr() in spot_cookie() the
original mod_usertrack.c to find the name of the cookie. strstr(), by virtue of
looking for a substring instead of an exact match, can mis-identify the cookie
"MyID" as the cookie "ID" or "My". So, if you were looking for the value of the
cookie "ID", but only the cookie "MyID" was returned by the browser,
mod_usertrack.c would return the value of the "MyID" cookie in place of the
"ID" you were looking for.

Even more seriously, because strstr is invoked before the cookie name is
separated from its cookie value, a cookie and value like
"myCookie=thisisnotIDeal" will be a false positive if you told mod_usertrack
the cookie name was ID. Furthermore, using this example, "eal" will get logged
as the value of the cookie; now that strstr has incorrectly identified the
substring "ID" as the cookie name, the following "e" (assumed to be the "="
sign) gets discarded, and the remaining content used as the value of
the cookie.

Replacing the strstr() with a more robust regex match fixes this problem.

PR:    16661
Submitted by:   Manni Wood <manniwood@planet-save.com>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@101306 13f79535-47bb-0310-9956-ffa450edef68
      86429387