Commits · 3d5b286731a7a0d1cd03e810663a974f5471e9b1 · CYBER - Cyber Security / TS 103 523 MSP / TLMSP / TLMSP Apache Httpd

Feb 12, 2002

· 3d5b2867

William A. Rowe Jr authored Feb 12, 2002

  After hours of debugging, the answer was -trivial-, but extremely
  obscure and difficult to trace.  This should do away with the handle
  corruption we experienced.  If anyone cares to walk the crt (source
  is installed in vc\src\crt if you install it w/ Visual C++/Studio)
  it's worth understanding why this occured.

  This patch

    1. creates the pipe non-inherited, and dups the write end
       for inheritence with limited permissions.
    2. sets the STD_ERROR_HANDLE _after_ we fixup the FILE *stderr and fd 2.
    3. Splits the signal_monitor event in two, service_init/service_term
       for clarity and correctness.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93374 13f79535-47bb-0310-9956-ffa450edef68

3d5b2867

Correct ordering. · 88d534e9

Joshua Slive authored Feb 12, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93373 13f79535-47bb-0310-9956-ffa450edef68

88d534e9

Clarify what <IfModule> means in the world of mod_so. · 2ca06180

Joshua Slive authored Feb 12, 2002

PR: 9787


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93372 13f79535-47bb-0310-9956-ffa450edef68

2ca06180

· 7a3cfbfc

William A. Rowe Jr authored Feb 12, 2002

Perform a serious scrubbing of the child process, before we report that
we failed to create the child. Cleans up CloseHandle() destruction to
match all created handles - and postpone populating the *child_exit_event
until we succeed.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93369 13f79535-47bb-0310-9956-ffa450edef68

7a3cfbfc

· dc25c754

William A. Rowe Jr authored Feb 12, 2002

This code seriously misassumed (and may yet) that stderr was a valid file.
It also has some bogus non-apr code that probably does great evil to win32
services. This must be bumped into .32, code review is incomplete still.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93368 13f79535-47bb-0310-9956-ffa450edef68

dc25c754

Feb 11, 2002

· 40c9f502

William A. Rowe Jr authored Feb 11, 2002

Move the sleep until after we have duplicated the simple handles. We must
still pause and reflect on the Child's startup before WSADuplicateHandle()

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93367 13f79535-47bb-0310-9956-ffa450edef68

40c9f502

if a child detects a resource shortage on accept(), limit the rate of fork()s · 8ce1d422

Greg Ames authored Feb 11, 2002

to 1 per second until the situation clears up.

Inspired by: Martin Kraemer


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93366 13f79535-47bb-0310-9956-ffa450edef68

8ce1d422

· a40e6586

William A. Rowe Jr authored Feb 11, 2002

  Never close the handle, if it is the StdError psuedohandle.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93363 13f79535-47bb-0310-9956-ffa450edef68

a40e6586

style/spelling tweaks · 654dcdf3

Jeff Trawick authored Feb 11, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93362 13f79535-47bb-0310-9956-ffa450edef68

654dcdf3

Win32: Handles returned by GetStdHandle are psuedo handles and should never be · e1012d8c

Bill Stoddard authored Feb 11, 2002

passed to a CloseHandle call.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93361 13f79535-47bb-0310-9956-ffa450edef68

e1012d8c

Make apache -k shutdown an alias for apache -k stop. "shutdown" maintained · b9cd56f0

Bill Stoddard authored Feb 11, 2002

for backward compatability.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93360 13f79535-47bb-0310-9956-ffa450edef68

b9cd56f0

Get apache -k restart -n apache2 working reliabily again. · d5056266

Bill Stoddard authored Feb 11, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93359 13f79535-47bb-0310-9956-ffa450edef68

d5056266

Remove all signal handling from the worker MPM's child processes. Instead, · 1825bfc3

Ryan Bloom authored Feb 11, 2002

we use the pipe of death for all communication between parent and child.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93358 13f79535-47bb-0310-9956-ffa450edef68

1825bfc3

Feb 10, 2002

accept() error handling should be OK now. · 1d3f6eea

Greg Ames authored Feb 10, 2002

I don't have a strong opinion on what we should do if the parent dies, now
that we don't have a real life example of that any more. It was a little
confusing at first, but OTOH it kept serving requests.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93357 13f79535-47bb-0310-9956-ffa450edef68

1d3f6eea

prefork shouldn't be killing its parent if a child runs out of resources. · 00636b55
Greg Ames authored Feb 10, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93356 13f79535-47bb-0310-9956-ffa450edef68
```
00636b55

Feb 09, 2002

Copied changes that have been made recently to the 1.3 documentation. · 2d3b7c93

Richard Bowen authored Feb 09, 2002

Primarily additional explanation and examples.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93354 13f79535-47bb-0310-9956-ffa450edef68

2d3b7c93

Windows should not hold up an otherwise excellent release. · de8c7908
Bill Stoddard authored Feb 09, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93352 13f79535-47bb-0310-9956-ffa450edef68
```
de8c7908

it's cold outside · 4a082d6c

Jeff Trawick authored Feb 09, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93351 13f79535-47bb-0310-9956-ffa450edef68

4a082d6c

I say the input filtering change are as complete as it will be for 2.0, · 8e2c9aa4

Justin Erenkrantz authored Feb 09, 2002

so remove the note in STATUS.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93350 13f79535-47bb-0310-9956-ffa450edef68

8e2c9aa4

Point at the JRE_1 tag if anyone is interested. · c5576f53

Justin Erenkrantz authored Feb 09, 2002

IMHO, v31 is dead.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93349 13f79535-47bb-0310-9956-ffa450edef68

c5576f53

Get rid of the DAVParam support. That was a concept to help out · d13cc46e

Greg Stein authored Feb 09, 2002

mod_dav providers in the 1.0.x series. Nowadays, the providers are
full-fledged Apache modules and can define their own directives and
set up per-server and per-directory parameters. (for example,
mod_dav_fs and the DAVLockDB directive)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93348 13f79535-47bb-0310-9956-ffa450edef68

d13cc46e

Feb 08, 2002

hmmm... not so sure anymore · fac011dc

Jeff Trawick authored Feb 08, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93347 13f79535-47bb-0310-9956-ffa450edef68

fac011dc

Fixed an alignment problem between httpd and aprlib · b0b044e2

Bradley Nicholes authored Feb 08, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93345 13f79535-47bb-0310-9956-ffa450edef68

b0b044e2

add another log message showing when we server a cached file (as info not debug) · c27cded3
Ian Holsman authored Feb 08, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93344 13f79535-47bb-0310-9956-ffa450edef68
```
c27cded3

· 09fd0af9

William A. Rowe Jr authored Feb 08, 2002

  Some considerable fixes in sending log messages out to the event log.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93343 13f79535-47bb-0310-9956-ffa450edef68

09fd0af9

· eeb56290

William A. Rowe Jr authored Feb 08, 2002

Drawing attention to the timing problem; push the wait up so we do about
nothing until WinNT initializes the app.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93342 13f79535-47bb-0310-9956-ffa450edef68

eeb56290

Renamed the internal environment variable reference from NDK to LIBC · 9cdafdfb
Bradley Nicholes authored Feb 08, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93341 13f79535-47bb-0310-9956-ffa450edef68
```
9cdafdfb
Added the renaming of apr_ldap.hnw to the prebuild precessing · 0c0ef83a
Bradley Nicholes authored Feb 08, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93340 13f79535-47bb-0310-9956-ffa450edef68
```
0c0ef83a

Updated to use the newer locking API's. This file should probably be moved · 2902c080

Bradley Nicholes authored Feb 08, 2002

to the httpd-ldap with the rest of the auth_ldap stuff.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93339 13f79535-47bb-0310-9956-ffa450edef68

2902c080

Added .def files for build on NetWare · 6db00160

Bradley Nicholes authored Feb 08, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93338 13f79535-47bb-0310-9956-ffa450edef68

6db00160

Updated to use the newer locking APIs · 384adaf2

Bradley Nicholes authored Feb 08, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93337 13f79535-47bb-0310-9956-ffa450edef68

384adaf2

why are the skies cloudy all day? · 3af78b91

Jeff Trawick authored Feb 08, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93336 13f79535-47bb-0310-9956-ffa450edef68

3af78b91

Explain why I'm sitting on .32. · fb9d0824

Justin Erenkrantz authored Feb 08, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93335 13f79535-47bb-0310-9956-ffa450edef68

fb9d0824

update CHANGES for an input side seg fault fix. · 83b45ae4

Greg Ames authored Feb 08, 2002

also, get rid of a mainframe term that somehow leaked into a comment which
might confuse people.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93334 13f79535-47bb-0310-9956-ffa450edef68

83b45ae4

style police · d8a88303

Ian Holsman authored Feb 08, 2002

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93333 13f79535-47bb-0310-9956-ffa450edef68

d8a88303

ensure that ap_rgetline allocates storage for the request line each time it is · 1ce68c38

Greg Ames authored Feb 08, 2002

called.

This fixes a number of segfaults on daedalus where the first line is
empty (i.e. \r\n followed by a bunch of garbage)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93332 13f79535-47bb-0310-9956-ffa450edef68

1ce68c38

Feb 07, 2002

Allow statically linked support binaries with the new · 7415eacc

Aaron Bannert authored Feb 07, 2002

--enable-static-support flag, and enable this behavior in
the binbuild script. Also add a new --enable-static-htdbm
flag.

BTW, this takes care of 7/8th of a showstopper.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93331 13f79535-47bb-0310-9956-ffa450edef68

7415eacc

That check is superfluous since we must have savename defined · 4455a879

Justin Erenkrantz authored Feb 07, 2002

(otherwise, we'd get APR_INCOMPLETE on apr_dir_read).


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93330 13f79535-47bb-0310-9956-ffa450edef68

4455a879

Allow mod_autoindex to serve symlinks if permitted and optimize our stats · ca305e28

Justin Erenkrantz authored Feb 07, 2002

so that only one stat() is needed.

If we get APR_FINFO_MIN bits, lookup_dirent won't do a repeated stat()
call.  So, let's do it here.  Also, if we see a symlink, expand it.
(Technically, we don't *have* to expand the symlinks - the resolve_symlink
fix handles that, but we can't really assume that.)  Since we know that
dirent will be rr->finfo anyway, go back to relying on dirent only for
APR_DIR checks.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93329 13f79535-47bb-0310-9956-ffa450edef68

ca305e28

Fix resolve_symlink to save the original symlink name if known. · f1461c4a

Justin Erenkrantz authored Feb 07, 2002

We would previously receive APR_INCOMPLETE on symlinks if wanted has
FINFO_NAME set because it isn't supported via apr_stat().  Furthermore, we
don't care what the real name is anyway (even if it apr_stat returned
.name) - we want to call it by the name the symlink says it is.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93328 13f79535-47bb-0310-9956-ffa450edef68

f1461c4a