Commits · 321824abea557d0527089599ad68790d51a27e0a · CYBER - Cyber Security / TS 103 523 MSP / TLMSP / TLMSP Apache Httpd

Mar 01, 2002

All I can say is "Ouch" this is nasty. · 321824ab

Justin Erenkrantz authored Mar 01, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93658 13f79535-47bb-0310-9956-ffa450edef68

321824ab

Our favorite showstopper is getting reports from our fans. · e2861d95
Justin Erenkrantz authored Mar 01, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93657 13f79535-47bb-0310-9956-ffa450edef68
```
e2861d95

· 83734a6e

William A. Rowe Jr authored Mar 01, 2002

For fat-fingered friends and others who like typing err and warn rather
than spelling it out on the -e argument.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93656 13f79535-47bb-0310-9956-ffa450edef68

83734a6e

· 3fa0666a

William A. Rowe Jr authored Mar 01, 2002

Significant cleanup and enable wintty to -always- escape from the service
context when the run-as-user is LocalSystem or has access to the windows
station and desktop. The original method did not give us a visible tty
unless the 'Allow Service to Interact with Desktop' toggle was set.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93655 13f79535-47bb-0310-9956-ffa450edef68

3fa0666a

We don't need transfer_brigade() because we already have macros to do that · 6fd57a11

Cliff Woolley authored Mar 01, 2002

for us, and faster. :)

Warning, though: transfer_brigade() was equivalent to APR_BRIGADE_CONCAT(),
and I don't think that was the right behavior for one of the two callers!
I changed that one to use APR_BRIGADE_PREPEND() since by my inspection that
looks like what it should be, but please check me on this.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93654 13f79535-47bb-0310-9956-ffa450edef68

6fd57a11

s/const void/const char/g in ssl_asn1_table api · 94954027

Doug MacEachern authored Mar 01, 2002

pointed out by gstein


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93653 13f79535-47bb-0310-9956-ffa450edef68

94954027

Consensus is that we should not use the scoreboard as a source of entropy. · a8f6ece5

Cliff Woolley authored Mar 01, 2002

Reviewed by: OtherBill, Justin, Madhu


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93652 13f79535-47bb-0310-9956-ffa450edef68

a8f6ece5

Give mod_dav the ability to output both standard and customized · b8c26ed4

Greg Stein authored Mar 01, 2002

<D:error> responses.  It's crucial for marshalling svn error messages
back over to the client; and someday it will be needed to return
specific <DAV:> errors as dictated by the DeltaV spec.

* mod_dav.h (dav_error): add two new fields -- an optional error
    namespace, and an error-tag-name.  Remove the 'delayed computation'
    function and cxt ptrs in this struct;  they were never used.

  (dav_new_error_tag):  new alternative constructor that takes new
    fields.

* util.c (dav_new_error_tag):  implement constructor.

* mod_dav.c (dav_error_response_tag):  new function to output
    'standard' xml error response based on error struct.

  (dav_handle_err): if no multistatus response is passed in, and if an
    error-tag is defined, then call our new xml-output routine.

Submitted by: Ben Collins-Sussman <sussman@collab.net>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93651 13f79535-47bb-0310-9956-ffa450edef68

b8c26ed4

Feb 28, 2002

Use the new APR_BRIGADE_PREPEND() macro · 773f4534

Cliff Woolley authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93650 13f79535-47bb-0310-9956-ffa450edef68

773f4534

New xml mod_auth_digest docs. · 3b8f5243

Joshua Slive authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93649 13f79535-47bb-0310-9956-ffa450edef68

3b8f5243

plug leak in newish ssl_asn1_table_set() function · c0313665

Doug MacEachern authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93648 13f79535-47bb-0310-9956-ffa450edef68

c0313665

How can reach our goals if we never have them? So, I ask, "Can we kill · 5b57ca46

Justin Erenkrantz authored Feb 28, 2002

all showstoppers in a week?" Are there enough developers paying attention
to go showstopper hunting?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93647 13f79535-47bb-0310-9956-ffa450edef68

5b57ca46

Sync with contents of apache-1.3/ABOUT_APACHE · 8ca86632

Lars Eilebrecht authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93646 13f79535-47bb-0310-9956-ffa450edef68

8ca86632

Fix a typo on a directive name. · 5881da88

Joshua Slive authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93642 13f79535-47bb-0310-9956-ffa450edef68

5881da88

For some reason AC_PREFIX_DEFAULT must not be called before the apr · a0e88e09

Aaron Bannert authored Feb 28, 2002

m4 files are included. This fixes builds on autoconf 2.52 again.

Obtained from:  Sander Striker
Submitted by:	Thom May <thom@planetarytramp.net>
Reviewed by:	Aaron Bannert


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93639 13f79535-47bb-0310-9956-ffa450edef68

a0e88e09

remove an XXX: we already do CRYPTO_set_locking_callback() in ssl_util_thread_setup() · 80b393e7
Doug MacEachern authored Feb 28, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93637 13f79535-47bb-0310-9956-ffa450edef68
```
80b393e7

remove #ifdef SHARED_MODULE around ssl library cleanup calls. · 2a6cbfa0

Doug MacEachern authored Feb 28, 2002

SHARED_MODULE is no longer defined, so we were leaking.
plus we always do a full startup/teardown regardless of being a dso or
static.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93636 13f79535-47bb-0310-9956-ffa450edef68

2a6cbfa0

move SSL_load_client_CA_file() comment to where we moved the call to it · 14a73b2d
Doug MacEachern authored Feb 28, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93635 13f79535-47bb-0310-9956-ffa450edef68
```
14a73b2d

various SSLCACertificatePath fixes: · 6924ef75

Doug MacEachern authored Feb 28, 2002

- return value from apr_dir_read() was checking != APR_SUCCESS rather
  than == APR_SUCCESS, so no certs were ever loaded.

- wasn't checking return value of apr_dir_open(), now log an error and
  ssl_die() on failure.

- don't bother trying to load directories


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93634 13f79535-47bb-0310-9956-ffa450edef68

6924ef75

plug leak in ssl_init_FindCAList() where return value of · 2fdd1297

Doug MacEachern authored Feb 28, 2002

X509_NAME_oneline() used for trace logging was not freed.
now passes in a static buffer so no buffer is malloced.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93633 13f79535-47bb-0310-9956-ffa450edef68

2fdd1297

fold some duplication within ssl_init_FindCAList() into generic · 66a6e18f

Doug MacEachern authored Feb 28, 2002

ssl_init_PushCAList() function.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93632 13f79535-47bb-0310-9956-ffa450edef68

66a6e18f

need to free X509_NAME duplicates already found in the stack built by · dc316c24

Doug MacEachern authored Feb 28, 2002

ssl_init_FindCAList().


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93626 13f79535-47bb-0310-9956-ffa450edef68

dc316c24

need to free the stacks returned by calls to SSL_load_client_CA_file() · 9cb5f2cd

Doug MacEachern authored Feb 28, 2002

in ssl_init_FindCAList(). values are pushed into another stack which
gets freed when SSL context is destroyed.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93625 13f79535-47bb-0310-9956-ffa450edef68

9cb5f2cd

contrary to what comments say, DH* returned from ssl_dh_GetTmpParam() · dacb66d8

Doug MacEachern authored Feb 28, 2002

is _not_ static and needs to be freed via DH_free().


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93624 13f79535-47bb-0310-9956-ffa450edef68

dacb66d8

need to free sc->pRevocationStore at shutdown · a9bcc587

Doug MacEachern authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93623 13f79535-47bb-0310-9956-ffa450edef68

a9bcc587

No longer assume SERVER_CONFIG_FILE is in the "conf" directory. Instead · eed49413

Aaron Bannert authored Feb 28, 2002

look for it in the $sysconfdir.

This required the use of a new m4 function from APR that retrieves
the fully "expanded", or recursively interpolated, value of the
$sysconfdir variable.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93622 13f79535-47bb-0310-9956-ffa450edef68

eed49413

PR: · 8a997974

Doug MacEachern authored Feb 28, 2002

Obtained from:
Submitted by:
Reviewed by:
add note about ssl restart changes.
s/mod_perl/mod_ssl/ in bill's note.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93621 13f79535-47bb-0310-9956-ffa450edef68

8a997974

always reusing existing private key for given vhost on restarts if key · 86342ff9

Doug MacEachern authored Feb 28, 2002

is encrypted and mtime stamp has not changed. this prevents getting
prompted twice for passphrase on windows and elsewhere when server is
started with -DNO_DETACH.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93620 13f79535-47bb-0310-9956-ffa450edef68

86342ff9

s/asn1->mtime/asn1->source_mtime/ · f0b66e5c

Doug MacEachern authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93619 13f79535-47bb-0310-9956-ffa450edef68

f0b66e5c

Fix a typo in the default cgidir variable. · 5706d3ed

Aaron Bannert authored Feb 28, 2002

Set a couple more defaults if they haven't already been set, just
as a precaution.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93618 13f79535-47bb-0310-9956-ffa450edef68

5706d3ed

initialize ssl_asn1_t.mtime to 0 · 09c2916d

Doug MacEachern authored Feb 28, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93617 13f79535-47bb-0310-9956-ffa450edef68

09c2916d

reuse vhost keys for asn1 tables where keys are allocated out · ea4ad54d

Doug MacEachern authored Feb 28, 2002

of s->process->pool to prevent "leaking" each time we format
a vhost key.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93616 13f79535-47bb-0310-9956-ffa450edef68

ea4ad54d

switch SSLModConfigRec.tPublicCert to ssl_asn1_table api to prevent · 53ee1dba

Doug MacEachern authored Feb 28, 2002

leakage on restarts.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93615 13f79535-47bb-0310-9956-ffa450edef68

53ee1dba

switch SSLModConfigRec.tPrivateKey to ssl_asn1_table api to prevent · 7f9759da

Doug MacEachern authored Feb 28, 2002

leakage on restarts.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93614 13f79535-47bb-0310-9956-ffa450edef68

7f9759da

add ssl_asn1_table_get() wrapper and change ssl_init_TmpKeysHandle() · 6f089289
Doug MacEachern authored Feb 28, 2002
```
to use it.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93613 13f79535-47bb-0310-9956-ffa450edef68
```
6f089289

mod_ssl was "leaking" on restart since mc->tTmpKeys table entries · bd5fc8f6

Doug MacEachern authored Feb 28, 2002

were allocated using apr_palloc out of s->process->pool and pushed
into an apr_array_header_t.
solve the problem by moving from apr_array_header_t's to an apr_hash_t.
also add ssl_asn1_table_{set,unset} wrappers to use malloc/free so we
do not "leak" from s->process->pool.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93612 13f79535-47bb-0310-9956-ffa450edef68

bd5fc8f6

Feb 27, 2002

clean up the passed-in brigade since mod_deflate is through with it · 478bb8f6
Allan K. Edwards authored Feb 27, 2002
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93611 13f79535-47bb-0310-9956-ffa450edef68
```
478bb8f6

ownership of the brigade is passed in the ap_pass_brigade call · 4c362dc1

Allan K. Edwards authored Feb 27, 2002

so make sure that it doesn't get left lying around. This tickled
a bug with mod_deflate and resulted in a bucket being compressed
more than once.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93610 13f79535-47bb-0310-9956-ffa450edef68

4c362dc1

axe an unused variable · 0967935a

Jeff Trawick authored Feb 27, 2002


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93609 13f79535-47bb-0310-9956-ffa450edef68

0967935a

· 474b9ed7

William A. Rowe Jr authored Feb 27, 2002

I hope this explanation is simple enough - comments welcome.

When you touch CHANGES - remember they are for the 'common man',
not just us :-) Legibility is important.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93608 13f79535-47bb-0310-9956-ffa450edef68

474b9ed7