Commits · 29c87164c013de610ab5994d6ec1c1cf65db98c4 · CYBER - Cyber Security / TS 103 523 MSP / TLMSP / TLMSP Apache Httpd

Nov 23, 2001

mod_ssl is big and bulky, takes awhile to load, sometimes must wait for · 29c87164

Aaron Bannert authored Nov 23, 2001

entropy to be collected, and has a nasty little bug that prevents the
server from being started in non-SSL mode. This patch corrects some of
those problems, but is not intended as a workaround for the bug.

Submitted by: Madhusudan Mathihalli <madhusudan_mathihalli@hp.com>
Reviewed by: Aaron Bannert

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92145 13f79535-47bb-0310-9956-ffa450edef68

29c87164

Modify post_config hook so that it can return a error, · f49cd809

Ian Holsman authored Nov 23, 2001

causing the server not to start.
previous method was to call exit(1) which would not fail
gracefully

PR:
Obtained from:
Submitted by:
Reviewed by:	(Idea only Jeff Trawick)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92144 13f79535-47bb-0310-9956-ffa450edef68

f49cd809

make doxygen stop complianing about some netware specific C calls · 749e8374

Ian Holsman authored Nov 23, 2001

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92143 13f79535-47bb-0310-9956-ffa450edef68

749e8374

converted apr_pcalloc to apr_palloc for 15% reduction in run time of add_any_filter · f81b8c96
Brian Pane authored Nov 23, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92142 13f79535-47bb-0310-9956-ffa450edef68
```
f81b8c96
restructured the conditional logic in ap_merge_per_dir_configs() for faster execution · 618a3676
Brian Pane authored Nov 23, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92141 13f79535-47bb-0310-9956-ffa450edef68
```
618a3676
replaced the hash used in add_any_filter() with a trie for 2.5x speedup · ecb636be
Brian Pane authored Nov 23, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92140 13f79535-47bb-0310-9956-ffa450edef68
```
ecb636be

Nov 22, 2001

It's better to dup the apr_mmap_t when we first create it. The result · 25761652

Cliff Woolley authored Nov 22, 2001

is the same, and it saves us a call to apr_mmap_dup() per request.

Reviewed by: Brian Pane (concept)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92139 13f79535-47bb-0310-9956-ffa450edef68

25761652

optimized away a strlen call in alias_matches() · a3bcf50f

Brian Pane authored Nov 22, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92138 13f79535-47bb-0310-9956-ffa450edef68

a3bcf50f

added inlined string concatenation to form_header_field() for speed · ae14b041
Brian Pane authored Nov 22, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92137 13f79535-47bb-0310-9956-ffa450edef68
```
ae14b041
minor performance fix for ap_add_common_vars(): replace printf with apr_itoa() · 52ebf1d1
Brian Pane authored Nov 22, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92136 13f79535-47bb-0310-9956-ffa450edef68
```
52ebf1d1

Mention the new --with-suexec-bin parameter. · 15dbad32

Aaron Bannert authored Nov 22, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92135 13f79535-47bb-0310-9956-ffa450edef68

15dbad32

Allow SUEXEC_BIN to be defined by the configure script. · 15246a3f

Aaron Bannert authored Nov 22, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92134 13f79535-47bb-0310-9956-ffa450edef68

15246a3f

Fix link. · cb850722

Joshua Slive authored Nov 22, 2001

Submitted by:	Stepan Kasal <kasal@math.cas.cz>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92133 13f79535-47bb-0310-9956-ffa450edef68

cb850722

Just some style changes from when I was working on the recent suexec · d83b4d98

Aaron Bannert authored Nov 22, 2001

patch. No more tabs, intended alignment remains.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92132 13f79535-47bb-0310-9956-ffa450edef68

d83b4d98

fix for a segfault that occurred when mod_include was used to deliver files shorter than 5 bytes · 1338e923
Brian Pane authored Nov 22, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92131 13f79535-47bb-0310-9956-ffa450edef68
```
1338e923

fix segv in worker MPM following check_pipe_of_death() call · 0721c430

Brian Pane authored Nov 22, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92130 13f79535-47bb-0310-9956-ffa450edef68

0721c430

dont va_start() in ssl_log() unless we are actually going to log something · 07eb5d9e
Doug MacEachern authored Nov 22, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92123 13f79535-47bb-0310-9956-ffa450edef68
```
07eb5d9e

avoid a couple of calls to ssl_util_vhostid() and apr_psprintf() · d8946a15

Doug MacEachern authored Nov 22, 2001

unless loglevel >= SSL_LOG_INFO
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92122 13f79535-47bb-0310-9956-ffa450edef68

d8946a15

optimize lookup of ssl-{unclean,accurate}-shutdown flags: · 59a9e4f0

Doug MacEachern authored Nov 22, 2001

- only look through the table once, rather than 2 apr_table_gets()
- case-sensitive and use strcmp() as little as possible
- only lookup once per-connection, as the flags will not change across
  keepalive requests
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92121 13f79535-47bb-0310-9956-ffa450edef68

59a9e4f0

two performance improvements: · a052fc9a

Doug MacEachern authored Nov 22, 2001

- switch from using r->notes to r->request_config
- avoid a strcmp() when checking if val eq '!'

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92120 13f79535-47bb-0310-9956-ffa450edef68

a052fc9a

return from ssl_callback_LogTracingState if sc->nLogLevel < SSL_LOG_INFO · f5a1e501

Doug MacEachern authored Nov 22, 2001

else there are 5 (expensive!) calls made to ssl_var_lookup on every request
for info that will never be logged
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92119 13f79535-47bb-0310-9956-ffa450edef68

f5a1e501

macros for dumping the list of server_recs · 8d8f3dc1

Doug MacEachern authored Nov 22, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92116 13f79535-47bb-0310-9956-ffa450edef68

8d8f3dc1

remove AP_CTX_* macros which are no longer used · 0d3e82fe

Doug MacEachern authored Nov 22, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92114 13f79535-47bb-0310-9956-ffa450edef68

0d3e82fe

get rid of 'apctx' table that used to live in SSL_get_app_data2(ssl) · 92420dd5

Doug MacEachern authored Nov 22, 2001

change app_data2 to be the request_rec itself.
if something needs per-request context in the future,
it can use r->request_config

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92113 13f79535-47bb-0310-9956-ffa450edef68

92420dd5

move c->notes.ssl::verify::depth to SSLConnRec.verify_depth · 177f2286

Doug MacEachern authored Nov 22, 2001

note: may actually be removed unless somebody can figure out why it is in
there to begin with
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92111 13f79535-47bb-0310-9956-ffa450edef68

177f2286

Nov 21, 2001

get rid of SSL_get_app_data2_idx() which had a race condition when · b8c617af

Doug MacEachern authored Nov 21, 2001

writing to app_data2_idx, and another inside OpenSSL when calling
SSL_get_ex_new_index().
add SSL_init_app_data2_idx() to provide the same functionality but in
a safe place: called during ssl_init_Module
PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92110 13f79535-47bb-0310-9956-ffa450edef68

b8c617af

move c->notes.ssl::verify::{info,error} to SSLConnRec.verify_{info,error} · ac259b21

Doug MacEachern authored Nov 21, 2001

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92109 13f79535-47bb-0310-9956-ffa450edef68

ac259b21

Add mod_deflate (formerly known as mod_gz) to experimental. mod_deflate · 36e584e1

Justin Erenkrantz authored Nov 21, 2001

supports gzip transfer-encoding as an output filter.

Initially coded by Ian, but Justin made a number of improvements to
the coding style and its use of filters.

We have 7 binding +1s and no vetos in STATUS for addition.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92108 13f79535-47bb-0310-9956-ffa450edef68

36e584e1

remove test_pass_brigade; it lives in httpd-test not here · 6393e276
Doug MacEachern authored Nov 21, 2001
```
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92107 13f79535-47bb-0310-9956-ffa450edef68
```
6393e276

comment out module test_pass_brigade as it doesn't exist · 8b42030e

Ian Holsman authored Nov 21, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92105 13f79535-47bb-0310-9956-ffa450edef68

8b42030e

move c->notes.ssl::flag::{unclean,accurate}-shutdown to SSLConnRec.shutdown_type · 8c42324a

Doug MacEachern authored Nov 21, 2001

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92100 13f79535-47bb-0310-9956-ffa450edef68

8c42324a

Bail out at configure time if an invalid MPM was specified. · 19765ed0

Jeff Trawick authored Nov 21, 2001

Submitted by: jean-frederic clere <jfrederic.clere@fujitsu-siemens.com>
Reviewed by: Jeff Trawick

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92098 13f79535-47bb-0310-9956-ffa450edef68

19765ed0

Fix a bug in our output filter buffering. If a lot of small brigades are · c8d186a8

Ryan Bloom authored Nov 21, 2001

sent, the core will send the first 16 buckets, regardless of how much
data there is. In the pathological case, this can cause a lot of 16
byte packets. Now, if we see less than AP_MIN_BYTES, we combine
all of the buckets into a single bucket to be sent in a later packet.

This can cause a lot of memory copies, but it eases our network traffic.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92097 13f79535-47bb-0310-9956-ffa450edef68

c8d186a8

This was done a while ago. · 5419b0ec

Ryan Bloom authored Nov 21, 2001


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92096 13f79535-47bb-0310-9956-ffa450edef68

5419b0ec

include the appropriate header files for ntohs and htons to prevent · 551a2f16

Greg Ames authored Nov 21, 2001

OS/390 build failures.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92095 13f79535-47bb-0310-9956-ffa450edef68

551a2f16

move c->notes.ssl::client::dn to SSLConnRec.client_dn · 14045034

Doug MacEachern authored Nov 21, 2001

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92094 13f79535-47bb-0310-9956-ffa450edef68

14045034

start moving c->notes usage to a new SSLConnRec structure hanging off of · d21e0576

Doug MacEachern authored Nov 21, 2001

c->conn_config
PR:
Obtained from:
Submitted by:
Reviewed by: rbb, madhu


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92093 13f79535-47bb-0310-9956-ffa450edef68

d21e0576

let mod_file_cache use the new apr_mmap_dup function · 8494021d

Ian Holsman authored Nov 21, 2001

Submitted by:	Brian Pane


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92092 13f79535-47bb-0310-9956-ffa450edef68

8494021d

when this module's resolver calls were apr-ized recently we removed · 8d6e921d

Jeff Trawick authored Nov 21, 2001

the include of specific system header files; this left the opportunity
for htons() to be undefined... do something explicit for htons() so
we don't have to worry about what apr_network_io.h brings with it

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92091 13f79535-47bb-0310-9956-ffa450edef68

8d6e921d

Fix the timeout logic that I broke last week. This adds a request · d5cf06cb

Ryan Bloom authored Nov 21, 2001

level filter that sets the timeout on the socket that is connected
to the client.

Thanks Greg Stein for seeing this bug.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@92073 13f79535-47bb-0310-9956-ffa450edef68

d5cf06cb