Skip to content
GitLab
  1. 09 May, 1998 6 commits
    • Ken Coar's avatar
      · 1056f021
      Ken Coar authored 
      	Untangle the last patch..  ap_add_version_component() needs to
	*prepend* the strings it's fed, not append them.  This is because
	the last thing that calls it before the string is locked is
	ap_set_version() (as in set-like-cement), which adds the
	SERVER_BASEVERSION, the platform (conditionally), and the
	SERVER_SUBVERSION (if defined) at a known location - the front
	of the string.

	This has the drawback that module contributions will be listed
	in reverse order from their 'importance' (which is, in turn,
	in reverse order from their appearance in the Configuration
	file ;-).  However, only modules with major effects should be
	contributing to the string anyway, so we can consider them
	equal.  Can't we?

	The alternative is to either allow ap_set_version() to directly
	modify the string rather than going through ap_add...(), or else
	to add another routine that appends rather than prepends.  I
	don't like either of these because of the issues with semantics
	synchronisation and code duplication.

	The last patch confused things, though, so I'm just returning the
	behaviour to the original design - if someone wants to take
	extra steps to have module contributions listed in the same
	order as they're called, have a party.

	This should fix Rasmus' problem with the components being out
	of order, although it doesn't touch his issue with the init
	callback duplicating the SERVER_SUBVERSION effort.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@81211 13f79535-47bb-0310-9956-ffa450edef68
      1056f021
    • dgaudet's avatar
      The parent does the child signal reporting now. Adds SYS_SIGLIST. · 88f3a23f
      dgaudet authored 
      
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@81210 13f79535-47bb-0310-9956-ffa450edef68
      88f3a23f
    • brian's avatar
      PR: · b42130c3
      brian authored 
      This is a fix to make this not a show-stopper anymore.  Making a promise and
breaking it every now and then is worse than not making that promise.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@81209 13f79535-47bb-0310-9956-ffa450edef68
      b42130c3
    • Jim Jagielski's avatar
      Some votes · d724355a
      Jim Jagielski authored 
      
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@81208 13f79535-47bb-0310-9956-ffa450edef68
      d724355a
    • Jim Jagielski's avatar
      · a44a72f5
      Jim Jagielski authored 
      PR:
Obtained from:
Submitted by:
Reviewed by:
Fix the order of how the server_version string is built... All extra
components are tacked to the _end_ of the string. The front of the
server_version string is always SERVER_BASEVERSION. So if we have

    "Apache/1.3b7-dev (FreeBSD)"

and the code gets ap_add_version_component("PHP/3.0") we'd get:

    "Apache/1.3b7-dev (FreeBSD) PHP/3.0"


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@81207 13f79535-47bb-0310-9956-ffa450edef68
      a44a72f5
    • brian's avatar
      PR: · 1dfff7ca
      brian authored 
      garbage in, garbage out :)  removed the whole server string thing, added
two items from the list so we don't forget.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@81206 13f79535-47bb-0310-9956-ffa450edef68
      1dfff7ca
  3. 08 May, 1998 20 commits
  5. 07 May, 1998 13 commits
  7. 06 May, 1998 1 commit