Fix Expires (freshness) handling in mod_cache.
Previously, if the cached copy was stale, the response would go into an indeterminate state. Therefore, the freshness check must be done before we 'accept' the response and, if it fails (i.e. stale), we can't allow any side effects. This caused a number of changes to how mod_disk_cache reads its headers as ap_scan_script_header_err() purposely has side-effects and that's unacceptable. So, factor out only what we need. Also, remove the broken conditional filter code as you can't reliably alter the filter list once the response is started. (Regardless, cache_select_url() has the freshness checks now.) Assist to Sascha Schumann for reporting mod_cache was busted. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@105236 13f79535-47bb-0310-9956-ffa450edef68
parent
429e9d82
Please register or sign in to comment