Removed recently introduced bugs and disfigurements in APACI:
o fixed argument line processing: using $args was broken: It was not initialized and using args="$args $apc_option" and even args="$args \"$apc_option\"" fails in the second processing round for any arguments containing whitespaces. The only correct way is to use the construct "$@" (but not possible here) or iterate _both_ times over the implicit argument line (no argument to for-loop) which is what we now use. o make --with-layout=Apache the default without creating redundancy (copying the --with-layout block in the argument parsing loop). We achieve this by using the "$@" construct together with the `set' command to prepend --with-layout=Apache to the command line in case --with-layout is not used. o fixed auto-suffix handling now that config.layout exists. Paths which are auto-suffixed are marked with a trailing plus sign in config.layout and every path now can be marked this way (not only the four paths for which we do it currently). Additionally the suffix is no longer a static one. Instead it's now `/<target>' where <target> is the argument of the --target option or per default `httpd'. o allow also tabs (and only spaces) where we match whitespaces o various fixes and cleanups related to used shell coding style o made Jim happy by replacing `Written by' with `Initially written by' ;-) o trimmed output of --help to fit into 80 columns Now APACI is again clean and ready for 1.3.4 ;-) (IMHO) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@82492 13f79535-47bb-0310-9956-ffa450edef68
Loading
Please sign in to comment