Commit 8089adfe authored by Evgeny Kotkov's avatar Evgeny Kotkov
Browse files

mpm_winnt: Remove an unnecessary retry after receiving a non-timeout failure 

from the mpm_get_completion_context() function.

Currently, the only possible reasons why mpm_get_completion_context() could
fail are real errors such as being unable to WaitForSingleObject(), allocate
memory or create an event.  Retrying under such circumstances doesn't make
sense, and could be as well considered harmful.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1801146 13f79535-47bb-0310-9956-ffa450edef68
parent 2aae6167

server/mpm/winnt/child.c

+1 −8
Original line number Diff line number Diff line
@@ -438,15 +438,8 @@ reinit: /* target of connect upon too many AcceptEx failures */ 
            context = mpm_get_completion_context(&timeout);

            if (!context) {

                if (!timeout) {

                    /* Hopefully a temporary condition in the provider? */

                    ++err_count;

                    if (err_count > MAX_ACCEPTEX_ERR_COUNT) {

                        ap_log_error(APLOG_MARK, APLOG_CRIT, 0, ap_server_conf, APLOGNO(00335)

                                     "winnt_accept: Too many failures grabbing a "

                                     "connection ctx.  Aborting.");

                    break;

                }

                }

                Sleep(100);

                continue;

            }