Since the mod_mime patch was applied, here is the rest of the patch to introduce the ForceType and SetHandler [absolute references] directly into the very top of the fixups phase. This means these will always override _any_ mime module, not just mod_mime. Ergo, other mime modules can continue to set charset, encodings, etc. Since these are globals, they belong in the core. This highlights a very serious drawback to the type_checker hook. By using run first, a module that identifies _partial_ information (maybe just the content type) won't pass the query on to other modules, like mod_mime, that might further define the encoding or charset. The type_checker hook should clearly become a run-all, and the modules should decline if they see someone ahead of them answered a question they were going to try to figure. Which means - if type_checker becomes RUN_ALL - this new override hook fn should become a type_checker again - and RUN_REALLY_FIRST, and let other modules _choose_ not to override this election. (We can run it again at the end, for a recount ;) Votes? git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90797 13f79535-47bb-0310-9956-ffa450edef68
parent
faaad2e2
Please register or sign in to comment