(mostly) pass "gcc -Wall -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align
-Wstrict-prototypes -Wnested-externs". Notes: - Full prototypes are good, they catch errors at compile time. - Locals shadowing other locals or globals are bad, they cause errors inadvertantly (there once was a program with a global "int i;" ...). Even if the changes for this seem like gratuitous renaming, they're worth it in the long run. - Nested-externs are bad because they override the (correct) declarations of externs that (should be) provided by header files. - mod_rewrite isn't part of http_core and shouldn't be playing with the prelinked_modules variable. It now uses find_linked_module instead. - If an architecture doesn't use void (*)(int) as the prototypes for signal handlers we need to know, not cast it away. Note that void restart(int sig) has been around for a while so it's unlikely this will cause problems. - this is going to look huge as a context diff... I saved a unified if anyone wants to see it. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@78716 13f79535-47bb-0310-9956-ffa450edef68
Please register or sign in to comment