ap_table_set() causes an ap_pstrdup() of both arguments, one of the
arguments is a constant and it's a waste to pstrdup it. Furthermore using a static local buffer means there is a static limit to the message length. Also, ap_pvsprintf() can get away with zero-copies of the output in most cases, whereas ap_pstrdup() always copies the output at least once. Unlike Ken's claim there's no "gyration" required by ap_pv?sprintf() to figure out the string length. Clean this all up. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@82131 13f79535-47bb-0310-9956-ffa450edef68
Please register or sign in to comment