- Mar 25, 2004
-
-
Dr. Stephen Henson authored
I'll remember to try to compile this with warnings enabled next time :-)
-
Dr. Stephen Henson authored
-
Geoff Thorpe authored
locally initialising their own. NB: I've removed the "BN_clear_free()" loops for the exit-paths in some of these functions, and that may be a major part of the performance improvements we're seeing. The "free" part can be removed because we're using BN_CTX. The "clear" part OTOH can be removed because BN_CTX destruction automatically performs this task, so performing it inside functions that may be called repeatedly is wasteful. This is currently safe within openssl due to the fact that BN_CTX objects are never created for longer than a single high-level operation. However, that is only because there's currently no mechanism in openssl for thread-local storage. Beyond that, this might be an issue for applications using the bignum API directly and caching their own BN_CTX objects. The solution is to introduce a flag to BN_CTX_start() that allows its variables to be automatically sanitised on release during BN_CTX_end(). This way any higher-level function (and perhaps the application) can specify this flag in its own BN_CTX_start()/BN_CTX_end() pair, and this will cause inner-loop functions specifying the flag to be ignored so that sanitisation is handled only once back out at the higher level. I will be implementing this in the near future.
-
Geoff Thorpe authored
little TODO list in there as well as the debugging code (only enabled if BN_CTX_DEBUG is defined). I'd appreciate as much review and testing as can be spared for this. I'll commit some changes to other parts of the bignum code shortly to make better use of this implementation (no more fixed size limitations). Note also that under identical optimisations, I'm seeing a noticable speed increase over openssl-0.9.7 - so any feedback to confirm/deny this on other systems would also be most welcome.
-
Geoff Thorpe authored
curves. Submitted by: Nils Larsch
-
Geoff Thorpe authored
already built and tested.
-
Geoff Thorpe authored
operations no longer require two distinct BN_CTX structures. This may put more "strain" on the current BN_CTX implementation (which has a fixed limit to the number of variables it will hold), but so far this limit is not triggered by any of the tests pass and I will be changing BN_CTX in the near future to avoid this problem anyway. This also changes the default RSA implementation code to use the BN_CTX in favour of initialising some of its variables locally in each function.
-
Geoff Thorpe authored
dependency from asn1.
-
Geoff Thorpe authored
-
Geoff Thorpe authored
-
- Mar 24, 2004
-
-
Richard Levitte authored
-
Richard Levitte authored
-
Richard Levitte authored
-
Richard Levitte authored
SDIRS.
-
Richard Levitte authored
-
Richard Levitte authored
included.
-
Richard Levitte authored
-
Richard Levitte authored
-
Richard Levitte authored
-
- Mar 23, 2004
-
-
Richard Levitte authored
-
Richard Levitte authored
-
Richard Levitte authored
-
Dr. Stephen Henson authored
This is currently *very* experimental and needs to be more fully integrated with the main verification code.
-
- Mar 21, 2004
-
-
Richard Levitte authored
PR: 845
-
Richard Levitte authored
PR: 847
-
Richard Levitte authored
PR: 849
-
Richard Levitte authored
PR: 849
-
- Mar 17, 2004
-
-
Geoff Thorpe authored
porting efforts. Also, add Richard's name to the prior change.
-
Geoff Thorpe authored
- Remove some unnecessary "+1"-like fudges. Sizes should be handled exactly, as enlarging size parameters causes needless bloat and may just make bugs less likely rather than fixing them: bn_expand() macro, bn_expand_internal(), and BN_sqr(). - Deprecate bn_dup_expand() - it's new since 0.9.7, unused, and not that useful. - Remove unnecessary zeroing of unused bytes in bn_expand2(). - Rewrite BN_set_word() - it should be much simpler, the previous complexities probably date from old mismatched type issues. - Add missing bn_check_top() macros in bn_word.c - Improve some degenerate case handling in BN_[add|sub]_word(), add comments, and avoid a bignum expansion if an overflow isn't possible.
-
- Mar 16, 2004
-
-
Dr. Stephen Henson authored
-
- Mar 15, 2004
-
-
Richard Levitte authored
functions and macros. This change has associated tags: LEVITTE_before_const and LEVITTE_after_const. Those will be removed when this change has been properly reviewed.
-
Richard Levitte authored
-
Richard Levitte authored
compilers may complain.
-
Richard Levitte authored
-
- Mar 13, 2004
-
-
Geoff Thorpe authored
Remove certain redundant BN_zero() initialisations, because BN_CTX_get(), BN_init(), [etc] already initialise to zero. Correct error checking in bn_sqr.c, and be less wishy-wash about how/why the result's 'top' value is set (note also, 'max' is always > 0 at this point).
-
Geoff Thorpe authored
bignums are passed in and out of functions and APIs in a consistent form has highlighted that zero-valued bignums don't need any allocated word data. The use of BN_set_word() to initialise a bignum to zero causes needless allocation and gives it a return value that must be checked. This change converts BN_zero() to a self-contained macro that has no return/expression value and does not cause any expansion of bignum data. Note, it would be tempting to rewrite the deprecated version as a success-valued comma expression, such as; #define BN_zero(a) ((a)->top = (a)->neg = 0, 1) However, this evaluates 'a' twice and would confuse initialisation loops (eg. while(..) { BN_zero(bn++) } ). As such, the deprecated version continues to use BN_set_word().
-
Geoff Thorpe authored
change to work properly; BN_zero() should set 'neg' to zero as well as 'top' to match the behaviour of BN_new().
-
- Mar 12, 2004
-
-
Andy Polyakov authored
For reference. Note that both cc and gcc support -Wl flag, but we can't use -Wl,-[not]all with both drivers, because cc rearranges options passed through -Wl. We can't use -Wl,-all,libcrypto.a,-notall with cc either, because it refuses to start with "no input" error.
-
- Mar 10, 2004
-
-
Geoff Thorpe authored
-
- Mar 09, 2004
-
-
Geoff Thorpe authored
redefine bn_clear_top2max() to be a NOP in the non-debugging case, and remove some unnecessary usages in bn_nist.c. Submitted by: Nils Larsch Reviewed by: Geoff Thorpe, Ulf Möller
-