Commit 1fda5bc4 authored by Matt Caswell's avatar Matt Caswell
Browse files

Revert "Fixed deadlock in CRYPTO_THREAD_run_once for Windows" 



This reverts commit 349d1cfd.

The proposed fix is incorrect. It marks the "run_once" code as having
finished before it has. The intended semantics of run_once is that no
threads should proceed until the code has run exactly once. With this
change the "second" thread will think the run_once code has already been
run and will continue, even though it is still in progress. This could
result in a crash or other incorrect behaviour.

Reviewed-by: default avatarTim Hudson <tjh@openssl.org>
parent e72040c1

crypto/threads_win.c

+1 −1
Original line number Diff line number Diff line
@@ -78,8 +78,8 @@ int CRYPTO_THREAD_run_once(CRYPTO_ONCE *once, void (*init)(void)) 
    do {

        result = InterlockedCompareExchange(lock, ONCE_ININIT, ONCE_UNINITED);

        if (result == ONCE_UNINITED) {

            *lock = ONCE_DONE;

            init();

            *lock = ONCE_DONE;

            return 1;

        }

    } while (result == ONCE_ININIT);