fix(047): the triggers after the initial csource notification; the @context on PATCH

Ken Zangelinrequested to merge
fix/csub-notification-triggers into fix/csub-initial-notification

Merge after: the previous MR (the initial csource notification) - this branch is stacked on it.

The triggers of a context source registration subscription, after the initial notification; the @context on PATCH.

Spec: TS 104-175 clause 12.4.7: the initial notification is sent on subscription, then one for each change in a matching registration (create, update, delete).

Change:

  • 047_08 to 047_15 consume the initial notification before waiting for the one their trigger sends. 047_08 and 047_09 register Building and Bus.
  • 047_16 sends its PATCH with the suite's @context. Update Context Source Registration Subscription takes an optional context (a Link header).

Effect (against coraine): 12 Test Cases fail on develop and pass with this MR: 047_08_01, 047_09_01, 047_10_01, 047_11_01, 047_11_02, 047_12_01, 047_13_01, 047_14_01, 047_15_01, 047_16_01, 047_16_02, 047_16_03. None breaks.

Checks run: robocop format --check (0 files), scripts/find_unused_test_data.py (nothing new), statisticsDocumentationData.py (0 of 625 failed), doc unit tests OK.

Fix MR 11 of the plan: https://famzang.com/ttf/ngsi-ld-suite-plan.html

Edited by Ken Zangelin

Merge request reports

TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_08.robot

+2 −1
Changes for TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_08.robot: 2 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ Test Teardown Delete Created Context Source Registration And Context Sourc 




*** Variables ***

${context_source_registration_payload_file_path}=       csourceRegistrations/context-source-registration.jsonld

${context_source_registration_payload_file_path}=       csourceRegistrations/context-source-registration-building-and-bus-entities.jsonld

${subscription_payload_file_path}=                      csourceSubscriptions/subscription.jsonld

${update_fragment_file_path}=                           csourceRegistrations/fragments/context-source-registration-update.json
@@ -46,6 +46,7 @@ Create Initial Context Source Registration and Context Source Registration Subsc 
    Check Response Status Code    201    ${create_csr_response.status_code}

    ${create_csrsub_response}=    Create Context Source Registration Subscription    ${subscription_payload}

    Check Response Status Code    201    ${create_csrsub_response.status_code}

    Wait for notification

    Set Suite Variable    ${context_source_registration_id}

    Set Suite Variable    ${subscription_id}

TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_09.robot

+2 −1
Changes for TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_09.robot: 2 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ Suite Teardown Delete Created Context Source Registration And Context Sourc 




*** Variables ***

${context_source_registration_payload_file_path}=       csourceRegistrations/context-source-registration.jsonld

${context_source_registration_payload_file_path}=       csourceRegistrations/context-source-registration-building-and-bus-entities.jsonld

${subscription_payload_file_path}=                      csourceSubscriptions/subscription.jsonld

${update_fragment_file_path}=                           csourceRegistrations/fragments/context-source-registration-update-information.json
@@ -46,6 +46,7 @@ Create Initial Context Source Registration And Context Source Registration Subsc 
    Check Response Status Code    201    ${create_csr_response.status_code}

    ${create_csrsub_response}=    Create Context Source Registration Subscription    ${subscription_payload}

    Check Response Status Code    201    ${create_csrsub_response.status_code}

    Wait for notification

    Set Suite Variable    ${context_source_registration_id}

    Set Suite Variable    ${subscription_id}

TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_10.robot

+1 −0
Changes for TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_10.robot: 1 added line, 0 removed lines.
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ Setup Initial Context Source Registration Subscription 
    ...    ${subscription_id}

    ${create_csrsub_response}=    Create Context Source Registration Subscription    ${subscription_payload}

    Check Response Status Code    201    ${create_csrsub_response.status_code}

    Wait for notification

    Set Suite Variable    ${subscription_id}



Delete Created Context Source Registration And Subscription

TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_11.robot

+1 −0
Changes for TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_11.robot: 1 added line, 0 removed lines.
Original line number Diff line number Diff line
@@ -34,6 +34,7 @@ Receive cSourceNotification For Matching Context Source Registrations On Managem 
    ${subscription_payload}=    Load Subscription Sample With Reachable Endpoint    ${filepath}    ${subscription_id}

    ${response}=    Create Context Source Registration Subscription    ${subscription_payload}

    Check Response Status Code    201    ${response.status_code}

    Wait for notification

    ${context_source_registration_id}=    Generate Random CSR Id

    Set Suite Variable    ${context_source_registration_id}

    ${context_source_registration_payload}=    Load Test Sample

TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_12.robot

+1 −0
Changes for TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_12.robot: 1 added line, 0 removed lines.
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ Setup Initial Context Source Registration Subscription 
    ...    ${subscription_id}

    ${create_csrsub_response}=    Create Context Source Registration Subscription    ${subscription_payload}

    Check Response Status Code    201    ${create_csrsub_response.status_code}

    Wait for notification

    Set Suite Variable    ${subscription_id}



Delete Created Context Source Registration And Subscription