From adaaa05b99429668e2bdf402bfaac5c1629fc7a7 Mon Sep 17 00:00:00 2001
From: Giacomo Bernini <g.bernini@nextworks.it>
Date: Wed, 14 Oct 2020 16:28:01 +0200
Subject: [PATCH] fix for issue #121 in SOL002-VNFIndicator-API
---
.../IndividualVNFindicator.robot | 1 -
SOL002/VNFIndicator-API/Subscriptions.robot | 3 +--
SOL002/VNFIndicator-API/VNFIndicators.robot | 1 -
.../VnfIndicatorsInVnfInstanceId.robot | 1 -
.../environment/individualSubscription.txt | 5 ----
.../environment/individualVnfIndicator.txt | 6 -----
.../environment/subscriptions.txt | 10 -------
.../environment/variables.txt | 26 ++++++++++++++++++-
.../environment/vnfIndicatorinVnfInstance.txt | 7 -----
.../environment/vnfIndicators.txt | 8 ------
10 files changed, 26 insertions(+), 42 deletions(-)
delete mode 100644 SOL002/VNFIndicator-API/environment/individualSubscription.txt
delete mode 100644 SOL002/VNFIndicator-API/environment/individualVnfIndicator.txt
delete mode 100644 SOL002/VNFIndicator-API/environment/subscriptions.txt
delete mode 100644 SOL002/VNFIndicator-API/environment/vnfIndicatorinVnfInstance.txt
delete mode 100644 SOL002/VNFIndicator-API/environment/vnfIndicators.txt
diff --git a/SOL002/VNFIndicator-API/IndividualVNFindicator.robot b/SOL002/VNFIndicator-API/IndividualVNFindicator.robot
index 19b7fb46..437cb6f3 100644
--- a/SOL002/VNFIndicator-API/IndividualVNFindicator.robot
+++ b/SOL002/VNFIndicator-API/IndividualVNFindicator.robot
@@ -1,7 +1,6 @@
*** Settings ***
Library JSONSchemaLibrary schemas/
Resource environment/variables.txt # Generic Parameters
-Resource environment/individualVnfIndicator.txt
Library REST ${EM-VNF_SCHEMA}://${EM-VNF_HOST}:${EM-VNF_PORT} ssl_verify=false
*** Test Cases ***
diff --git a/SOL002/VNFIndicator-API/Subscriptions.robot b/SOL002/VNFIndicator-API/Subscriptions.robot
index 0e208cd3..d0f7f89d 100644
--- a/SOL002/VNFIndicator-API/Subscriptions.robot
+++ b/SOL002/VNFIndicator-API/Subscriptions.robot
@@ -1,7 +1,6 @@
*** Settings ***
Library JSONSchemaLibrary schemas/
Resource environment/variables.txt # Generic Parameters
-Resource environment/subscriptions.txt
Library OperatingSystem
Library JSONLibrary
Library Process
@@ -220,7 +219,7 @@ Send Post Request for VNF Indicator Subscription
Set Headers {"Accept": "${ACCEPT_JSON}"}
Set Headers {"Content-Type": "${CONTENT_TYPE_JSON}"}
${template}= Get File jsons/subscriptions.json
- ${body}= Format String ${template} callback_uri=${callback_uri} callback_endpoint=${callback_endpoint}
+ ${body}= Format String ${template} callback_uri=${callback_uri} callback_endpoint=${callback_endpoint}
Run Keyword If ${AUTH_USAGE} == 1 Set Headers {"Authorization": "${AUTHORIZATION}"}
POST ${apiRoot}/${apiName}/${apiMajorVersion}/subscriptions ${body}
${output}= Output response
diff --git a/SOL002/VNFIndicator-API/VNFIndicators.robot b/SOL002/VNFIndicator-API/VNFIndicators.robot
index f3f8f20f..0addde85 100644
--- a/SOL002/VNFIndicator-API/VNFIndicators.robot
+++ b/SOL002/VNFIndicator-API/VNFIndicators.robot
@@ -4,7 +4,6 @@ Library JSONSchemaLibrary schemas/
Resource environment/variables.txt # Generic Parameters
Library JSONLibrary
Library String
-Resource environment/vnfIndicators.txt
Library REST ${EM-VNF_SCHEMA}://${EM-VNF_HOST}:${EM-VNF_PORT} ssl_verify=false
*** Test Cases ***
diff --git a/SOL002/VNFIndicator-API/VnfIndicatorsInVnfInstanceId.robot b/SOL002/VNFIndicator-API/VnfIndicatorsInVnfInstanceId.robot
index 14cb8897..b25da021 100644
--- a/SOL002/VNFIndicator-API/VnfIndicatorsInVnfInstanceId.robot
+++ b/SOL002/VNFIndicator-API/VnfIndicatorsInVnfInstanceId.robot
@@ -2,7 +2,6 @@
Documentation This resource represents VNF indicators related to a VNF instance. The client can use this resource to query multiple VNF indicators that are related to a particular VNF instance.
Library JSONSchemaLibrary schemas/
Resource environment/variables.txt # Generic Parameters
-Resource environment/vnfIndicatorinVnfInstance.txt
Library JSONLibrary
Library String
Library REST ${EM-VNF_SCHEMA}://${EM-VNF_HOST}:${EM-VNF_PORT} ssl_verify=false
diff --git a/SOL002/VNFIndicator-API/environment/individualSubscription.txt b/SOL002/VNFIndicator-API/environment/individualSubscription.txt
deleted file mode 100644
index 1ae75929..00000000
--- a/SOL002/VNFIndicator-API/environment/individualSubscription.txt
+++ /dev/null
@@ -1,5 +0,0 @@
-*** Variables ***
-${subscriptionId} f3ae6df7-07e1-47c9-8924-9ebe10343586
-${erroneousSubscriptionId} 442e3ee5-0499-4849-9b31-eb91ce1638f1 # Not existing ID on the subscriptions
-${response}= httpresponse
-${origResponse}= httpresponse
\ No newline at end of file
diff --git a/SOL002/VNFIndicator-API/environment/individualVnfIndicator.txt b/SOL002/VNFIndicator-API/environment/individualVnfIndicator.txt
deleted file mode 100644
index 5e90a5d7..00000000
--- a/SOL002/VNFIndicator-API/environment/individualVnfIndicator.txt
+++ /dev/null
@@ -1,6 +0,0 @@
-*** Variables ***
-${vnfInstanceId} 80b0deba-c398-445b-bef0-ac0fe733e3d0
-${indicatorId} 34e70855-a9d3-4fef-aece-76a3cd266ec8
-${notAllowedIndicatorId} notAllowedId
-${erroneousIndicatorId} erroneousIndicatorId
-${response}= httpresponse
diff --git a/SOL002/VNFIndicator-API/environment/subscriptions.txt b/SOL002/VNFIndicator-API/environment/subscriptions.txt
deleted file mode 100644
index ec4b63ac..00000000
--- a/SOL002/VNFIndicator-API/environment/subscriptions.txt
+++ /dev/null
@@ -1,10 +0,0 @@
-*** Variables ***
-${vnfInstanceId} 80b0deba-c398-445b-bef0-ac0fe733e3d0
-${indicatorId} 34e70855-a9d3-4fef-aece-76a3cd266ec8
-${erroneousIndicatorId} erroneousIndicatorId
-${POS_FILTER} callbackUri=http://127.0.0.1/subscribe
-${NEG_FILTER} callback=http://127.0.0.1/subscribe
-${response}= httpresponse
-${total_polling_time} 2 min
-${polling_interval} 10 sec
-${SEPERATOR} =
\ No newline at end of file
diff --git a/SOL002/VNFIndicator-API/environment/variables.txt b/SOL002/VNFIndicator-API/environment/variables.txt
index 22f32a1f..b0843366 100644
--- a/SOL002/VNFIndicator-API/environment/variables.txt
+++ b/SOL002/VNFIndicator-API/environment/variables.txt
@@ -24,4 +24,28 @@ ${callback_port} 9091
${callback_endpoint} /endpoint
${callback_endpoint_error} /endpoint_404
-${response} some_response_object
\ No newline at end of file
+${response} some_response_object
+
+
+${subscriptionId} f3ae6df7-07e1-47c9-8924-9ebe10343586
+${erroneousSubscriptionId} 442e3ee5-0499-4849-9b31-eb91ce1638f1 # Not existing ID on the subscriptions
+${origResponse}= httpresponse
+
+${vnfInstanceId} 80b0deba-c398-445b-bef0-ac0fe733e3d0
+${indicatorId} 34e70855-a9d3-4fef-aece-76a3cd266ec8
+${notAllowedIndicatorId} notAllowedId
+${erroneousIndicatorId} erroneousIndicatorId
+
+${POS_FILTER} callbackUri=http://127.0.0.1/subscribe
+${NEG_FILTER} callback=http://127.0.0.1/subscribe
+${total_polling_time} 2 min
+${polling_interval} 10 sec
+${SEPERATOR} =
+
+${erroneousVnfInstanceId} erroneousVnfInstanceId
+${POS_FIELDS} name=vnfIndicator
+${NEG_FIELDS} wrongName=any_value
+
+
+${vnfIndicators} =
+${VAR_SEPERATOR} &
\ No newline at end of file
diff --git a/SOL002/VNFIndicator-API/environment/vnfIndicatorinVnfInstance.txt b/SOL002/VNFIndicator-API/environment/vnfIndicatorinVnfInstance.txt
deleted file mode 100644
index 8651dee3..00000000
--- a/SOL002/VNFIndicator-API/environment/vnfIndicatorinVnfInstance.txt
+++ /dev/null
@@ -1,7 +0,0 @@
-*** Variables ***
-${vnfInstanceId} 80b0deba-c398-445b-bef0-ac0fe733e3d0
-${erroneousVnfInstanceId} erroneousVnfInstanceId
-${POS_FIELDS} name=vnfIndicator
-${NEG_FIELDS} wrongName=any_value
-${response}= httpresponse
-${SEPERATOR} =
\ No newline at end of file
diff --git a/SOL002/VNFIndicator-API/environment/vnfIndicators.txt b/SOL002/VNFIndicator-API/environment/vnfIndicators.txt
deleted file mode 100644
index 84765907..00000000
--- a/SOL002/VNFIndicator-API/environment/vnfIndicators.txt
+++ /dev/null
@@ -1,8 +0,0 @@
-*** Variables ***
-${POS_FIELDS} name=vnfIndicator&vnfInstanceId=80b0deba-c398-445b-bef0-ac0fe733e3d0
-${NEG_FIELDS} wrongName=wrongValue
-${response} some_response_object
-${vnfIndicators} =
-${SEPERATOR} =
-${VAR_SEPERATOR} &
-${POS_FILTER} =
\ No newline at end of file
--
GitLab