From 3bf89d35cbc8b861ca49f72e7cd8d1290c2e6740 Mon Sep 17 00:00:00 2001
From: Giacomo Bernini <g.bernini@nextworks.it>
Date: Wed, 10 Apr 2019 10:06:22 +0200
Subject: [PATCH] updated test doc as per TST#113

---
 .../IndividualReport.robot                            | 11 +++++------
 .../IndividualThreshold.robot                         | 10 +++++-----
 SOL002/VNFPerformanceManagement-API/Thresholds.robot  |  5 ++---
 3 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/SOL002/VNFPerformanceManagement-API/IndividualReport.robot b/SOL002/VNFPerformanceManagement-API/IndividualReport.robot
index 8ee08506..bac1b68c 100644
--- a/SOL002/VNFPerformanceManagement-API/IndividualReport.robot
+++ b/SOL002/VNFPerformanceManagement-API/IndividualReport.robot
@@ -22,7 +22,7 @@ Get Individual Performance Report
 Get Individual Performance Report with invalid resource endpoint
         [Documentation]    Test ID: 6.3.3.3.2
     ...    Test title: Get Individual Performance Report with invalid resource endpoint
-    ...    Test objective: The objective is to test the retrieval of an individual VNF performance report associated to a monitoring job and perform a JSON schema validation of the collected report data structure
+    ...    Test objective:  The objective is to test that the retrieval of an individual VNF performance report associated to a monitoring job fails when using an invalid resource endpoint 
     ...    Pre-conditions: A VNF instance is instantiated. One or more VNF performance reports are set for a monitoring job in the VNFM.
     ...    Reference: section 6.4.4.3.2 - SOL002 v2.4.1
     ...    Config ID: Config_prod_VNFM
@@ -30,7 +30,6 @@ Get Individual Performance Report with invalid resource endpoint
     ...    Post-Conditions: none
     Get Individual Performance Report with invalid resource endpoint
     Check HTTP Response Status Code Is    404
-    Check HTTP Response Body Json Schema Is   ProblemDetails
 
 POST Individual Performance Report - Method not implemented
     [Documentation]    Test ID: 6.3.3.3.3
@@ -49,7 +48,7 @@ PUT Individual Performance Report - Method not implemented
     [Documentation]    Test ID: 6.3.3.3.4
     ...    Test title: PUT Individual Performance Report - Method not implemented
     ...    Test objective: The objective is to test that PUT method is not allowed to update an existing VNF performance report within a monitoring job
-    ...    Pre-conditions: A VNF instance is instantiated.
+    ...    Pre-conditions: A VNF instance is instantiated. One or more VNF performance reports are set for a monitoring job in the VNFM.
     ...    Reference: section 6.4.4.3.3 - SOL002 v2.4.1
     ...    Config ID: Config_prod_VNFM
     ...    Applicability: none
@@ -62,7 +61,7 @@ PATCH Individual Performance Report - Method not implemented
     [Documentation]    Test ID: 6.3.3.3.5
     ...    Test title: PATCH Individual Performance Report - Method not implemented
     ...    Test objective: The objective is to test that PATCH method is not allowed to modify an existing VNF performance report within a monitoring job
-    ...    Pre-conditions: A VNF instance is instantiated.
+    ...    Pre-conditions: A VNF instance is instantiated. One or more VNF performance reports are set for a monitoring job in the VNFM.
     ...    Reference: section 6.4.4.3.4 - SOL002 v2.4.1
     ...    Config ID: Config_prod_VNFM
     ...    Applicability: none
@@ -74,8 +73,8 @@ PATCH Individual Performance Report - Method not implemented
 DELETE Individual Performance Report - Method not implemented
     [Documentation]    Test ID: 6.3.3.3.6
     ...    Test title: DELETE Individual Performance Report - Method not implemented
-    ...    Test objective: The objective is to test that DELET method is not allowed to delete an existing VNF performance report within a monitoring job
-    ...    Pre-conditions: A VNF instance is instantiated.
+    ...    Test objective: The objective is to test that DELETE method is not allowed to delete an existing VNF performance report within a monitoring job
+    ...    Pre-conditions: A VNF instance is instantiated. One or more VNF performance reports are set for a monitoring job in the VNFM.
     ...    Reference: section 6.4.4.3.5 - SOL002 v2.4.1
     ...    Config ID: Config_prod_VNFM
     ...    Applicability: none
diff --git a/SOL002/VNFPerformanceManagement-API/IndividualThreshold.robot b/SOL002/VNFPerformanceManagement-API/IndividualThreshold.robot
index ccc32980..36aa1af5 100644
--- a/SOL002/VNFPerformanceManagement-API/IndividualThreshold.robot
+++ b/SOL002/VNFPerformanceManagement-API/IndividualThreshold.robot
@@ -41,14 +41,14 @@ DELETE Individual Threshold
     ...    Reference: section 6.4.6.3.5 - SOL002 v2.4.1
     ...    Config ID: Config_prod_VNFM
     ...    Applicability: none
-    ...    Post-Conditions: The VNF Performance Threshold is no more available in the VNFM    
+    ...    Post-Conditions: The VNF Performance Threshold is not available anymore in the VNFM    
     Send Delete request for individual VNF Performance Threshold
     Check HTTP Response Status Code Is    204
     Check Postcondition VNF Performance Threshold is Deleted
 
-DELETE Individual Threshold with invalid resource indentifier
+DELETE Individual Threshold with invalid resource identifier
     [Documentation]    Test ID: 6.3.3.5.4
-    ...    Test title: DELETE Individual Threshold with invalid resource indentifier
+    ...    Test title: DELETE Individual Threshold with invalid resource identifier
     ...    Test objective: The objective is to test the deletion of an individual VNF performance threshold
     ...    Pre-conditions: A VNF instance is instantiated. One or more VNF performance thresholds are set in the VNFM.
     ...    Reference: section 6.4.6.3.5 - SOL002 v2.4.1
@@ -75,7 +75,7 @@ PUT Individual Threshold - Method not implemented
     [Documentation]    Test ID: 6.3.3.5.6
     ...    Test title: PUT Individual Threshold - Method not implemented
     ...    Test objective: The objective is to test that PUT method is not allowed to update an existing VNF Performance threshold
-    ...    Pre-conditions: A VNF instance is instantiated. One or more VNF performance threhsolds are set in the VNFM.
+    ...    Pre-conditions: A VNF instance is instantiated. One or more VNF performance thresholds are set in the VNFM.
     ...    Reference: section 6.4.6.3.3 - SOL002 v2.4.1
     ...    Config ID: Config_prod_VNFM
     ...    Applicability: none
@@ -88,7 +88,7 @@ PATCH Individual Threshold - Method not implemented
     [Documentation]    Test ID: 6.3.3.5.7
     ...    Test title: PATCH Individual Threshold - Method not implemented
     ...    Test objective: The objective is to test that PATCH method is not allowed to modify an existing VNF Performance threshold
-    ...    Pre-conditions: A VNF instance is instantiated. One or more VNF performance threhsolds are set in the VNFM.
+    ...    Pre-conditions: A VNF instance is instantiated. One or more VNF performance thresholds are set in the VNFM.
     ...    Reference: section 6.4.6.3.4 - SOL002 v2.4.1
     ...    Config ID: Config_prod_VNFM
     ...    Applicability: none
diff --git a/SOL002/VNFPerformanceManagement-API/Thresholds.robot b/SOL002/VNFPerformanceManagement-API/Thresholds.robot
index c7737154..31929617 100644
--- a/SOL002/VNFPerformanceManagement-API/Thresholds.robot
+++ b/SOL002/VNFPerformanceManagement-API/Thresholds.robot
@@ -44,8 +44,7 @@ GET Performance Thresholds with invalid attribute-based filter
     ...    Applicability: none
     ...    Post-Conditions: none
     GET Performance Thresholds with invalid attribute-based filter
-    Check HTTP Response Status Code Is    400
-    Check HTTP Response Body Json Schema Is   ProblemDetails
+    Check HTTP Response Status Code Is    404
 
 GET Performance Thresholds with invalid resource endpoint
     [Documentation]    Test ID: 6.3.3.4.4
@@ -107,7 +106,7 @@ DELETE Performance Thresholds - Method not implemented
     ...    Reference: section 6.4.5.3.5 - SOL002 v2.4.1
     ...    Config ID: Config_prod_VNFM
     ...    Applicability: none
-    ...    Post-Conditions: none
+    ...    Post-Conditions: The VNF performance thresholds are not deleted by the failed operation
     Send DELETE Request for all Performance Thresholds
     Check HTTP Response Status Code Is    405
     Check Postcondition Thresholds Exist
-- 
GitLab