From 02145d843a099e6ebf7e02431dfbcfdfcc51c166 Mon Sep 17 00:00:00 2001
From: root <root@DESKTOP-A5SJGL5.localdomain>
Date: Fri, 24 Jan 2020 13:07:37 +0500
Subject: [PATCH] bug-fixes
---
.../IndividualVNFInstance.robot | 2 +-
.../VNFLifecycleManagement-API/Subscriptions.robot | 6 +++---
.../IndividualVNFInstance.robot | 6 +++---
.../VNFLifecycleManagement-API/ScaleVNFTask.robot | 7 ++++---
.../ScaleVNFToLevelTask.robot | 7 ++++---
.../TerminateVNFTask.robot | 4 ++--
.../VNFLifecycleManagement-API/VNFInstances.robot | 13 ++++++++-----
.../VnfLcmMntOperationKeywords.robot | 6 +++++-
.../VNFLifecycleOperationGranting-API/Grants.robot | 7 ++++---
.../CreateNSInstanceWorkflow.robot | 2 +-
.../DeleteNSInstanceWorkflow.robot | 4 ++--
.../HealNSTaskWorkflow.robot | 2 +-
.../InstanciateNSTaskWorkflow.robot | 2 +-
.../ScaleNSTaskWorkflow.robot | 2 +-
.../TerminateNSTaskWorkflow.robot | 2 +-
.../UpdateNSTaskWorkflow.robot | 2 +-
16 files changed, 42 insertions(+), 32 deletions(-)
diff --git a/SOL002/VNFLifecycleManagement-API/IndividualVNFInstance.robot b/SOL002/VNFLifecycleManagement-API/IndividualVNFInstance.robot
index 2f85514b..c2db6cbb 100644
--- a/SOL002/VNFLifecycleManagement-API/IndividualVNFInstance.robot
+++ b/SOL002/VNFLifecycleManagement-API/IndividualVNFInstance.robot
@@ -67,7 +67,7 @@ PATCH Individual VNFInstance Precondition failed
[Documentation] Test ID: 6.3.5.2.5
... Test title: PATCH Individual VNFInstance Precondition failed
... Test objective: The objective is to create a new VNF instance resource
- ... Pre-conditions: A precondition given in an HTTP request header is not fulfilled. Typically, this is due to an ETag mismatch, indicating that the resource was modified by another entity
+ ... Pre-conditions: VNF Instance is Created
... Reference: clause 5.4.3.3.4 - ETSI GS NFV-SOL 002 [2] v2.4.1
... Config ID: Config_prod_VE
... Applicability:
diff --git a/SOL002/VNFLifecycleManagement-API/Subscriptions.robot b/SOL002/VNFLifecycleManagement-API/Subscriptions.robot
index d36fd9da..05fbdda0 100644
--- a/SOL002/VNFLifecycleManagement-API/Subscriptions.robot
+++ b/SOL002/VNFLifecycleManagement-API/Subscriptions.robot
@@ -27,7 +27,7 @@ POST Create a new Subscription - DUPLICATION
... Pre-conditions: none
... Reference: clause 5.4.18.3.1 - ETSI GS NFV-SOL 002 [2] v2.4.1
... Config ID: Config_prod_VE
- ... Applicability: none
+ ... Applicability: SUT should support duplication of subscription creation
... Post-Conditions: in response header Location shall not be null
... POST Cancel operation task
Post Create subscription - DUPLICATION
@@ -41,7 +41,7 @@ POST Create a new Subscription - NO-DUPLICATION
... Pre-conditions: none
... Reference: clause 5.4.18.3.1 - ETSI GS NFV-SOL 002 [2] v2.4.1
... Config ID: Config_prod_VE
- ... Applicability: none
+ ... Applicability: SUT should not support duplication of subscription creation
... Post-Conditions: in response header Location shall not be null
... POST Cancel operation task
Post Create subscription - NO-DUPLICATION
@@ -170,7 +170,7 @@ DELETE subscriptions - Method not implemented
... Reference: clause 5.4.18.3.5 - ETSI GS NFV-SOL 002 [2] v2.4.1
... Config ID: Config_prod_VE
... Applicability: none
- ... Post-Conditions: none
+ ... Post-Conditions: check that resources are not deleted
DELETE subscriptions
Check HTTP Response Status Code Is 405
\ No newline at end of file
diff --git a/SOL003/VNFLifecycleManagement-API/IndividualVNFInstance.robot b/SOL003/VNFLifecycleManagement-API/IndividualVNFInstance.robot
index a0de1987..f60fef9e 100644
--- a/SOL003/VNFLifecycleManagement-API/IndividualVNFInstance.robot
+++ b/SOL003/VNFLifecycleManagement-API/IndividualVNFInstance.robot
@@ -37,7 +37,6 @@ Get Information about an individual VNF Instance
GET individual vnfInstance
Check HTTP Response Status Code Is 200
Check HTTP Response Body Json Schema Is vnfInstance
- SET etag
PUT Individual VNFInstance - Method not implemented
[Documentation] Test ID: 7.3.1.2.3
@@ -68,7 +67,7 @@ PATCH Individual VNFInstance Precondition failed
[Documentation] Test ID: 7.3.1.2.5
... Test title: PATCH Individual VNFInstance Precondition failed
... Test objective: The objective is to create a new VNF instance resource
- ... Pre-conditions: ETag mismatch
+ ... Pre-conditions: VNF Instance created (Test ID 7.3.1.2.2)
... Reference: clause 5.4.3.3.4 - ETSI GS NFV-SOL 003 [1] v2.4.1
... Config ID: Config_prod_VNFM
... Applicability:
@@ -110,10 +109,11 @@ DELETE Individual VNFInstance Conflict
... Reference: clause 5.4.3.3.5 - ETSI GS NFV-SOL 003 [1] v2.4.1
... Config ID: Config_prod_VNFM
... Applicability:
- ... Post-Conditions:
+ ... Post-Conditions: Resources are not deleted
DELETE individual vnfInstance
Check HTTP Response Status Code Is 409
Check HTTP Response Body Json Schema Is ProblemDetails
+ Check resource existence
*** Keywords ***
Check resource existence
diff --git a/SOL003/VNFLifecycleManagement-API/ScaleVNFTask.robot b/SOL003/VNFLifecycleManagement-API/ScaleVNFTask.robot
index 6d5d5e30..2ec76591 100644
--- a/SOL003/VNFLifecycleManagement-API/ScaleVNFTask.robot
+++ b/SOL003/VNFLifecycleManagement-API/ScaleVNFTask.robot
@@ -13,7 +13,7 @@ POST Scale a vnfInstance
[Documentation] Test ID: 7.3.1.4.1
... Test title: POST Scale a vnfInstance
... Test objective: The objective is to scale a VNF instance
- ... Pre-conditions: none
+ ... Pre-conditions: VNF instance resource is in INSTANTIATED state
... Reference: clause 5.4.5.3.1 - ETSI GS NFV-SOL 003 [1] v2.4.1
... Config ID: Config_prod_VNFM
... Applicability:
@@ -94,9 +94,10 @@ DELETE Scale VNFInstance - Method not implemented
... Reference: clause 5.4.5.3.5 - ETSI GS NFV-SOL 003 [1] v2.4.1
... Config ID: Config_prod_VNFM
... Applicability:
- ... Post-Conditions:
+ ... Post-Conditions: Resource are not deleted
DELETE Scale vnfInstance
Check HTTP Response Status Code Is 405
+ Check resource existence
*** Keywords ***
Check resource existence
@@ -126,4 +127,4 @@ Launch another LCM operation
Run Keyword If ${AUTH_USAGE} == 1 Set Headers {"Authorization":"${AUTHORIZATION}"}
${body}= Get File jsons/scaleVnfToLevelRequest.json
Post ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${vnfInstanceId}/scale_to_level ${body}
- Integer response status 202
\ No newline at end of file
+ Integer response status 202
diff --git a/SOL003/VNFLifecycleManagement-API/ScaleVNFToLevelTask.robot b/SOL003/VNFLifecycleManagement-API/ScaleVNFToLevelTask.robot
index 6fa08f91..17db5612 100644
--- a/SOL003/VNFLifecycleManagement-API/ScaleVNFToLevelTask.robot
+++ b/SOL003/VNFLifecycleManagement-API/ScaleVNFToLevelTask.robot
@@ -12,7 +12,7 @@ POST Scale a vnfInstance to level
[Documentation] Test ID: 7.3.1.5.1
... Test title: POST Scale a vnfInstance to level
... Test objective: The objective is to scale a VNF instance to a target level.
- ... Pre-conditions: none
+ ... Pre-conditions: VNF is Instantiated
... Reference: clause 5.4.6.3.1 - ETSI GS NFV-SOL 003 [1] v2.4.1
... Config ID: Config_prod_VNFM
... Applicability:
@@ -95,9 +95,10 @@ DELETE Scale to level VNFInstance - Method not implemented
... Reference: clause 5.4.6.3.5 - ETSI GS NFV-SOL 003 [1] v2.4.1
... Config ID: Config_prod_VNFM
... Applicability:
- ... Post-Conditions:
+ ... Post-Conditions: Resources are not deleted
DELETE Scale vnfInstance to level
Check HTTP Response Status Code Is 405
+ Check resource existence
*** Keywords ***
Check resource existence
@@ -127,4 +128,4 @@ Launch another LCM operation
Run Keyword If ${AUTH_USAGE} == 1 Set Headers {"Authorization":"${AUTHORIZATION}"}
${body}= Get File jsons/scaleVnfRequest.json
Post ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${vnfInstanceId}/scale ${body}
- Integer response status 202
\ No newline at end of file
+ Integer response status 202
diff --git a/SOL003/VNFLifecycleManagement-API/TerminateVNFTask.robot b/SOL003/VNFLifecycleManagement-API/TerminateVNFTask.robot
index a4f2fe2c..fee74627 100644
--- a/SOL003/VNFLifecycleManagement-API/TerminateVNFTask.robot
+++ b/SOL003/VNFLifecycleManagement-API/TerminateVNFTask.robot
@@ -13,7 +13,7 @@ POST Terminate a vnfInstance
[Documentation] Test ID: 7.3.1.7.1
... Test title: POST Terminate a vnfInstance
... Test objective: The objective is to test that POST method terminate a VNF instance
- ... Pre-conditions: none
+ ... Pre-conditions: Resource state is INSTANTIATED
... Reference: clause 5.4.8.3.1 - ETSI GS NFV-SOL 003 [1] v2.4.1
... Config ID: Config_prod_VNFM
... Applicability: none
@@ -112,4 +112,4 @@ Launch another LCM operation
Run Keyword If ${AUTH_USAGE} == 1 Set Headers {"Authorization":"${AUTHORIZATION}"}
${body}= Get File jsons/scaleVnfRequest.json
Post ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${vnfInstanceId}/scale ${body}
- Integer response status 202
\ No newline at end of file
+ Integer response status 202
diff --git a/SOL003/VNFLifecycleManagement-API/VNFInstances.robot b/SOL003/VNFLifecycleManagement-API/VNFInstances.robot
index e0b5a40b..b0729e23 100644
--- a/SOL003/VNFLifecycleManagement-API/VNFInstances.robot
+++ b/SOL003/VNFLifecycleManagement-API/VNFInstances.robot
@@ -102,7 +102,7 @@ GET information about multiple VNF instances with "fields" attribute selector
Check HTTP Response Body Json Schema Is vnfInstances
GET information about multiple VNF instances with "exclude_fields" attribute selector
- [Documentation] Test ID: 7.3.1.1.7
+ [Documentation] Test ID: 7.3.1.1.8
... Test title: GET information about multiple VNF instances with "exclude_fields" attribute selector
... Test objective: The objective is to query information about multiple VNF instances
... Pre-conditions:
@@ -115,7 +115,7 @@ GET information about multiple VNF instances with "exclude_fields" attribute sel
Check HTTP Response Body Json Schema Is vnfInstances
PUT multiples VNFInstances - Method not implemented
- [Documentation] Test ID: 7.3.1.1.5
+ [Documentation] Test ID: 7.3.1.1.9
... Test title: PUT multiples VNFInstances - Method not implemented
... Test objective: The objective is to test that PUT method is not implemented
... Pre-conditions:
@@ -127,7 +127,7 @@ PUT multiples VNFInstances - Method not implemented
Check HTTP Response Status Code Is 405
PATCH multiples VNFInstances - Method not implemented
- [Documentation] Test ID: 7.3.1.1.6
+ [Documentation] Test ID: 7.3.1.1.10
... Test title: PATCH multiples VNFInstances - Method not implemented
... Test objective: The objective is to test that PATCH method is not implemented
... Pre-conditions:
@@ -139,13 +139,16 @@ PATCH multiples VNFInstances - Method not implemented
Check HTTP Response Status Code Is 405
DELETE VNFInstances - Method not implemented
- [Documentation] Test ID: 7.3.1.1.7
+ [Documentation] Test ID: 7.3.1.1.11
... Test title: DELETE multiples VNFInstances - Method not implemented
... Test objective: The objective is to test that DELETE method is not implemented
... Pre-conditions:
... Reference: clause 5.4.2.3.5 - ETSI GS NFV-SOL 003 [1] v2.4.1
... Config ID: Config_prod_VNFM
... Applicability:
- ... Post-Conditions:
+ ... Post-Conditions: resources are not deleted
DELETE multiple vnfInstances
Check HTTP Response Status Code Is 405
+ Verify Resources not Deleted
+
+
diff --git a/SOL003/VNFLifecycleManagement-API/VnfLcmMntOperationKeywords.robot b/SOL003/VNFLifecycleManagement-API/VnfLcmMntOperationKeywords.robot
index f94a5510..c3f4267a 100644
--- a/SOL003/VNFLifecycleManagement-API/VnfLcmMntOperationKeywords.robot
+++ b/SOL003/VNFLifecycleManagement-API/VnfLcmMntOperationKeywords.robot
@@ -1147,4 +1147,8 @@ GET test endpoint
Create Mock Expectation ${req} ${rsp}
Sleep ${sleep_interval}
Verify Mock Expectation ${req}
- Clear Requests ${callback_endpoint}
\ No newline at end of file
+ Clear Requests ${callback_endpoint}
+Verify Resources not Deleted
+ GET multiple vnfInstances
+ Check HTTP Response Status Code Is 200
+ Check HTTP Response Body Json Schema Is vnfInstances
\ No newline at end of file
diff --git a/SOL003/VNFLifecycleOperationGranting-API/Grants.robot b/SOL003/VNFLifecycleOperationGranting-API/Grants.robot
index c9abf0d8..c3e01243 100644
--- a/SOL003/VNFLifecycleOperationGranting-API/Grants.robot
+++ b/SOL003/VNFLifecycleOperationGranting-API/Grants.robot
@@ -47,7 +47,7 @@ Requests a grant for a particular VNF lifecycle operation - Forbidden
[Documentation] Test ID: 7.3.2.1.3
... Test title: Requests a grant for a particular VNF lifecycle operation - Forbidden
... Test objective: The objective is to request a grant for a particular VNF lifecycle operation and check the content of the problem details data structure returned
- ... Pre-conditions: The grant should not be accorded
+ ... Pre-conditions: none
... Reference: clause 9.4.2.3.2 - ETSI GS NFV-SOL 003 [1] v2.4.1
... Config ID: Config_prod_NFVO
... Applicability: none
@@ -100,9 +100,10 @@ DELETE Grants - Method not implemented
... Reference: clause 9.4.2.3.5 - ETSI GS NFV-SOL 003 [1] v2.4.1
... Config ID: Config_prod_NFVO
... Applicability: none
- ... Post-Conditions: none
+ ... Post-Conditions: resources are not deleted
Delete Grants
Check HTTP Response Status Code Is 405
+ Get an individual grant - Successful
*** Keywords ***
Wait for individual grant successful notification
@@ -214,4 +215,4 @@ Delete Grants
${body}= Output response
Set Suite Variable &{response} ${body}
-
\ No newline at end of file
+
diff --git a/SOL005/NSLifecycleManagement-API/CreateNSInstanceWorkflow.robot b/SOL005/NSLifecycleManagement-API/CreateNSInstanceWorkflow.robot
index db919f10..348e7e87 100644
--- a/SOL005/NSLifecycleManagement-API/CreateNSInstanceWorkflow.robot
+++ b/SOL005/NSLifecycleManagement-API/CreateNSInstanceWorkflow.robot
@@ -10,7 +10,7 @@ Library JSONSchemaLibrary schemas/
*** Test Cases ***
NS Instance Creation
- [Documentation] Test ID: 5.3.2.17
+ [Documentation] Test ID: 5.3.2.18.1
... Test title: NS Instance Creation
... Test objective: The objective is to test the workflow for Creating a NS instance
... Pre-conditions: none
diff --git a/SOL005/NSLifecycleManagement-API/DeleteNSInstanceWorkflow.robot b/SOL005/NSLifecycleManagement-API/DeleteNSInstanceWorkflow.robot
index 38ca80c7..157fd663 100644
--- a/SOL005/NSLifecycleManagement-API/DeleteNSInstanceWorkflow.robot
+++ b/SOL005/NSLifecycleManagement-API/DeleteNSInstanceWorkflow.robot
@@ -8,14 +8,14 @@ Library JSONSchemaLibrary schemas/
*** Test Cases ***
NS Instance Deletion
- [Documentation] Test ID: 5.3.2.18
+ [Documentation] Test ID: 5.3.2.18.2
... Test title: NS Instance Deletion
... Test objective: The objective is to test the workflow for Deleting a NS instance
... Pre-conditions: the resource is in NOT_INSTANTIATED state
... Reference: clause 6.3.2 - ETSI GS NFV-SOL 005 [3] v2.4.1
... Config ID: Config_prod_NFVO
... Applicability: none
- ... Post-Conditions: none
+ ... Post-Conditions: Resource should be deleted
Check resource not_instantiated
DELETE IndividualNSInstance
Check HTTP Response Status Code Is 204
diff --git a/SOL005/NSLifecycleManagement-API/HealNSTaskWorkflow.robot b/SOL005/NSLifecycleManagement-API/HealNSTaskWorkflow.robot
index 5f9018bb..f6fbfad5 100644
--- a/SOL005/NSLifecycleManagement-API/HealNSTaskWorkflow.robot
+++ b/SOL005/NSLifecycleManagement-API/HealNSTaskWorkflow.robot
@@ -10,7 +10,7 @@ Suite Teardown Terminate All Processes kill=true
*** Test Cases ***
Heal Flow of NS lifecycle management operations
- [Documentation] Test ID: 5.3.2.19
+ [Documentation] Test ID: 5.3.2.18.3
... Test title: Heal Flow of NS lifecycle management operations
... Test objective: The objective is to test the workflow for Healing a NS instance
... Pre-conditions: the resource is in INSTANTIATED state
diff --git a/SOL005/NSLifecycleManagement-API/InstanciateNSTaskWorkflow.robot b/SOL005/NSLifecycleManagement-API/InstanciateNSTaskWorkflow.robot
index 8535a8a8..2ef539a4 100644
--- a/SOL005/NSLifecycleManagement-API/InstanciateNSTaskWorkflow.robot
+++ b/SOL005/NSLifecycleManagement-API/InstanciateNSTaskWorkflow.robot
@@ -10,7 +10,7 @@ Suite Teardown Terminate All Processes kill=true
*** Test Cases ***
Instantiate Flow of NS lifecycle management operations
- [Documentation] Test ID: 5.3.2.20
+ [Documentation] Test ID: 5.3.2.18.4
... Test title: Instantiate Flow of NS lifecycle management operations
... Test objective: The objective is to test the workflow for Instantiate a NS instance
... Pre-conditions: the resource is in NOT_INSTANTIATED state
diff --git a/SOL005/NSLifecycleManagement-API/ScaleNSTaskWorkflow.robot b/SOL005/NSLifecycleManagement-API/ScaleNSTaskWorkflow.robot
index eb144503..2624d994 100644
--- a/SOL005/NSLifecycleManagement-API/ScaleNSTaskWorkflow.robot
+++ b/SOL005/NSLifecycleManagement-API/ScaleNSTaskWorkflow.robot
@@ -10,7 +10,7 @@ Suite Teardown Terminate All Processes kill=true
*** Test Cases ***
Scale Flow of NS lifecycle management operations
- [Documentation] Test ID: 5.3.2.21
+ [Documentation] Test ID: 5.3.2.18.5
... Test title: Instantiate Flow of NS lifecycle management operations
... Test objective: The objective is to test the workflow for Instantiate a NS instance
... Pre-conditions: the resource is in NOT_INSTANTIATED state
diff --git a/SOL005/NSLifecycleManagement-API/TerminateNSTaskWorkflow.robot b/SOL005/NSLifecycleManagement-API/TerminateNSTaskWorkflow.robot
index 05681f5c..383cec24 100644
--- a/SOL005/NSLifecycleManagement-API/TerminateNSTaskWorkflow.robot
+++ b/SOL005/NSLifecycleManagement-API/TerminateNSTaskWorkflow.robot
@@ -10,7 +10,7 @@ Suite Teardown Terminate All Processes kill=true
*** Test Cases ***
Terminate Flow of NS lifecycle management operations
- [Documentation] Test ID: 5.3.2.22
+ [Documentation] Test ID: 5.3.2.18.6
... Test title: Terminate Flow of NS lifecycle management operations
... Test objective: The objective is to test the workflow for Terminate a NS instance
... Pre-conditions: the resource is in INSTANTIATED state
diff --git a/SOL005/NSLifecycleManagement-API/UpdateNSTaskWorkflow.robot b/SOL005/NSLifecycleManagement-API/UpdateNSTaskWorkflow.robot
index 844a85b8..de681d76 100644
--- a/SOL005/NSLifecycleManagement-API/UpdateNSTaskWorkflow.robot
+++ b/SOL005/NSLifecycleManagement-API/UpdateNSTaskWorkflow.robot
@@ -10,7 +10,7 @@ Suite Teardown Terminate All Processes kill=true
*** Test Cases ***
Update Flow of NS lifecycle management operations
- [Documentation] Test ID: 5.3.2.23
+ [Documentation] Test ID: 5.3.2.18.7
... Test title: Update Flow of NS lifecycle management operations
... Test objective: The objective is to test the workflow for Update a NS instance
... Pre-conditions: the resource is in INSTANTIATED state
--
GitLab