Commit d223bac9 authored by Najam UI Hassan's avatar Najam UI Hassan
Browse files

fixx typos, issues and minor bugs

parent 4524d915

SOL002/VNFLifecycleManagement-API/CancelOperationTask.robot

+3 −18
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ Post Cancel operation task 
    ...    Reference: Clause 5.4.17.3.1 - ETSI GS NFV-SOL 002 [2] v2.7.1

    ...    Config ID: Config_prod_VE

    ...    Applicability: none

    ...    Post-Conditions: none    

    ...    Post-Conditions: the resource is in FAILED_TEMP state    

    POST Cancel operation task

    Check HTTP Response Status Code Is    202

    Check operation resource state is FAILED_TEMP
@@ -47,6 +47,7 @@ Post Cancel operation task Not Found 
    ...    Post-Conditions: none  

    POST Cancel operation task

    Check HTTP Response Status Code Is    404

    Check HTTP Response Body Json Schema Is    ProblemDetails

    

GET Cancel operation task - Method not implemented

    [Documentation]    Test ID: 6.3.5.16.4
@@ -102,19 +103,3 @@ Check resource existence 
    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_lcm_op_occs/${vnfLcmOpOccId}

    Integer    response status    200
 
 No newline at end of file
 


Launch another error handling action

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Post    ${apiRoot}/${apiName}/${apiVersion}/vnf_lcm_op_occs/${vnfLcmOpOccId}/retry

    Integer    response status    202

    

Check Fail not supported

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_lcm_op_occs/${vnfLcmOpOccId}

    # how to check if Fail is not supported?

    



Check resource FAILED_TEMP

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_lcm_op_occs/${vnfLcmOpOccId} 

    String    response body operationState    FAILED_TEMP
 
 No newline at end of file

SOL002/VNFLifecycleManagement-API/ChangeExternalVNFConnectivityTask.robot

+6 −14
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ Suite Setup Check resource existence 
POST Change external VNF connectivity 

    [Documentation]    Test ID: 6.3.5.10.1

    ...    Test title: POST Change external VNF connectivity

    ...    Test objective: The objective is to test that POST method trigger a change in VNF external connectivity

    ...    Test objective: The objective is to test that POST method triggers a change in VNF external connectivity

    ...    Pre-conditions: none

    ...    Reference: Clause 5.4.11.3.1 - ETSI GS NFV-SOL 002 [2] v2.7.1

    ...    Config ID: Config_prod_VE
@@ -69,16 +69,16 @@ DELETE Change external VNF connectivity - Method not implemented 
    DELETE Change External VNF Connectivity

    Check HTTP Response Status Code Is    405

    

POST Operate a vnfInstance Conflict (Not-Instantiated)

POST Change external VNF connectivity Conflict

    [Documentation]    Test ID: 6.3.5.10.6

    ...    Test title: POST Operate a vnfInstance Conflict (Not-Instantiated)

    ...    Test title: POST Change external VNF connectivity Conflict

    ...    Test objective: The objective is to test that the operation cannot be executed currently, due to a conflict with the state of the VNF instance resource or that a required child attribute of the "extensions" attribue has not been set. 

    ...    Pre-conditions: none

    ...    Reference: Clause 5.4.11.3.1 - ETSI GS NFV-SOL 002 [2] v2.7.1

    ...    Config ID: Config_prod_VE

    ...    Applicability: none

    ...    Post-Conditions:

    POST Operate VNF

    ...    Post-Conditions: none

    POST Change External VNF Connectivity

    Check HTTP Response Status Code Is    409

    Check HTTP Response Body Json Schema Is    ProblemDetails
@@ -89,11 +89,3 @@ Check resource existence 
    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${vnfInstanceId} 

    Integer    response status    200
 
 No newline at end of file
 


Launch another LCM operation

    Set Headers  {"Accept":"${ACCEPT}"}  

    Set Headers  {"Content-Type": "${CONTENT_TYPE}"}

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    ${body}=    Get File    jsons/scaleVnfRequest.json

    Post    ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${vnfInstanceId}/scale    ${body}

    Integer    response status    202
 
 No newline at end of file

SOL002/VNFLifecycleManagement-API/ChangeVNFFlavourTask.robot

+2 −27
Original line number Diff line number Diff line
@@ -34,7 +34,6 @@ POST Change deployment flavour of a vnfInstance Conflict (Not-Instantiated) 
    Check HTTP Response Status Code Is    409

    Check HTTP Response Body Json Schema Is    ProblemDetails



    

POST Change deployment flavour of a vnfInstance Not Found

    [Documentation]    Test ID: 6.3.5.6.3

    ...    Test title: POST Change deployment flavour of a vnfInstance Not Found
@@ -48,7 +47,6 @@ POST Change deployment flavour of a vnfInstance Not Found 
    Check HTTP Response Status Code Is    404

    Check HTTP Response Body Json Schema Is    ProblemDetails

       

    

GET Change deployment flavour VNFInstance - Method not implemented

    [Documentation]    Test ID: 6.3.5.6.4

    ...    Test title: GET Change deployment flavour VNFInstance - Method not implemented
@@ -104,26 +102,3 @@ Check resource existence 
    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${vnfInstanceId} 

    Integer    response status    200
 
 No newline at end of file
 


Check resource not instantiated

    [Arguments]    ${instanceId}

    Set Headers    {"Accept":"${ACCEPT}"}  

    Set Headers    {"Content-Type": "${CONTENT_TYPE}"}

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${instanceId} 

    String    response body instantiationState    NOT_INSTANTIATED



Check change flavour not supported

    Set Headers    {"Accept":"${ACCEPT}"}  

    Set Headers    {"Content-Type": "${CONTENT_TYPE}"}

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${vnfInstanceId} 

    # how to check if change floavour is not supported? "flavourId" doesn't exist?



Launch another LCM operation

    Set Headers  {"Accept":"${ACCEPT}"}  

    Set Headers  {"Content-Type": "${CONTENT_TYPE}"}

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    ${body}=    Get File    jsons/scaleVnfRequest.json

    Post    ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${vnfInstanceId}/scale    ${body}

    Integer    response status    202
 
 No newline at end of file

SOL002/VNFLifecycleManagement-API/FailOperationTask.robot

+9 −32
Original line number Diff line number Diff line
@@ -10,7 +10,7 @@ Library JSONSchemaLibrary schemas/ 
POST Fail operation task  

    [Documentation]    Test ID: 6.3.5.15.1

    ...    Test title: POST Fail operation task

    ...    Test objective: The objective is to test that POST method mark as "finally failed" a VNF lifecycle operation if that operation has experienced a temporary failure

    ...    Test objective: The objective is to test that POST method mark as "finally failed" a VNF lifecycle operation if that operation has experienced a failure

    ...    Pre-conditions: the "VNF LCM operation occurrence" resource is in "FAILED_TEMP" state.

    ...    Reference: Clause 5.4.16.3.1 - ETSI GS NFV-SOL 002 [2] v2.7.1

    ...    Config ID: Config_prod_VE
@@ -22,10 +22,9 @@ POST Fail operation task 
    Check operation resource state is FINALLY_FAILED



POST Fail operation task Conflict (Not-FAILED_TEMP)

    # TODO: Need to set the pre-condition of the test. VNF instance shall be in INSTANTIATED state

    [Documentation]    Test ID: 6.3.5.15.2

    ...    Test title: POST Fail operation task Conflict (Not-FAILED_TEMP)

    ...    Test objective: The objective is to test that POST method cannot mark as "finally failed" a VNF lifecycle operation if that operation has experienced a temporary failure

    ...    Test objective: The objective is to test that POST method cannot mark as "finally failed" due to confilct with the state of LCM Operation Occurrence

    ...    Pre-conditions: the "VNF LCM operation occurrence" resource is not in "FAILED_TEMP" state.

    ...    Reference: Clause 5.4.16.3.1 - ETSI GS NFV-SOL 002 [2] v2.7.1

    ...    Config ID: Config_prod_VE
@@ -36,17 +35,17 @@ POST Fail operation task Conflict (Not-FAILED_TEMP) 
    Check HTTP Response Body Json Schema Is    ProblemDetails



POST Fail operation task Not Found

    # TODO: Need to create a vnfInstance which's instantiatedVnfInfo.scaleStatus is absent

    [Documentation]    Test ID: 6.3.5.15.3

    ...    Test title: POST Fail operation task Not Found

    ...    Test objective: The objective is to test that POST method cannot mark as "finally failed" a VNF lifecycle operation because the operation is not supported

    ...    Pre-conditions: 

    ...    Pre-conditions: none

    ...    Reference: Clause 5.4.16.3.1 - ETSI GS NFV-SOL 002 [2] v2.7.1

    ...    Config ID: Config_prod_VE

    ...    Applicability: none

    ...    Post-Conditions: none  

    Post Fail operation

    Check HTTP Response Status Code Is    404

    Check HTTP Response Body Json Schema Is    ProblemDetails



GET Fail operation task - Method not implemented

     [Documentation]    Test ID: 6.3.5.15.4
@@ -56,7 +55,7 @@ GET Fail operation task - Method not implemented 
    ...    Reference: Clause 5.4.16.3.2 - ETSI GS NFV-SOL 002 [2] v2.7.1

    ...    Config ID: Config_prod_VE

    ...    Applicability: none

    ...    Post-Conditions: 

    ...    Post-Conditions: none

    Get Fail operation

    Check HTTP Response Status Code Is    405
@@ -68,7 +67,7 @@ PUT Fail operation task - Method not implemented 
    ...    Reference: Clause 5.4.16.3.3 - ETSI GS NFV-SOL 002 [2] v2.7.1

    ...    Config ID: Config_prod_VE

    ...    Applicability: none

    ...    Post-Conditions: 

    ...    Post-Conditions: none 

    Put Fail operation

    Check HTTP Response Status Code Is    405
@@ -80,7 +79,7 @@ PATCH Fail operation task - Method not implemented 
    ...    Reference: Clause 5.4.16.3.4 - ETSI GS NFV-SOL 002 [2] v2.7.1

    ...    Config ID: Config_prod_VE

    ...    Applicability: none

    ...    Post-Conditions: 

    ...    Post-Conditions: none 

    Patch Fail operation

    Check HTTP Response Status Code Is    405
@@ -92,28 +91,6 @@ DELETE Fail operation task - Method not implemented 
    ...    Reference: Clause 5.4.16.3.5 - ETSI GS NFV-SOL 002 [2] v2.7.1

    ...    Config ID: Config_prod_VE

    ...    Applicability: none

    ...    Post-Conditions: VNF instance not deleted

    ...    Post-Conditions: none

    Delete Fail operation

    Check HTTP Response Status Code Is    405
 
 No newline at end of file
 


*** Keywords ***

Check resource existence

    Set Headers    {"Accept":"${ACCEPT}"} 

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_lcm_op_occs/${vnfLcmOpOccId}

    Integer    response status    200



Launch another error handling action

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Post    ${apiRoot}/${apiName}/${apiVersion}/vnf_lcm_op_occs/${vnfLcmOpOccId}/retry

    Integer    response status    202

    

Check Fail not supported

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_lcm_op_occs/${vnfLcmOpOccId}

    # how to check if Fail is not supported?



Check resource FAILED_TEMP

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_lcm_op_occs/${vnfLcmOpOccId} 

    String    response body operationState    FAILED_TEMP
 
 No newline at end of file

SOL002/VNFLifecycleManagement-API/HealVNFTask.robot

+1 −25
Original line number Diff line number Diff line
@@ -22,7 +22,6 @@ POST Heal a vnfInstance 
    Check Operation Occurrence Id

    

POST Heal a vnfInstance Conflict (Not-Instantiated)

    # TODO: Need to set the pre-condition of the test. VNF instance shall be in INSTANTIATED state

   [Documentation]    Test ID: 6.3.5.8.2

    ...    Test title: POST Heal a vnfInstance (Not-Instantiated)

    ...    Test objective: The objective is to test that the operation cannot be executed currently, due to a conflict with the state of the VNF instance resource or that a required child attribute of the "extensions" attribue has not been set.
@@ -104,26 +103,3 @@ Check resource existence 
    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${vnfInstanceId} 

    Integer    response status    200
 
 No newline at end of file
 


Check resource not instantiated

    [Arguments]    ${instanceId}

    Set Headers    {"Accept":"${ACCEPT}"}  

    Set Headers    {"Content-Type": "${CONTENT_TYPE}"}

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${instanceId} 

    String    response body instantiationState    NOT_INSTANTIATED



Check heal not supported

    Set Headers    {"Accept":"${ACCEPT}"}  

    Set Headers    {"Content-Type": "${CONTENT_TYPE}"}

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    Get    ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${vnfInstanceId} 

    # how to check if heal is not supported? "flavourId" doesn't exist?



Launch another LCM operation

    Set Headers  {"Accept":"${ACCEPT}"}  

    Set Headers  {"Content-Type": "${CONTENT_TYPE}"}

    Run Keyword If    ${AUTH_USAGE} == 1    Set Headers    {"Authorization":"${AUTHORIZATION}"}

    ${body}=    Get File    jsons/scaleVnfRequest.json

    Post    ${apiRoot}/${apiName}/${apiVersion}/vnf_instances/${vnfInstanceId}/scale    ${body}

    Integer    response status    202
 
 No newline at end of file